Re: RFR: 8352905: Open some JComboBox bugs 1 [v4]

2025-04-21 Thread Harshitha Onkar
On Mon, 21 Apr 2025 22:56:30 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > update tests LGTM. Approved. Plz verify if CI testing looks good before integrating.

Re: RFR: 8352905: Open some JComboBox bugs 1 [v4]

2025-04-21 Thread Harshitha Onkar
On Mon, 21 Apr 2025 22:56:30 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > update tests @alisenchung Updated changes LGTM. Does CI Testing look good for the aut

Re: RFR: 8352905: Open some JComboBox bugs 1 [v3]

2025-04-21 Thread Alisen Chung
On Mon, 21 Apr 2025 18:19:10 GMT, Harshitha Onkar wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix test > > test/jdk/javax/swing/JComboBox/bug4530952.java line 81: > >> 79: robot.delay(250); >> 80:

Re: RFR: 8352905: Open some JComboBox bugs 1 [v4]

2025-04-21 Thread Alisen Chung
> Updating and opening some tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: update tests - Changes: - all: https://git.openjdk.org/jdk/pull/24495/files - new: https://git.openjdk.org/jdk/pull/24495/files/9b36a1

Re: RFR: 8352905: Open some JComboBox bugs 1 [v3]

2025-04-21 Thread Harshitha Onkar
On Fri, 18 Apr 2025 22:28:56 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > fix test test/jdk/javax/swing/JComboBox/bug4530952.java line 81: > 79: r

Re: RFR: 8352905: Open some JComboBox bugs 1 [v3]

2025-04-21 Thread Harshitha Onkar
On Fri, 18 Apr 2025 22:28:56 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > fix test Changes requested by honkar (Reviewer). test/jdk/javax/swing/JComboBox/bug4

Re: RFR: 8352905: Open some JComboBox bugs 1 [v3]

2025-04-18 Thread Alisen Chung
> Updating and opening some tests Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: fix test - Changes: - all: https://git.openjdk.org/jdk/pull/24495/files - new: https://git.openjdk.org/jdk/pull/24495/files/57bb0878..

Re: RFR: 8352905: Open some JComboBox bugs 1 [v2]

2025-04-16 Thread Sergey Bylokhov
On Wed, 16 Apr 2025 08:22:19 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with two additional > commits since the last revision: > > - update tests > - update tests test/jdk/javax/swing/JComboBox/bug4530952.java line

Re: RFR: 8352905: Open some JComboBox bugs 1 [v2]

2025-04-16 Thread Prasanta Sadhukhan
On Wed, 16 Apr 2025 08:22:19 GMT, Alisen Chung wrote: >> Updating and opening some tests > > Alisen Chung has updated the pull request incrementally with two additional > commits since the last revision: > > - update tests > - update tests Marked as reviewed by psadhukhan (Reviewer). --

Re: RFR: 8352905: Open some JComboBox bugs 1 [v2]

2025-04-16 Thread Alisen Chung
On Fri, 11 Apr 2025 03:52:05 GMT, Sergey Bylokhov wrote: >> Alisen Chung has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update tests >> - update tests > > test/jdk/javax/swing/JComboBox/bug4166593.java line 65: > >> 63: } >>

Re: RFR: 8352905: Open some JComboBox bugs 1 [v2]

2025-04-16 Thread Alisen Chung
> Updating and opening some tests Alisen Chung has updated the pull request incrementally with two additional commits since the last revision: - update tests - update tests - Changes: - all: https://git.openjdk.org/jdk/pull/24495/files - new: https://git.openjdk.org/jdk/pull/

Re: RFR: 8352905: Open some JComboBox bugs 1

2025-04-10 Thread Prasanta Sadhukhan
On Mon, 7 Apr 2025 22:50:14 GMT, Alisen Chung wrote: > Updating and opening some tests test/jdk/javax/swing/JComboBox/bug4530952.java line 120: > 118: > 119: btnAction.setEnabled(false); > 120: frame.getContentPane().add(btnAction); all redundant getContentPane() can be remove

Re: RFR: 8352905: Open some JComboBox bugs 1

2025-04-10 Thread Prasanta Sadhukhan
On Mon, 7 Apr 2025 22:50:14 GMT, Alisen Chung wrote: > Updating and opening some tests test/jdk/javax/swing/JComboBox/bug4180054.java line 57: > 55: comboBox.setSelectedIndex(1); > 56: comboBox.setSelectedIndex(3); > 57: comboBox.setSelectedIndex(2); guess o

Re: RFR: 8352905: Open some JComboBox bugs 1

2025-04-10 Thread Sergey Bylokhov
On Mon, 7 Apr 2025 22:50:14 GMT, Alisen Chung wrote: > Updating and opening some tests test/jdk/javax/swing/JComboBox/bug4166593.java line 65: > 63: } > 64: > 65: if (frame != null) { frame is initialized on a different thread and accessed here without proper synchronization.

RFR: 8352905: Open some JComboBox bugs 1

2025-04-07 Thread Alisen Chung
Updating and opening some tests - Commit messages: - open tests Changes: https://git.openjdk.org/jdk/pull/24495/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24495&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352905 Stats: 430 lines in 4 files changed: 430 ins