On Thu, 28 Aug 2025 07:53:29 GMT, Anass Baya wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to al
On Thu, 28 Aug 2025 07:53:29 GMT, Anass Baya wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to al
> **Analysis:**
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
>
> **Proposed Fix:**
> We are intentionally overriding getFocusableWindowState() to allow it to
> change the configuration, in order to verify th
On Wed, 27 Aug 2025 18:34:05 GMT, Alexey Ivanov wrote:
>> Anass Baya has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add space
>
> src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java line 1105:
>
>> 1103: }
>> 1104:
On Wed, 20 Aug 2025 05:05:20 GMT, Anass Baya wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to al
On Wed, 20 Aug 2025 05:05:20 GMT, Anass Baya wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to al
On Tue, 26 Aug 2025 00:52:17 GMT, Sergey Bylokhov wrote:
> looks fine, please confirm that all tests are green.
Yes, the tests pass with the proposed fix
-
PR Comment: https://git.openjdk.org/jdk/pull/26298#issuecomment-3222628788
On Wed, 20 Aug 2025 05:05:20 GMT, Anass Baya wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to al
> **Analysis:**
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
>
> **Proposed Fix:**
> We are intentionally overriding getFocusableWindowState() to allow it to
> change the configuration, in order to verify th
On Wed, 20 Aug 2025 03:33:32 GMT, Sergey Bylokhov wrote:
>> Anass Baya has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Respect rules
>> - remove space
>> - Update focusability only when it is needed
>
> src/java.desktop/unix/classe
On Fri, 8 Aug 2025 00:30:25 GMT, Anass Baya wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to all
On Tue, 15 Jul 2025 19:52:15 GMT, Alisen Chung wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to
On Thu, 31 Jul 2025 14:21:33 GMT, Anass Baya wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to al
> **Analysis:**
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
>
> **Proposed Fix:**
> We are intentionally overriding getFocusableWindowState() to allow it to
> change the configuration, in order to verify th
On Tue, 15 Jul 2025 02:52:54 GMT, Sergey Bylokhov wrote:
> I do not think this is a bug in the test, the jdk should survive this.
Hello @mrserb,
Thank you for your reivew.
To ensure Linux survives that, I think we need to avoid updating focusability
when it is not necessary.
--- XWindowPeer.j
> **Analysis:**
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
>
> **Proposed Fix:**
> We are intentionally overriding getFocusableWindowState() to allow it to
> change the configuration, in order to verify th
> **Analysis:**
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
>
> **Proposed Fix:**
> We are intentionally overriding getFocusableWindowState() to allow it to
> change the configuration, in order to verify th
On Tue, 15 Jul 2025 19:52:15 GMT, Alisen Chung wrote:
> > The getFocusableWindowState() method is not intended to modify the
> > configuration; doing so can cause recursive re-entry on Linux.
>
> What's causing the recursive re-entry? Is the bug in the code path in linux
> when calling getFocu
On Mon, 14 Jul 2025 17:00:35 GMT, Anass Baya wrote:
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
What's causing the recursive re-entry? Is the bug in the code path in linux
when calling getFocusableWindowS
On Mon, 14 Jul 2025 17:00:35 GMT, Anass Baya wrote:
> **Analysis:**
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
>
> **Proposed Fix:**
> We are intentionally overriding getFocusableWindowState() to allow it
On Mon, 14 Jul 2025 21:47:10 GMT, Alisen Chung wrote:
>> **Analysis:**
>> The getFocusableWindowState() method is not intended to modify the
>> configuration; doing so can cause recursive re-entry on Linux.
>>
>> **Proposed Fix:**
>> We are intentionally overriding getFocusableWindowState() to
On Mon, 14 Jul 2025 17:00:35 GMT, Anass Baya wrote:
> **Analysis:**
> The getFocusableWindowState() method is not intended to modify the
> configuration; doing so can cause recursive re-entry on Linux.
>
> **Proposed Fix:**
> We are intentionally overriding getFocusableWindowState() to allow it
**Analysis:**
The getFocusableWindowState() method is not intended to modify the
configuration; doing so can cause recursive re-entry on Linux.
**Proposed Fix:**
We are intentionally overriding getFocusableWindowState() to allow it to change
the configuration, in order to verify that calling get
23 matches
Mail list logo
