Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v4]

2022-06-29 Thread Alexey Ivanov
On Wed, 29 Jun 2022 17:17:11 GMT, Harshitha Onkar wrote: >> Currently PassFailJFrame.positionTestFrame() and >> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been >> changed to Window. >> >> Refactored the above method names to reflect the functionality & input >> para

Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v4]

2022-06-29 Thread Alexander Zvegintsev
On Wed, 29 Jun 2022 17:17:11 GMT, Harshitha Onkar wrote: >> Currently PassFailJFrame.positionTestFrame() and >> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been >> changed to Window. >> >> Refactored the above method names to reflect the functionality & input >> para

Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v4]

2022-06-29 Thread Harshitha Onkar
> Currently PassFailJFrame.positionTestFrame() and > PassFailJFrame.addTestFrame() take Frame as input parameter, this has been > changed to Window. > > Refactored the above method names to reflect the functionality & input > parameter type - > addTestWindow(), positionTestWindow() > > Additio

Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v3]

2022-06-29 Thread Harshitha Onkar
> Currently PassFailJFrame.positionTestFrame() and > PassFailJFrame.addTestFrame() take Frame as input parameter, this has been > changed to Window. > > Refactored the above method names to reflect the functionality & input > parameter type - > addTestWindow(), positionTestWindow() > > Additio

Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v2]

2022-06-29 Thread Alexey Ivanov
On Tue, 28 Jun 2022 20:30:36 GMT, Harshitha Onkar wrote: >> Currently PassFailJFrame.positionTestFrame() and >> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been >> changed to Window. >> >> Refactored the above method names to reflect the functionality & input >> para

Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v2]

2022-06-29 Thread Alexey Ivanov
On Tue, 28 Jun 2022 20:30:36 GMT, Harshitha Onkar wrote: >> Currently PassFailJFrame.positionTestFrame() and >> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been >> changed to Window. >> >> Refactored the above method names to reflect the functionality & input >> para

Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v2]

2022-06-28 Thread Harshitha Onkar
On Tue, 28 Jun 2022 19:07:04 GMT, Alexander Zvegintsev wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> method doc changes > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 263: > >> 261: * win

Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework [v2]

2022-06-28 Thread Harshitha Onkar
> Currently PassFailJFrame.positionTestFrame() and > PassFailJFrame.addTestFrame() take Frame as input parameter, this has been > changed to Window. > > Refactored the above method names to reflect the functionality & input > parameter type - > addTestWindow(), positionTestWindow() > > Additio

Re: RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework

2022-06-28 Thread Alexander Zvegintsev
On Tue, 28 Jun 2022 00:58:42 GMT, Harshitha Onkar wrote: > Currently PassFailJFrame.positionTestFrame() and > PassFailJFrame.addTestFrame() take Frame as input parameter, this has been > changed to Window. > > Refactored the above method names to reflect the functionality & input > parameter

RFR: JDK-8289238: Refactoring changes to PassFailJFrame Test Framework

2022-06-27 Thread Harshitha Onkar
Currently PassFailJFrame.positionTestFrame() and PassFailJFrame.addTestFrame() take Frame as input parameter, this has been changed to Window. Refactored the above method names to reflect the functionality & input parameter type - addTestWindow(), positionTestWindow() Additionally added test fa