Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v23]

2023-02-05 Thread ScientificWare
On Wed, 25 Jan 2023 22:13:16 GMT, Alexey Ivanov wrote: >> Still waiting a review. > > @scientificware could you put your suggested text into the code change? I > mean incorporate into the PR itself. > > Is it necessary to have the _long_ sample code? > >> @aivanov-jdk Can we dissociate the rel

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v23]

2023-01-25 Thread Alexey Ivanov
On Sat, 21 Jan 2023 18:15:43 GMT, ScientificWare wrote: >> ScientificWare has updated the pull request incrementally with one >> additional commit since the last revision: >> >>Moves jtreg tags to the class declaration >> >> Comment with tags isn't collapsed when viewed in an IDE if it

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v23]

2023-01-21 Thread ScientificWare
On Wed, 28 Sep 2022 17:13:42 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add nam

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v23]

2022-12-14 Thread ScientificWare
On Fri, 30 Sep 2022 17:42:43 GMT, Alexey Ivanov wrote: >>> Shall I edit the subject of the issue to be more specific? “Add named >>> colors from CSS Color Module Level 4”? >> >> Yes, you may. Thanks. >> >>> ... please create a [CSR](https://wiki.openjdk.org/display/csr/Main) >>> request for i

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v23]

2022-11-30 Thread ScientificWare
On Wed, 28 Sep 2022 17:13:42 GMT, ScientificWare wrote: >> This is referenced in Java Bug Database as >> - [JDK-8292276 : Add named colors from CSS Color Module Level >> 4](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276) >> >> This is tracked in JBS as >> - [JDK-8292276 : Add nam

Re: RFR: JDK-8292276 : Add named colors from CSS Color Module Level 4 [v23]

2022-10-05 Thread ScientificWare
On Fri, 30 Sep 2022 17:42:43 GMT, Alexey Ivanov wrote: >>> Shall I edit the subject of the issue to be more specific? “Add named >>> colors from CSS Color Module Level 4”? >> >> Yes, you may. Thanks. >> >>> ... please create a [CSR](https://wiki.openjdk.org/display/csr/Main) >>> request for i