Re: RFR: JDK-8305593: Add @spec tags in java.desktop [v2]

2023-06-05 Thread Phil Race
On Wed, 31 May 2023 20:35:20 GMT, Jonathan Gibbons wrote: >> Please review a docs-only change to add `@spec` tags into `java.desktop` >> public API files > > Jonathan Gibbons has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the

Re: RFR: JDK-8305593: Add @spec tags in java.desktop [v2]

2023-05-31 Thread Jonathan Gibbons
> Please review a docs-only change to add `@spec` tags into `java.desktop` > public API files Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request

Re: RFR: JDK-8305593: Add @spec tags in java.desktop

2023-05-05 Thread Phil Race
On Fri, 5 May 2023 22:19:03 GMT, Jonathan Gibbons wrote: >> src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java >> line 227: >> >>> 225: * @spec https://www.rfc-editor.org/info/rfc1951 >>> 226: * RFC 1951: DEFLATE Compressed Data Format

Re: RFR: JDK-8305593: Add @spec tags in java.desktop

2023-05-05 Thread Jonathan Gibbons
On Fri, 5 May 2023 22:19:38 GMT, Jonathan Gibbons wrote: >> Sorry, but no matter how many times I try, it seems wrong to even for some >> short amount of time to have @spec point to one place and the javadoc point >> to another. They should always be consistent. >> If it is out of scope to

Re: RFR: JDK-8305593: Add @spec tags in java.desktop

2023-05-05 Thread Jonathan Gibbons
On Fri, 7 Apr 2023 01:36:37 GMT, Phil Race wrote: >> Please review a docs-only change to add `@spec` tags into `java.desktop` >> public API files > > src/java.desktop/share/classes/javax/imageio/plugins/tiff/BaselineTIFFTagSet.java > line 227: > >> 225: * @spec

Re: RFR: JDK-8305593: Add @spec tags in java.desktop

2023-05-05 Thread Jonathan Gibbons
On Wed, 3 May 2023 20:51:15 GMT, Phil Race wrote: >> This work is primarily about adding `@spec` tags, in a semi-automated >> fashion, using a custom utility that scans comments in the public API, >> looking for `href`s to "well-known" sites hosting external specifications. >> While "mostly

Re: RFR: JDK-8305593: Add @spec tags in java.desktop

2023-05-03 Thread Phil Race
On Tue, 11 Apr 2023 20:09:40 GMT, Jonathan Gibbons wrote: >> src/java.desktop/share/classes/java/awt/Desktop.java line 591: >> >>> 589: * subprocess >>> 590: * @spec https://www.rfc-editor.org/info/rfc2368 >>> 591: * RFC 2368: The mailto URL scheme >> >> The javadoc above

Re: RFR: JDK-8305593: Add @spec tags in java.desktop

2023-04-11 Thread Jonathan Gibbons
On Fri, 7 Apr 2023 01:35:58 GMT, Phil Race wrote: >> Please review a docs-only change to add `@spec` tags into `java.desktop` >> public API files > > src/java.desktop/share/classes/java/awt/Desktop.java line 591: > >> 589: * subprocess >> 590: * @spec

Re: RFR: JDK-8305593: Add @spec tags in java.desktop

2023-04-11 Thread Jonathan Gibbons
On Wed, 5 Apr 2023 17:29:17 GMT, Jonathan Gibbons wrote: > Please review a docs-only change to add `@spec` tags into `java.desktop` > public API files On the use of `rfc-editor.org`, this site came up during the original all-in-one version of this work in PR #11073. See, for example, these

Re: RFR: JDK-8305593: Add @spec tags in java.desktop

2023-04-06 Thread Phil Race
On Wed, 5 Apr 2023 17:29:17 GMT, Jonathan Gibbons wrote: > Please review a docs-only change to add `@spec` tags into `java.desktop` > public API files src/java.desktop/share/classes/java/awt/Desktop.java line 591: > 589: * subprocess > 590: * @spec

RFR: JDK-8305593: Add @spec tags in java.desktop

2023-04-05 Thread Jonathan Gibbons
Please review a docs-only change to add `@spec` tags into `java.desktop` public API files - Commit messages: - JDK-8305593: Add @spec tags in java.desktop Changes: https://git.openjdk.org/jdk/pull/13360/files Webrev: https://webrevs.openjdk.org/?repo=jdk=13360=00 Issue: