On Fri, 28 Jul 2023 08:02:22 GMT, Matthias Baesken wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp line 207:
>>
>>> 205: ::DeleteDC(hdcScreen);
>>> 206: throw std::bad_alloc();
>>> 207: }
>>
>> I wonder if we can catch `std::bad_alloc` to release the r
On Thu, 27 Jul 2023 19:57:01 GMT, Alexey Ivanov wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust checks and calculation of numPixels
>
> src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp line 2
On Wed, 26 Jul 2023 11:59:06 GMT, Matthias Baesken wrote:
>> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
>> we release some resources at the end of the function by calling
>> DeleteObject/DeleteDC. This is recommended by the MS API docs.
>> However this should b
On Wed, 26 Jul 2023 11:59:06 GMT, Matthias Baesken wrote:
>> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
>> we release some resources at the end of the function by calling
>> DeleteObject/DeleteDC. This is recommended by the MS API docs.
>> However this should b
> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
> we release some resources at the end of the function by calling
> DeleteObject/DeleteDC. This is recommended by the MS API docs.
> However this should be done as well in some early leaving with throw that can
> occu
On Wed, 26 Jul 2023 10:43:20 GMT, Matthias Baesken wrote:
> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
> we release some resources at the end of the function by calling
> DeleteObject/DeleteDC. This is recommended by the MS API docs.
> However this should be do
On Wed, 26 Jul 2023 10:43:20 GMT, Matthias Baesken wrote:
> In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels
> we release some resources at the end of the function by calling
> DeleteObject/DeleteDC. This is recommended by the MS API docs.
> However this should be do
In src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels we
release some resources at the end of the function by calling
DeleteObject/DeleteDC. This is recommended by the MS API docs.
However this should be done as well in some early leaving with throw that can
occur in this
