Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-18 Thread Phil Race
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts I'm not seeing that github shows I approved this but I certainly intended to. So hitting approve now. Oh

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-13 Thread Laurent Bourgès
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts @johanvos could you review this fix? - PR Comment: https://git.openjdk.org/jdk/pull/16002#i

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-12 Thread Laurent Bourgès
On Tue, 10 Oct 2023 21:24:47 GMT, Phil Race wrote: >> For stroked shapes (no Renderer use), the min-join-error check is disabled. >> Added new jtreg test to verify join using pixel counts > > Let me submit a test task to verify. Thanks @prrace for approval. @kevinrushforth could you review this

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-10 Thread Phil Race
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts Tests all passed. - Marked as reviewed by prr (Reviewer). PR Review: https://git.openjdk.o

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-10 Thread Phil Race
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts Let me submit a test task to verify. - PR Comment: https://git.openjdk.org/jdk/pull/16002#i

Re: RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-10 Thread Laurent Bourgès
On Sun, 1 Oct 2023 20:33:54 GMT, Laurent Bourgès wrote: > For stroked shapes (no Renderer use), the min-join-error check is disabled. > Added new jtreg test to verify join using pixel counts @prrace could you review this simple fix for jdk22, thatcan be backported to 21 next ? - P

RFR: JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes

2023-10-01 Thread Laurent Bourgès
For stroked shapes (no Renderer use), the min-join-error check is disabled. Added new jtreg test to verify join using pixel counts - Commit messages: - fixed line endings - JDK-8316741: fixed BasicStroke.createStrokedShape miter-limits failing on small shapes by disabling the min-j