On Fri, 15 Mar 2024 10:53:14 GMT, Tejesh R wrote:
>> @TejeshR13 What do you mean? What kind of line spacing would be nice here?
>
> Line spacing between JTREG tag and class.
It's not needed… but most people add it. And we cannot agree on *a common
style*, unfortunately.
These jtreg tags are ak
On Fri, 15 Mar 2024 10:50:18 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:
>>
>>> 43: * @build PassFailJFrame
>>> 44: * @run main/manual/othervm -Djava.security.manager=allow
>>> SecurityDialogTest
>>> 45: */
>>
>> Line spacing here would b
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyanga
On Fri, 15 Mar 2024 03:33:50 GMT, Tejesh R wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Added summary
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:
>
>> 43: * @build Pas
On Fri, 15 Mar 2024 06:45:57 GMT, Tejesh R wrote:
>> Most of the test with PassFailJFrame instruction stored as string inside
>> class, what additional benefit will get keeping it inside Main ?
>
> When it can become local variable then why to keep it in class? Not like
> significant benefit ma
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyanga
On Fri, 15 Mar 2024 08:39:51 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame with information panel, earlier
>> this was informed through terminal.
>> Please review and let me know your suggestions if any.
>
> Renjith Kannath Pariyanga
On Fri, 15 Mar 2024 03:33:24 GMT, Tejesh R wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Added summary
>
> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 43:
>
>> 41: * @key print
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame with information panel, earlier
> this was informed through terminal.
> Please review and let me know your suggestions if any.
Renjith Kannath Pariyangad has updated the pull request incrementally with one
additional commit since
