Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-21 Thread Alexey Ivanov
On Thu, 21 Mar 2024 01:16:03 GMT, Harshitha Onkar wrote: >> I think we should update the instructions. >> >> A high resolution mouse produces events like this: >> >> java.awt.event.MouseWheelEvent[MOUSE_WHEEL,(164,90),absolute(1135,365),button=0,clickCount=0,scrollType=WHEEL_UNIT_SCROLL,scrollA

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-20 Thread Harshitha Onkar
On Wed, 20 Mar 2024 16:57:24 GMT, Alexey Ivanov wrote: >> @aivanov-jdk Semi-automated the test, it now passes when 5 or more >> MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 >> is recorded. Updated the instructions accordingly. > > I think we should update the inst

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-20 Thread Harshitha Onkar
On Wed, 20 Mar 2024 16:57:24 GMT, Alexey Ivanov wrote: >> @aivanov-jdk Semi-automated the test, it now passes when 5 or more >> MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 >> is recorded. Updated the instructions accordingly. > > I think we should update the inst

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-20 Thread Harshitha Onkar
On Wed, 20 Mar 2024 16:57:24 GMT, Alexey Ivanov wrote: >> @aivanov-jdk Semi-automated the test, it now passes when 5 or more >> MouseWheelEvent of type: scrollType=WHEEL_UNIT_SCROLL & wheelRotation != 0 >> is recorded. Updated the instructions accordingly. > > I think we should update the inst

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-20 Thread Alexey Ivanov
On Tue, 19 Mar 2024 20:39:07 GMT, Harshitha Onkar wrote: >> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49: >> >>> 47: below the instruction window. >>> 48: Please make sure that some of the messages have non-zero >>> 'wheelRotation' value, >>> 49:

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-19 Thread Harshitha Onkar
On Tue, 19 Mar 2024 18:01:01 GMT, Alexey Ivanov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor changes > > test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 32: > >> 30: * @test >> 31: *

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-19 Thread Harshitha Onkar
On Tue, 19 Mar 2024 17:56:25 GMT, Alexey Ivanov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor changes > > test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 49: > >> 47: below

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-19 Thread Alexey Ivanov
On Mon, 18 Mar 2024 17:27:43 GMT, Harshitha Onkar wrote: >> This test is converted to main using PassFailJFrame. It verifies wheel >> rotation value for high-res mouse on windows. >> >> The test requires the updated PassFailJFrame's logArea() feature added in >> this PR https://github.com/open

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-19 Thread Alexey Ivanov
On Thu, 14 Mar 2024 19:54:19 GMT, Harshitha Onkar wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor changes > > test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 47: > >> 45: This

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-19 Thread Abhishek Kumar
On Mon, 18 Mar 2024 17:27:43 GMT, Harshitha Onkar wrote: >> This test is converted to main using PassFailJFrame. It verifies wheel >> rotation value for high-res mouse on windows. >> >> The test requires the updated PassFailJFrame's logArea() feature added in >> this PR https://github.com/open

Re: RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v4]

2024-03-18 Thread Harshitha Onkar
> This test is converted to main using PassFailJFrame. It verifies wheel > rotation value for high-res mouse on windows. > > The test requires the updated PassFailJFrame's logArea() feature added in > this PR https://github.com/openjdk/jdk/pull/18319 Harshitha Onkar has updated the pull request