Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v6]

2024-03-20 Thread Harshitha Onkar
> Following test is converted to main using PassFailJFrame. Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: instructions updated - Changes: - all: https://git.openjdk.org/jdk/pull/18315/files - new: https://git.op

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v5]

2024-03-20 Thread Harshitha Onkar
> Following test is converted to main using PassFailJFrame. Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: summary updated - Changes: - all: https://git.openjdk.org/jdk/pull/18315/files - new: https://git.openjdk

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v3]

2024-03-20 Thread Alexey Ivanov
On Wed, 20 Mar 2024 17:13:34 GMT, Harshitha Onkar wrote: >> Following test is converted to main using PassFailJFrame. > > Harshitha Onkar has updated the pull request incrementally with two > additional commits since the last revision: > > - minor fix > - instruction line-lengths test/jdk/ja

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v2]

2024-03-20 Thread Harshitha Onkar
On Wed, 20 Mar 2024 17:03:41 GMT, Alexey Ivanov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> instructions updated > > test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 46: > >> 44: >> 45:

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v4]

2024-03-20 Thread Alexey Ivanov
On Wed, 20 Mar 2024 17:29:58 GMT, Harshitha Onkar wrote: >> Following test is converted to main using PassFailJFrame. > > Harshitha Onkar has updated the pull request incrementally with three > additional commits since the last revision: > > - frame.setSize() used > - review update > - revie

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v4]

2024-03-20 Thread Harshitha Onkar
> Following test is converted to main using PassFailJFrame. Harshitha Onkar has updated the pull request incrementally with three additional commits since the last revision: - frame.setSize() used - review update - review update - Changes: - all: https://git.openjdk.org/jdk/pu

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v3]

2024-03-20 Thread Damon Nguyen
On Wed, 20 Mar 2024 17:10:54 GMT, Harshitha Onkar wrote: >> Following test is converted to main using PassFailJFrame. > > Harshitha Onkar has updated the pull request incrementally with two > additional commits since the last revision: > > - minor fix > - instruction line-lengths Makes sense

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v3]

2024-03-20 Thread Harshitha Onkar
> Following test is converted to main using PassFailJFrame. Harshitha Onkar has updated the pull request incrementally with two additional commits since the last revision: - minor fix - instruction line-lengths - Changes: - all: https://git.openjdk.org/jdk/pull/18315/files -

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v2]

2024-03-20 Thread Alexey Ivanov
On Tue, 19 Mar 2024 21:07:44 GMT, Harshitha Onkar wrote: >> Following test is converted to main using PassFailJFrame. > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > instructions updated Changes requested by aivanov (Re

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v2]

2024-03-20 Thread Harshitha Onkar
On Wed, 20 Mar 2024 16:31:32 GMT, Damon Nguyen wrote: > Do we need to add any instructions regarding the blue "empty" boxes that > appear? Since we are checking the second case i.e CTRL + Mouse Drag, the empty boxes don't appear hence I skipped it. - PR Comment: https://git.openj

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v2]

2024-03-20 Thread Damon Nguyen
On Tue, 19 Mar 2024 21:07:44 GMT, Harshitha Onkar wrote: >> Following test is converted to main using PassFailJFrame. > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > instructions updated Do we need to add any instructio

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v2]

2024-03-19 Thread Harshitha Onkar
> Following test is converted to main using PassFailJFrame. Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: instructions updated - Changes: - all: https://git.openjdk.org/jdk/pull/18315/files - new: https://git.op

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v2]

2024-03-19 Thread Harshitha Onkar
On Tue, 19 Mar 2024 18:11:57 GMT, Alexey Ivanov wrote: >> Case 1: A circle + anchor is seen (without a green window) when just Mouse >> is used to perform DnD. >> Case 2: A green window below the anchor + circle is seen when CTRL + Mouse >> is used to perform DnD. (I believe the green window,

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main

2024-03-19 Thread Alexey Ivanov
On Tue, 19 Mar 2024 17:37:26 GMT, Harshitha Onkar wrote: >> Win32 is not that old… Java still uses these APIs in 64-bit world. >> >> I haven't run the test myself (yet). I suggest replacing _Win32_ with >> _Windows_. Is image under cursor visible when you drag'n'drop on Windows? It >> should b

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main

2024-03-19 Thread Harshitha Onkar
On Tue, 19 Mar 2024 17:18:44 GMT, Alexey Ivanov wrote: >> test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 56: >> >>> 54: In WIN32 systems the image under cursor would be >>> visible ONLY over >>> 55: the drop targets with activated extended OL

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main

2024-03-19 Thread Alexey Ivanov
On Thu, 14 Mar 2024 22:44:24 GMT, Harshitha Onkar wrote: >> Following test is converted to main using PassFailJFrame. > > test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 56: > >> 54: In WIN32 systems the image under cursor would be visible >> ONLY over >> 55:

Re: RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main

2024-03-14 Thread Harshitha Onkar
On Thu, 14 Mar 2024 22:41:20 GMT, Harshitha Onkar wrote: > Following test is converted to main using PassFailJFrame. test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 56: > 54: In WIN32 systems the image under cursor would be visible > ONLY over > 55:

RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main

2024-03-14 Thread Harshitha Onkar
Following test is converted to main using PassFailJFrame. - Commit messages: - EOF newline added - Instructions updated - applet to main Changes: https://git.openjdk.org/jdk/pull/18315/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18315&range=00 Issue: https://bugs.op