Re: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

2024-04-02 Thread Harshitha Onkar
On Tue, 2 Apr 2024 17:06:47 GMT, Alexey Ivanov wrote: >> It is better to re-throw it as RuntimeException. Updated. > >> It is better to re-throw it as RuntimeException. Updated. > > Not really… > > If saving the image fails, we want to preserve *the original error message* > which wasn't even

Re: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

2024-04-02 Thread Alexey Ivanov
On Fri, 29 Mar 2024 17:25:38 GMT, Harshitha Onkar wrote: > It is better to re-throw it as RuntimeException. Updated. Not really… If saving the image fails, we want to preserve *the original error message* which wasn't even thrown by this time. So printing stack trace in this particular is qui

Re: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

2024-03-29 Thread Harshitha Onkar
On Fri, 29 Mar 2024 16:41:13 GMT, Damon Nguyen wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> spacing > > test/jdk/java/awt/Frame/MaximizeUndecoratedTest.java line 127: > >> 125: } catch (IOException e

Re: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

2024-03-29 Thread Damon Nguyen
On Wed, 27 Mar 2024 18:20:59 GMT, Harshitha Onkar wrote: >> Following tests are converted to main and open-sourced: >> >> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using >> PassFailJFrame. >> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated >> - /java/awt/F

Re: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

2024-03-28 Thread Abhishek Kumar
On Wed, 27 Mar 2024 18:20:59 GMT, Harshitha Onkar wrote: >> Following tests are converted to main and open-sourced: >> >> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using >> PassFailJFrame. >> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated >> - /java/awt/F

Re: RFR: JDK-8328753 : Open source few Undecorated Frame tests [v2]

2024-03-27 Thread Harshitha Onkar
> Following tests are converted to main and open-sourced: > > - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using > PassFailJFrame. > - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated > - /java/awt/Frame/MinimizeUndecoratedTest.java - Automated Harshitha Onkar ha