On Thu, 26 Jan 2023 09:28:48 GMT, Andrey Turbanov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
> Andrey Turbanov has updated the pull request incremen
On Thu, 26 Jan 2023 09:28:48 GMT, Andrey Turbanov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
> Andrey Turbanov has updated the pull request incremen
On Thu, 26 Jan 2023 09:24:25 GMT, Andrey Turbanov wrote:
>> That is not about the default values in the array but about missing
>> initialization of `bandOffsets`, which we will skip intentionally. So it
>> won't raise the question later why we initiated the Indices and not offsets.
>
> I've ad
On Thu, 26 Jan 2023 09:28:48 GMT, Andrey Turbanov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
> Andrey Turbanov has updated the pull request incremen
On Tue, 24 Jan 2023 22:50:31 GMT, Sergey Bylokhov wrote:
>> Yeah, please, no commented-out code. I'd be fine with the code as it was, I
>> don't think it needs much clarification. If @mrserb insists on a comment
>> then I agree that a comment on the array declaration should be sufficient.
>
> T
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
830
On Tue, 24 Jan 2023 19:39:38 GMT, Attila Szegedi wrote:
>> src/java.desktop/share/classes/java/awt/image/Raster.java line 372:
>>
>>> 370: for (int i = 0; i < bands; i++) {
>>> 371: bankIndices[i] = i;
>>> 372: bandOffsets[i] = 0;
>>
>> I suggest to comment this
On Tue, 24 Jan 2023 16:25:46 GMT, Sergey Bylokhov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
> src/java.desktop/share/classes/java/awt/image/Raster.
On Tue, 24 Jan 2023 16:25:46 GMT, Sergey Bylokhov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
> src/java.desktop/share/classes/java/awt/image/Raster.
On Tue, 24 Jan 2023 16:22:43 GMT, Sergey Bylokhov wrote:
>> No need to fill elements of array with default values if it was just
>> created. Java guarantees that all elements of numeric array have default
>> values after allocations - 0.
>
> src/java.desktop/share/classes/java/awt/image/Compone
On Mon, 23 Jan 2023 17:20:41 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
src/java.desktop/share/classes/java/awt/image/ComponentColo
On Mon, 23 Jan 2023 17:20:41 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
Marked as reviewed by attila (Reviewer).
-
PR
On Mon, 23 Jan 2023 17:20:41 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
Marked as reviewed by swi...@github.com (no known OpenJDK u
13 matches
Mail list logo
