On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race wrote:
> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of
> the implementation is in a delegate
> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>
> Then a disposer can be used to free the audio resources held by the del
On Fri, 5 Sep 2025 04:39:33 GMT, Phil Race wrote:
>> Ok, so when we create a new file and move the contents from old file as part
>> of refactoring we retain the copyright year too. Got it.
>
> So .. @TejeshR13 did you mean to approve this ?
Yes, just missed it.
-
PR Review Commen
On Wed, 3 Sep 2025 04:37:21 GMT, Tejesh R wrote:
>> No it was not an error. This is content moved from another file. Files are
>> an artificial division. It is the same content.
>
> Ok, so when we create a new file and move the contents from old file as part
> of refactoring we retain the copyr
On Tue, 2 Sep 2025 08:35:37 GMT, Tejesh R wrote:
>> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of
>> the implementation is in a delegate
>> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>>
>> Then a disposer can be used to free the audio resources held by the
On Tue, 2 Sep 2025 17:22:33 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/com/sun/media/sound/JavaSoundAudioClipDelegate.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 1999, 2025, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Suggestion:
>>
>> * Copyright (c)
On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race wrote:
> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of
> the implementation is in a delegate
> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>
> Then a disposer can be used to free the audio resources held by the del
On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race wrote:
> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of
> the implementation is in a delegate
> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>
> Then a disposer can be used to free the audio resources held by the del
On Wed, 20 Aug 2025 20:58:08 GMT, Phil Race wrote:
> Memory leaks ? Where and how ? By current implementation, you mean before and
> after the PR ?
I meant the reason why do you need the "new" delegate implementation is the
reference to the object back from the listener lists, should not that
On Fri, 15 Aug 2025 01:32:06 GMT, Sergey Bylokhov wrote:
> How about modifying the listeners list implementations to store listeners
> using weak references instead(not sure it will be better that the current
> patch)? it seems current implementation can cause memory leaks?
Memory leaks ? Whe
On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race wrote:
> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of
> the implementation is in a delegate
> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>
> Then a disposer can be used to free the audio resources held by the del
On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race wrote:
> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of
> the implementation is in a delegate
> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>
> Then a disposer can be used to free the audio resources held by the del
11 matches
Mail list logo
