Re: Clojure Futures Docs and Functionality

2010-06-27 Thread Ryan Senior
Sounds good to me. The first version of that function I wrote without returning nil, but just bubbling up the exception. I changed it because I couldn't think of another area of the Clojure core that threw an exception like that. Looking through some of the agents code, I think there are some si

Re: Clojure Futures Docs and Functionality

2010-06-25 Thread Meikel Brandmeyer
Hi, Am 25.06.2010 um 20:48 schrieb Daniel Werner: > On 25 June 2010 05:27, Ryan Senior wrote: >> (future-await fut2 2 :minutes) ; => "done" > > What do others think? I agree – in particular for point 2. For point 1: I think "2 :minutes" is not very clojure-like. It sound more like Ruby: 2.mi

Re: Clojure Futures Docs and Functionality

2010-06-25 Thread Daniel Werner
On 25 June 2010 05:27, Ryan Senior wrote: > (future-await fut2 2 :minutes) ; => "done" Your implementation points into the right direction (again, IMHO). I'd like to offer two suggestions: 1. Leave out the three-arg version of future-await. The time unit conversion seems somewhat superfluous, wi

Re: Clojure Futures Docs and Functionality

2010-06-25 Thread Ryan Senior
Hi Daniel, On Wed, Jun 23, 2010 at 1:15 PM, Daniel Werner < daniel.d.wer...@googlemail.com> wrote: > > Judging from previous discussions on this list, I get the feeling that > relying too much on the Java implementation details underlying the > public Clojure APIs is discouraged. This certainly m

Re: Clojure Futures Docs and Functionality

2010-06-23 Thread Daniel Werner
Hello Ryan, On Jun 21, 7:34 am, Ryan Senior wrote: > 1 - I think a good improvement would be updating the docs for the future > related functions to indicate what kind of objects are passed in and > returned.  Users would then not have to go through the source to see what's > being returned.  Thi

Clojure Futures Docs and Functionality

2010-06-21 Thread Ryan Senior
I figured before I added a ticket, I'd post here. I was using the functions for Futures in Clojure and found for all of the future functions (like future, future-done?, future-cancel etc) it was nicely abstracted and there was no need to know exactly what kind of object was passed into or returned