clojure.java.jdbc - jdbc metadata support?

2013-07-24 Thread Mark
I'm pretty interested in getting at least a subset of jdbc metadata support into clojure.java.jdbc. I've forked the repo and will start crafting the API if there is no else has a similar effort going on. I'm mostly interested in result set metadata. My first thought is to extend the query

Re: clojure.java.jdbc - jdbc metadata support?

2013-07-24 Thread Sean Corfield
That's great and would be a worthwhile addition but don't forget to get your CA signed and sent in, otherwise your contributions cannot be accepted. See http://clojure.org/contributing for more details. Sean On Wed, Jul 24, 2013 at 4:03 PM, Mark markaddle...@gmail.com wrote: I'm pretty

Re: clojure.java.jdbc - jdbc metadata support?

2013-07-24 Thread Mark
re Signing the CA: Definitely. I'll get that sent in ASAP. In the meantime, can you take a look at https://github.com/markaddleman/java.jdbc/commit/27a246dee7c0a06c888d827e0699bc6966725b58 ? I'm still a Clojure noob so I'm not sure if the approach is correct. All feedback welcome. On

Re: clojure.java.jdbc - jdbc metadata support?

2013-07-24 Thread Sean Corfield
I'll reply off-list. There's a lot of stuff in that code to digest. I'll say straight off that I think a regex replace would make the clojurize-java-accessor code much simpler. I suspect there are reflection warnings in several places that will need to be addressed and definitely some refactoring

Re: clojure.java.jdbc - jdbc metadata support?

2013-07-24 Thread Mark
Thanks, Sean. Not sure through what channel you want to communicate. I have pushed some changes that significantly clean up the code: - Use reg ex as you suggest - Eliminated reflection warnings - Learned me a zipmap for great success On Wednesday, July 24, 2013 7:09:27 PM

Re: clojure.java.jdbc - jdbc metadata support?

2013-07-24 Thread Sean Corfield
Cool. I'll take a look at that and email you (hopefully tomorrow, depending on workload!). Sean On Wed, Jul 24, 2013 at 10:15 PM, Mark markaddle...@gmail.com wrote: Thanks, Sean. Not sure through what channel you want to communicate. I have pushed some changes that significantly clean up the