proposal for shell-out: option to return articulated out, err, & exit code

2009-01-28 Thread Perry Trolard
Hi Users of Shell-out, I'd sometimes like to have the exit status from system commands, so I patched clojure.contrib.shell-out to accept a :verbose option which, when turned on, returns a map with :exit, :out, & :err (where :exit's value is the exit code int, & :out & :err name either byte arrays

Re: proposal for shell-out: option to return articulated out, err, & exit code

2009-01-28 Thread Chouser
On Wed, Jan 28, 2009 at 4:37 PM, Perry Trolard wrote: > > I'd sometimes like to have the exit status from system commands, so I > patched clojure.contrib.shell-out to accept a :verbose option which, > when turned on, returns a map with :exit, :out, & :err (where :exit's > value is the exit code i

Re: proposal for shell-out: option to return articulated out, err, & exit code

2009-01-28 Thread Chouser
On Wed, Jan 28, 2009 at 4:43 PM, Chouser wrote: > > Sounds good. Is ':verbose' the base name for this option? Sorry for the typo. "best name" --Chouser --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Clojure" g

Re: proposal for shell-out: option to return articulated out, err, & exit code

2009-01-28 Thread Perry Trolard
> Sounds good.  Is ':verbose' the best name for this option?  What about > ':return-map'?  I'm okay with ':verbose' if we can't reach consensus > on something else. I agree that :verbose isn't right -- :return-map's not bad at all. Perry --~--~-~--~~~---~--~~ You

Re: proposal for shell-out: option to return articulated out, err, & exit code

2009-01-29 Thread Perry Trolard
Patch submitted to the issue tracker: http://code.google.com/p/clojure-contrib/issues/detail?id=23 Thanks, Perry --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, send email t

Re: proposal for shell-out: option to return articulated out, err, & exit code

2009-02-06 Thread Perry Trolard
I've updated this patch, eliminating the performance hit I introduced for concatenation of stdout & stderr when they're byte arrays (turns out it was significant). Let me know if there's anything else I can do. Perry http://code.google.com/p/clojure-contrib/issues/detail?id=23 --~--~-~-