[ClojureScript] Re: Problems with :advanced compilation

2014-07-29 Thread Daniel Kersten
I'm assuming that I need to determine what the RN refers to when not minified and then write a proper extern file for it.. On 30 July 2014 00:15, Daniel Kersten wrote: > Hi, > > I have a large-ish ClojureScript/Om application and I'm unable to run it > when compiled with :optimization :advanced

Re: [ClojureScript] Re: Problems with :advanced compilation

2014-07-29 Thread David Nolen
Using JS libs as their own externs is not guaranteed to work. You just need to supply extern files for all calls that involve JS code that Closure will not see. David On Tue, Jul 29, 2014 at 7:20 PM, Daniel Kersten wrote: > I'm assuming that I need to determine what the RN refers to when not > m

Re: [ClojureScript] Re: Problems with :advanced compilation

2014-07-30 Thread Daniel Kersten
Thanks David, that's what I thought might be the case. Oddly enough as far as I can tell, RN is a function from an om-tools mixin (and therefore cljs code). I'll see if I can replicate in a test project. On 30 Jul 2014 00:53, "David Nolen" wrote: > Using JS libs as their own externs is not guara

Re: [ClojureScript] Re: Problems with :advanced compilation

2014-07-30 Thread Logan Linn
On Wednesday, July 30, 2014 1:45:43 AM UTC-7, Daniel Kersten wrote: > Thanks David, that's what I thought might be the case. > > Oddly enough as far as I can tell, RN is a function from an om-tools mixin > (and therefore cljs code). I'll see if I can replicate in a test project. > > On 30 Jul

Re: [ClojureScript] Re: Problems with :advanced compilation

2014-07-30 Thread Daniel Kersten
I'm not sure if its caused by om-tools or if its just chance that it happens to be a call to om-tools. I haven't been able to reproduce it in a minimal test case yet. I'll try again tomorrow. If it turns out to be om-tools, I'll open an issue, but its also likely that its a problem in my own code.

Re: [ClojureScript] Re: Problems with :advanced compilation

2014-07-30 Thread Daniel Kersten
I set :pseudo-names true and it confirms that its the call to the mixin function that causes this, but I have not yet managed to reproduce it in a minimal project. On 30 July 2014 23:53, Daniel Kersten wrote: > I'm not sure if its caused by om-tools or if its just chance that it > happens to be

Re: [ClojureScript] Re: Problems with :advanced compilation

2014-07-30 Thread Logan Linn
On Wednesday, July 30, 2014 4:07:06 PM UTC-7, Daniel Kersten wrote: > I set :pseudo-names true and it confirms that its the call to the mixin > function that causes this, but I have not yet managed to reproduce it in a > minimal project. > > > > > On 30 July 2014 23:53, Daniel Kersten wrote:

Re: [ClojureScript] Re: Problems with :advanced compilation

2014-07-31 Thread Daniel Kersten
Thanks for looking into this! I will follow the issue. Feel free to ask if you need me to do anything to help resolve it. In the meantime I'll use the workaround. On 31 Jul 2014 01:12, "Logan Linn" wrote: > On Wednesday, July 30, 2014 4:07:06 PM UTC-7, Daniel Kersten wrote: > > I set :pseudo-nam

Re: [ClojureScript] Re: Problems with :advanced compilation

2014-07-31 Thread Daniel Kersten
Ps: oddly enough I wrote a minimal test program with a mixin with a non-lifecycle method that did not break. I will try again later and see if I made a mistake. On 31 Jul 2014 08:55, "Daniel Kersten" wrote: > Thanks for looking into this! > > I will follow the issue. Feel free to ask if you need