Re: [Cloud-init-dev] [Merge] lp:~timbyr/cloud-init/cloud-init into lp:cloud-init

2015-01-23 Thread Shraddha Pandhe
Review: Needs Fixing Please add a unittest Diff comments: > === modified file 'cloudinit/netinfo.py' > --- cloudinit/netinfo.py 2014-12-01 05:35:38 + > +++ cloudinit/netinfo.py 2015-01-23 16:58:59 + > @@ -136,7 +136,7 @@ > routes['ipv4'].append(entry) > > try: >

Re: [Cloud-init-dev] [Merge] lp:~barry/cloud-init/py2-3 into lp:cloud-init

2015-01-23 Thread Joshua Harlow
Looks pretty good to me (seems like there is a new conflict against trunk/head); thanks for beating the tests into shape. -- https://code.launchpad.net/~barry/cloud-init/py2-3/+merge/247239 Your team cloud init development team is requested to review the proposed merge of lp:~barry/cloud-init/py

[Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/lp1375252 into lp:cloud-init

2015-01-23 Thread Ben Howard
Ben Howard has proposed merging lp:~utlemming/cloud-init/lp1375252 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1375252 in walinuxagent (Ubuntu): "Hostname change is not preserved across reboot on Azure Ubuntu VMs" https://bugs.laun

[Cloud-init-dev] [Merge] lp:~timbyr/cloud-init/cloud-init into lp:cloud-init

2015-01-23 Thread Keith Byrne
Keith Byrne has proposed merging lp:~timbyr/cloud-init/cloud-init into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1401965 in cloud-init: "route_info() in netinfo.py will never return IPV6 route information" https://bugs.launchpad.net/c

[Cloud-init-dev] [Merge] lp:~utlemming/cloud-init/lp1375252 into lp:cloud-init

2015-01-23 Thread Ben Howard
Ben Howard has proposed merging lp:~utlemming/cloud-init/lp1375252 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1375252 in walinuxagent (Ubuntu): "Hostname change is not preserved across reboot on Azure Ubuntu VMs" https://bugs.laun