[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.smartos-fabric into lp:cloud-init

2016-07-14 Thread Scott Moser
The proposal to merge lp:~smoser/cloud-init/trunk.smartos-fabric into lp:cloud-init has been updated. Commit Message changed to: SmartOS: more improvements for network configuration This improves smart os network configuration - fix the SocketClient which was previously completely broken. - a

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.smartos-fabric into lp:cloud-init

2016-07-14 Thread Scott Moser
Scott Moser has proposed merging lp:~smoser/cloud-init/trunk.smartos-fabric into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/trunk.smartos-fabric/+merge/300115 -- Your team cloud init devel

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-07-14 Thread noreply
The proposal to merge lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smoser/cloud-init/trunk.net-improve-lo-dns/+merge/298035 -- Your team cloud init development team is re

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-07-14 Thread Scott Moser
i added a test of the _write_network fallback in the fix for 1602373 (revno 1255 on trunk). and pulled that in here. going to merge this in now. -- https://code.launchpad.net/~smoser/cloud-init/trunk.net-improve-lo-dns/+merge/298035 Your team cloud init development team is requested to review th

[Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.lp1602373 into lp:cloud-init

2016-07-14 Thread noreply
The proposal to merge lp:~smoser/cloud-init/trunk.lp1602373 into lp:cloud-init has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smoser/cloud-init/trunk.lp1602373/+merge/300021 -- Your team cloud init development team is requested to review

[Cloud-init-dev] [Merge] lp:~sgolovatiuk/cloud-init/fix_mcollective into lp:cloud-init

2016-07-14 Thread noreply
The proposal to merge lp:~sgolovatiuk/cloud-init/fix_mcollective into lp:cloud-init has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~sgolovatiuk/cloud-init/fix_mcollective/+merge/298759 -- Your team cloud init development team is requested

Re: [Cloud-init-dev] [Merge] lp:~bbaude/cloud-init/azure_dhcp into lp:cloud-init

2016-07-14 Thread Scott Moser
update the commit message to address the different behavior (we now write json for 1). is it possible to put cloud-init-dhclient-hook outside of /usr/bin ? we could put it in /usr/lib/cloud-init and hten just name it 'dhclient-hook' . i say this because its not really intende to be used as an ex

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-07-14 Thread Ryan Harper
Looks good. Could we add unittests for distro using apply_network, including one without a _write_network so we can test that fallback logic? Diff comments: > > === modified file 'tests/unittests/test_net.py' > --- tests/unittests/test_net.py 2016-06-15 23:11:24 + > +++ tests/unitte

Re: [Cloud-init-dev] [Merge] lp:~smoser/cloud-init/trunk.net-improve-lo-dns into lp:cloud-init

2016-07-14 Thread Ryan Harper
> - use arrays for each 'section' rather than content += . This allows better > separation of the sections and also will perform better as long strings > with += are slow. +1 for better separation. I don't think there is significant difference: For an 100-line eni (that's rather high for ty

[Cloud-init-dev] [Merge] lp:~swem/cloud-init/cloud-init.target.typo into lp:cloud-init

2016-07-14 Thread Chen-Han Hsiao (Stanley)
Chen-Han Hsiao (Stanley) has proposed merging lp:~swem/cloud-init/cloud-init.target.typo into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~swem/cloud-init/cloud-init.target.typo/+merge/300048 Fix typo in clou