Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-ci into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:ef13ce3def0728ed8c95c675c4552c1258f4d5d0 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/1 SUCCESS:

[Cloud-init-dev] [Merge] ~powersj/cloud-init:test-ci into cloud-init:master

Joshua Powers has proposed merging ~powersj/cloud-init:test-ci into cloud-init:master. Commit message: doc: test Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/325777 DO NOT MERGE This is

[Cloud-init-dev] [Merge] ~powersj/cloud-init:test-ci into cloud-init:master

The proposal to merge ~powersj/cloud-init:test-ci into cloud-init:master has been updated. Description changed to: DO NOT MERGE This is a test for the new CI system only! For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/325777 -- Your team

[Cloud-init-dev] [Merge] ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into cloud-init:master

The proposal to merge ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713 -- Your team cloud-init commiters is requested

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/freebsd-test-failure into cloud-init:master

Diff comments: > diff --git a/cloudinit/sources/DataSourceAzure.py > b/cloudinit/sources/DataSourceAzure.py > index ebb53d0..e5514ad 100644 > --- a/cloudinit/sources/DataSourceAzure.py > +++ b/cloudinit/sources/DataSourceAzure.py > @@ -803,18 +803,22 @@ def encrypt_pass(password,

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/freebsd-test-failure into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/freebsd-test-failure into cloud-init:master has been updated. Commit Message changed to: FreeBSD: fix test failure The previous commit caused test failure. This separates out _check_freebsd_cdrom and mocks it in a test rather than patching open.

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/freebsd-test-failure into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/freebsd-test-failure into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325771 -- Your team cloud-init commiters

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760 -- Your team cloud-init commiters is requested to

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master

+1 on that suggestion -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master. ___

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master

actually, on further thought, lets leve suse out right now. there is a 'sles' distro (cloudinit/distros/sles.py) but per https://github.com/hpcugent/easybuild/wiki/OS_flavor_name_version we would see 'suse' as the dist. not sure what the right change is. i didn't *change* any behavior here i

[Cloud-init-dev] [Merge] ~b1sandmann/cloud-init:fix-debian-template into cloud-init:master

The proposal to merge ~b1sandmann/cloud-init:fix-debian-template into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~b1sandmann/cloud-init/+git/cloud-init/+merge/325478 -- Your team cloud-init commiters is requested to

[Cloud-init-dev] [Merge] ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into cloud-init:master

The proposal to merge ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713 -- Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:c6af5b9a1648c208c82b3a2704668391abadd8ab https://jenkins.ubuntu.com/server/job/cloud-init-ci/539/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/539 SUCCESS:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master has been updated. Commit Message changed to: freebsd: Make freebsd a variant, fix unittests and tools/build-on-freebsd. - Simplify the logic of 'variant' in util.system_info much of the data from

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:2151902fa7a5cba7e420a14f51c851ee06d83d30 https://jenkins.ubuntu.com/server/job/cloud-init-ci/538/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/538/console

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master

this replaces some of the changes from https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718 -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760 Your team cloud-init commiters is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] ~redriver/cloud-init:fail_to_install_on_frbsd into cloud-init:master

i've put up https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760 that covers most of these. -- https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325718 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/freebsd-variant into cloud-init:master. Commit message: fixes for freebsd Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760 --

Re: [Cloud-init-dev] [Merge] ~jcastets/cloud-init:scaleway-datasource into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:a0748674f74e97e70a3274d312c9592b28a6dc08 https://jenkins.ubuntu.com/server/job/cloud-init-ci/537/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/537 SUCCESS:

Re: [Cloud-init-dev] [Merge] ~redriver/cloud-init:fail_to_install_on_frbsd into cloud-init:master

Diff comments: > diff --git a/tools/build-on-freebsd b/tools/build-on-freebsd > index ccc10b4..f16d62e 100755 > --- a/tools/build-on-freebsd > +++ b/tools/build-on-freebsd > @@ -17,6 +17,7 @@ pkgs=" > py27-jsonpatch > py27-jsonpointer > py27-oauth we can drop py27-oauth now. its

Re: [Cloud-init-dev] [Merge] ~jcastets/cloud-init:scaleway-datasource into cloud-init:master

Some things, and some content inline: * We'll need some unit tests for this. Otherwise it is at increased risk of being inadvertently broken. * We will need to add knowledge of the datasource to tools/ds-identify (without that your datasource will only ever be considered if it is a single

Re: [Cloud-init-dev] [Merge] ~jcastets/cloud-init:scaleway-datasource into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:adfca12743e2dd78ac1ad7f83253f41c06eb3795 https://jenkins.ubuntu.com/server/job/cloud-init-ci/536/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/536 SUCCESS:

[Cloud-init-dev] [Merge] ~jcastets/cloud-init:scaleway-datasource into cloud-init:master

Julien Castets has proposed merging ~jcastets/cloud-init:scaleway-datasource into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/325740 Implements Scaleway datasource

Re: [Cloud-init-dev] [Merge] ~redriver/cloud-init:fix-ifdown-for-frbsd-on-Azure into cloud-init:master

this seems sane just looking at the diff, i'll look further today. i think you'd opened a bug though... need to link to it. -- https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325713 Your team cloud-init commiters is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] ~redriver/cloud-init:fail_to_install_on_frbsd into cloud-init:master

I'll look at this later, but i'm not sure we can just - 'platform': platform.platform(), + 'platform': platform.uname()[0], without breaking other things. I'll try this out today though and will find a freebsd to test on. --

Re: [Cloud-init-dev] [Merge] ~redriver/cloud-init:fail_to_install_on_frbsd into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:3ac3e560626348e3efd88b30341e3e433b961a9e https://jenkins.ubuntu.com/server/job/cloud-init-ci/535/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/535 SUCCESS:

[Cloud-init-dev] [Merge] ~redriver/cloud-init:fail_to_install_on_frbsd into cloud-init:master

The proposal to merge ~redriver/cloud-init:fail_to_install_on_frbsd into cloud-init:master has been updated. Commit Message changed to: tools/build-on-freebsd was blocked fail to run tools/build-on-freebsd on FreeBSD platform. LP: #1698077 For more details, see: