Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into cloud-init:master

2017-07-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:22f7dc62e99d51d1f3f4185985141841de4d11db https://jenkins.ubuntu.com/server/job/cloud-init-ci/38/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu L

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into cloud-init:master

2017-07-12 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into cloud-init:master has been updated. Commit Message changed to: fix eni renderer when target is None This just uses the util.target_path() in the event that target is None. LP: #1703697 For more details, see: https://co

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into cloud-init:master

2017-07-12 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1703697 in cloud-init: "tox fails under python 3.6" https://bugs.launchpad.net/cloud-init/+bug/1703697 For mo

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:gce-mock-test-leak into cloud-init:master

2017-07-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:e0649d1ca2a8958829f56e24c4d8b08d6f16fd72 https://jenkins.ubuntu.com/server/job/cloud-init-ci/37/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu L

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:gce-mock-test-leak into cloud-init:master

2017-07-12 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:gce-mock-test-leak into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327325 test_gce: Fix invalid mock of platf

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/before-fsck into cloud-init:master

2017-07-12 Thread Scott Moser
Balint, thanks for your review! -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/before-fsck into cloud-init:master. ___ M

Re: [Cloud-init-dev] [Merge] ~j.kylmala/cloud-init:exceptions into cloud-init:master

2017-07-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:ec81bec2285a498c2c754572755929d983db3ef8 https://jenkins.ubuntu.com/server/job/cloud-init-ci/36/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu L

[Cloud-init-dev] [Merge] ~j.kylmala/cloud-init:exceptions into cloud-init:master

2017-07-12 Thread Joonas Kylmälä
Joonas Kylmälä has proposed merging ~j.kylmala/cloud-init:exceptions into cloud-init:master. Commit message: tools: Fix exception handling. We should be expecting IndexError instead of KeyError because we are using a list (key_ids) and not a dictionary. Also, thanks to Emmanuel Kasper for pointi

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/before-fsck into cloud-init:master

2017-07-12 Thread Balint Reczey
We discussed the proposal with Scott and since invalid fstab entries could appear in other cases, not just when re-partitioning devices on Azure I dropped my MP and I'm ok with this change. If the delayed fsck turns out to slow down boot significantly we could try narrowing the application of th

Re: [Cloud-init-dev] [Merge] ~szeestraten/cloud-init:doc-fix-disk-setup-examples into cloud-init:master

2017-07-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:fe5cc4eb684bd93d434eaf87e239e71a3971ba85 https://jenkins.ubuntu.com/server/job/cloud-init-ci/34/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu L

[Cloud-init-dev] [Merge] ~szeestraten/cloud-init:doc-fix-disk-setup-examples into cloud-init:master

2017-07-12 Thread Sandor Zeestraten
Sandor Zeestraten has proposed merging ~szeestraten/cloud-init:doc-fix-disk-setup-examples into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1703789 in cloud-init: "Disk setup example text only lists MBR as valid table_type" https://bugs.la