Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Chad Smith
Hrm, I'm still seeing upstart jobs included in /etc/init/*conf dpkg -L cloud-init | grep etc/init /etc/init /etc/init/cloud-init-blocknet.conf /etc/init/cloud-init-container.conf /etc/init/cloud-init-nonet.conf /etc/init/cloud-final.conf /etc/init/cloud-init-local.conf /etc/init/cloud-log-shutdow

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:d9e79a6ca14aa3e1816e8a4c9b88a3eeb1e0f19d https://jenkins.ubuntu.com/server/job/cloud-init-ci/235/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:91675024ed03e6dec2116aa48975746bc1ff66af https://jenkins.ubuntu.com/server/job/cloud-init-ci/234/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread noreply
The proposal to merge ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926 -- Your team cloud-init commiters is requested to review the pro

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926 -- Your team cloud-init commiters is requested to review t

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Joshua Powers
Review: Approve -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master. ___ Mailing list:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master has been updated. Commit Message changed to: tox: make xenial environment run with python3.6 The pinned versions of python packages in xenial do not work with python3.6. Currently, the failure can be seen with:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master has been updated. Commit Message changed to: tox: set xenial environment to use jsonpatch 1.16. The pinned versions of python packages in xenial do not work with python3.6. Currently, the failure can be seen wit

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Scott Moser
Josh. OK, i'll re-submit. That said, this doesn't work forever (only until 3.6 breaks something else or 3.7 along). -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/t

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:8555dddadd54187e0a5902d0b356f0803a50e896 https://jenkins.ubuntu.com/server/job/cloud-init-ci/232/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master has been updated. Commit Message changed to: upstart: do not package upstart jobs, drop ubuntu-init-switch module. The ubuntu-init-switch module allowed the use to launch an instance that was booted

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Scott Moser
> so that I understand intent here. We are leaving upstart logic in place so > that tip could be used to still generate upstart-based packages if we wanted. > We just don't want to package that init system by default anymore right? correct. we leave it all in place, but the upstream deb doesn't pa

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Chad Smith
so that I understand intent here. We are leaving upstart logic in place so that tip could be used to still generate upstart-based packages if we wanted. We just don't want to package that init system by default anymore right? -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merg

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Chad Smith
We need to drop the module from doc/rtd/topics/modules.rst too. .. automodule:: cloudinit.config.cc_ubuntu_init_switch -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329946 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:c

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:801c0cf7da205dc2bb0313eb99a53df2b2b7c01b https://jenkins.ubuntu.com/server/job/cloud-init-ci/230/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

2017-08-30 Thread Scott Moser
The proposal to merge ~xnox/cloud-init:devel into cloud-init:ubuntu/devel has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491 -- Your team cloud-init commiters is requested to review the proposed merge

Re: [Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

2017-08-30 Thread Scott Moser
Spurred on by this suggestion, I wrote an email to mailing list https://lists.launchpad.net/cloud-init/msg00095.html -- https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491 Your team cloud-init commiters is requested to review the proposed merge of ~xnox/cloud-init:devel in

[Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

2017-08-30 Thread Scott Moser
The proposal to merge ~xnox/cloud-init:devel into cloud-init:ubuntu/devel has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491 -- Your team cloud-init commiters is requested to review the proposed

Re: [Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

2017-08-30 Thread Scott Moser
This is fine with me. I'm not familiar with 'rm_conffile' but i have faith that Dimitri knows how to use it correctly. -- https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491 Your team cloud-init commiters is requested to review the proposed merge of ~xnox/cloud-init:devel

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master has been updated. Commit Message changed to: upstart: do not package upstart jobs, drop ubuntu-init-switch module. The ubuntu-init-switch module allowed the use to launch an instance that was booted

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

2017-08-30 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master. Commit message: ubuntu-init-switch: drop this module. The module allowed the use to launch an instance that was booted with upstart and have it switch its init system to systemd and then r

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Joshua Powers
I think we should accept the comment diff change (i.e. python version change + jsonpatch version change). This way we can keep it in the default environments to continue to get coverage of those modules versions. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926 Your

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:6e2f7e373a2526a9f9857db9155c5772f19df5a5 https://jenkins.ubuntu.com/server/job/cloud-init-ci/228/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

2017-08-30 Thread Ryan Harper
There are some other places upstart is touched (/etc/cloud/cloud.cfg emit_upstart, cc_ubuntu_init_switch, cc_mounts, handlers/upstart_job) It's also possible for other distros besides Ubuntu to use cloud-init's upstart jobs. We can take this as a task for Artful to no longer package the upstart

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Scott Moser
Another tested working option is this: $ git diff diff --git a/tox.ini b/tox.ini index 1e7ca2d3..c95f4443 100644 --- a/tox.ini +++ b/tox.ini @@ -66,8 +66,9 @@ deps = pyserial==3.0.1 configobj==5.0.6 requests==2.9.1 -# jsonpatch ubuntu is 1.10, not 1.19 (#839779) -jsonpatch==

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master has been updated. Commit Message changed to: tox: set xenial environment to be python 3.5. The pinned versions of python packages in xenial do not work with python3.6. Currently, the failure can be seen with: $

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926 -- Your team cloud-init commiters is reque

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

2017-08-30 Thread Scott Moser
On xenial, if you run: tox -e xenial tests/unittests/test_merging.py You'll see it fail with: http://paste.ubuntu.com/25432309/ I believe the reason is simply that some package (probably python-jsonpatch) at the version that we've pinned does not work with python3.6 that is 'python3' in an