Hi Scott,
I did not get a reply back yet. Will ping again.
E.
On 21 September 2017 at 02:15, Scott Moser wrote:
> Enol,
> I'm sorry to bother you, but did you get anywhere on the CLA ?
>
> Thanks,
> Scott
> --
> https://code.launchpad.net/~enolfc/cloud-init/+git/cloud-
> init/+merge/330518
> Y
Review: Approve continuous-integration
PASSED: Continuous integration, rev:27613443139578dd1b968d1f5f953bd2bc6245a4
https://jenkins.ubuntu.com/server/job/cloud-init-ci/337/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Chad Smith has proposed merging ~chad.smith/cloud-init:fix-schema-shpinx-docs
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/331118
docs: fix sphinx module schema
Enol,
I'm sorry to bother you, but did you get anywhere on the CLA ?
Thanks,
Scott
--
https://code.launchpad.net/~enolfc/cloud-init/+git/cloud-init/+merge/330518
Your team cloud-init commiters is requested to review the proposed merge of
~enolfc/cloud-init:bug-1716397 into cloud-init:master.
__
The proposal to merge ~chad.smith/cloud-init:add-cloudinit-pkg-to-all-targets
into cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/331099
--
Your team cloud-init commiters is r
ack.
I approve this.
kind of confused on why assert_called_once() wasnt failing.
perhaps we were just always getting a python-mock package or installed from pip
rather than the python built in.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/331099
Your team cloud-i
Review: Approve continuous-integration
PASSED: Continuous integration, rev:6e2771370102fbed46fba7c077fa9c328d02ecaa
https://jenkins.ubuntu.com/server/job/cloud-init-ci/336/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:dfb0628ecd69fca93e74de6db0abd3960d7948b3
https://jenkins.ubuntu.com/server/job/cloud-init-ci/335/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Chad Smith has proposed merging
~chad.smith/cloud-init:add-cloudinit-pkg-to-all-targets into cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/
clean up the comment i guess. we can use os.path.basename in both places.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOVF.py
> b/cloudinit/sources/DataSourceOVF.py
> index 24b45d5..4b02cbb 100644
> --- a/cloudinit/sources/DataSourceOVF.py
> +++ b/cloudinit/sources/DataSourceOVF.p
I'll add the os.path.basename(); should we do that in both places?
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOVF.py
> b/cloudinit/sources/DataSourceOVF.py
> index 24b45d5..4b02cbb 100644
> --- a/cloudinit/sources/DataSourceOVF.py
> +++ b/cloudinit/sources/DataSourceOVF.py
> @@ -
some small comments.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOVF.py
> b/cloudinit/sources/DataSourceOVF.py
> index 24b45d5..4b02cbb 100644
> --- a/cloudinit/sources/DataSourceOVF.py
> +++ b/cloudinit/sources/DataSourceOVF.py
> @@ -406,29 +406,19 @@ def transport_iso9660(requir
> As it turns out, two parallel instances of /bin/mount pointing
> to the same device will cause one to fail; it appears that there
> is some sort of locking/ref-counting during a mount operation
> that results in one of the two mount processes getting EBUSY as a result.
In particular, when we op
* State: Failed to upload
* Recipe: cloud-init-dev/cloud-init-daily-devel
* Archive: ~cloud-init-dev/ubuntu/daily
* Distroseries: artful
* Duration: 2 minutes
* Build Log:
https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+recipebuild/1452629/+files/buildlog.txt.gz
* Upload Log:
Rejected:
File cloud-init_0.7.9-1665-g7a2d4cc-0ubuntu1+1498~trunk~ubuntu17.10.1.tar.xz
already exists in cloud-init daily builds, but uploaded version has different
contents. See more information about this error in
https://help.launchpad.net/Packaging/UploadErrors.
Files specified in DSC are br
Review: Approve continuous-integration
PASSED: Continuous integration, rev:2699208b16ad63b924eee748ff3d39510efc1559
https://jenkins.ubuntu.com/server/job/cloud-init-ci/334/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Ryan Harper has proposed merging
~raharper/cloud-init:ds-ovf-use-util-find-devs-with into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1718287 in cloud-init: "systemd mount targets fail due to device busy or
already mounted"
https://bugs.la
As it turns out, two parallel instances of /bin/mount pointing to the same
device will cause one to fail; it appears that there is some sort of
locking/ref-counting during a mount operation that results in one of the two
mount processes getting EBUSY as a result.
This sort of race is recreatabl
I've kept the regex filter as suggested and added unittests.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/330995
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:ds-ovf-use-util-find-devs-with into cloud-init:master.
__
Review: Approve continuous-integration
PASSED: Continuous integration, rev:9e5c58f64b418b364622785ccf8b63ccef3cdb0a
https://jenkins.ubuntu.com/server/job/cloud-init-ci/333/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
20 matches
Mail list logo
