Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:taskLimit into cloud-init:master

2017-09-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:13e9fa83f60f0b3553111a69feb693f6dfb95302 https://jenkins.ubuntu.com/server/job/cloud-init-ci/348/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:tmplExpand into cloud-init:master

2017-09-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:73acbf4a00741f8b9b4b278120b6119b83d28b03 https://jenkins.ubuntu.com/server/job/cloud-init-ci/347/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:xenial/fix-debian-copyright into cloud-init:ubuntu/xenial

2017-09-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c75086d415fb880b03ab39275c1f0eb4f6a42f58 https://jenkins.ubuntu.com/server/job/cloud-init-ci/345/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:zesty/fix-debian-copyright into cloud-init:ubuntu/zesty

2017-09-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:4b698954ccd18bc5fdf96823fbc1e6e1fcf40b37 https://jenkins.ubuntu.com/server/job/cloud-init-ci/344/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:devel/fix-debian-copyright into cloud-init:ubuntu/devel

2017-09-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:9b26debc236bb99ba90243d9dc5be97123986f96 https://jenkins.ubuntu.com/server/job/cloud-init-ci/343/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~powersj/cloud-init:zesty/fix-debian-copyright into cloud-init:ubuntu/zesty

2017-09-21 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:zesty/fix-debian-copyright into cloud-init:ubuntu/zesty. Commit message: d/copyright: Add text of Apache 2.0 The license was updated to be dual-licensed under Apache 2.0 and GPL 3.0, however the text of the Apache 2.0 licence was not added t

[Cloud-init-dev] [Merge] ~powersj/cloud-init:xenial/fix-debian-copyright into cloud-init:ubuntu/xenial

2017-09-21 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:xenial/fix-debian-copyright into cloud-init:ubuntu/xenial. Commit message: d/copyright: Add text of Apache 2.0 The license was updated to be dual-licensed under Apache 2.0 and GPL 3.0, however the text of the Apache 2.0 licence was not added

[Cloud-init-dev] [Merge] ~powersj/cloud-init:devel/fix-debian-copyright into cloud-init:ubuntu/devel

2017-09-21 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:devel/fix-debian-copyright into cloud-init:ubuntu/devel. Commit message: d/copyright: Add text of Apache 2.0 The license was updated to be dual-licensed under Apache 2.0 and GPL 3.0, however the text of the Apache 2.0 licence was not add

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-shlex-fix into cloud-init:master

2017-09-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c0ad5b4f90dca79814e0cdb1dd591900d38ac6af https://jenkins.ubuntu.com/server/job/cloud-init-ci/342/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/fake-extended-tempfile-cleanup into cloud-init:master

2017-09-21 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/fake-extended-tempfile-cleanup into cloud-init:master. Commit message: tests: remove a temp file used in bootcmd tests. The bootcmd test was leaving files in the tmpdir named ci-FakeExtendedTempFile.XX. This cleans those up. Requeste

[Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-shlex-fix into cloud-init:master

2017-09-21 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:cii-shlex-fix into cloud-init:master. Commit message: tests: remove dependency on shlex This removes shlex and converts the subprocess commands to use a list over a string. Requested reviews: cloud-init commiters (cloud-init-dev) For mor

[Cloud-init-dev] Release of cloud-init 17.1

2017-09-21 Thread Scott Moser
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Depending on your half of the world, Happy Fall or Happy Spring! Cloud-init release 17.1 is now available. The source tarball can be downloaded at https://launchpad.net/cloud-init/trunk/17.1 Docs can be seen at: http://cloudinit.readthedocs.io/e

[Cloud-init-dev] [Merge] ~smoser/cloud-init:candidate/17.1 into cloud-init:master

2017-09-21 Thread noreply
The proposal to merge ~smoser/cloud-init:candidate/17.1 into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/331161 -- Your team cloud-init commiters is requested to review the pro

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:candidate/17.1 into cloud-init:master

2017-09-21 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:bf6456fd2220e6c1ca43a373e12af0c3d8a93bab https://jenkins.ubuntu.com/server/job/cloud-init-ci/340/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:candidate/17.1 into cloud-init:master

2017-09-21 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:candidate/17.1 into cloud-init:master has been updated. Commit Message changed to: release 17.1 Bump the version in cloudinit/version.py to be 17.1 and update ChangeLog. For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-ini

[Cloud-init-dev] [Merge] ~smoser/cloud-init:candidate/17.1 into cloud-init:master

2017-09-21 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:candidate/17.1 into cloud-init:master. Commit message: release 17.1 Bump the version in cloudinit/version.py to be 17.1 and update ChangeLog. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launc

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-opensuse into cloud-init:master

2017-09-21 Thread Robert Schweikert
Review: Approve LGTM, lets just see what happens with the repo keys, but I suspect they are there. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329650 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/run-opensuse i

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:tmplExpand into cloud-init:master

2017-09-21 Thread Robert Schweikert
Diff comments: > diff --git a/systemd/cloud-init-local.service.tmpl > b/systemd/cloud-init-local.service.tmpl > index ff9c644..870ccf1 100644 > --- a/systemd/cloud-init-local.service.tmpl > +++ b/systemd/cloud-init-local.service.tmpl > @@ -13,6 +13,10 @@ Before=shutdown.target > Before=sysinit

[Cloud-init-dev] [Merge] ~arnd-arndnet/cloud-init:document_gce_datasource into cloud-init:master

2017-09-21 Thread Scott Moser
The proposal to merge ~arnd-arndnet/cloud-init:document_gce_datasource into cloud-init:master has been updated. Commit Message changed to: doc: document GCE datasource. Add some minimal documentation for GCE datasource. For more details, see: https://code.launchpad.net/~arnd-arndnet/cloud-init

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:tmplExpand into cloud-init:master

2017-09-21 Thread Scott Moser
OK, i really would like to have some response to my inline comments. Additionally, I put together this change: http://paste.ubuntu.com/25587466/ that i'd like added. And I updated the Commit message. So, if i can get some feedback on * 'basic.target' versus 'sysinit.target', * dbus.service

[Cloud-init-dev] [Merge] ~rjschwei/cloud-init:tmplExpand into cloud-init:master

2017-09-21 Thread Scott Moser
The proposal to merge ~rjschwei/cloud-init:tmplExpand into cloud-init:master has been updated. Commit Message changed to: suse: updates to templates to support openSUSE and SLES. Things done here: - identify 'suse' as a variant in util.system_info and also tools/render-cloudcfg. - update s

[Cloud-init-dev] [Merge] ~rjschwei/cloud-init:addZyppRepos into cloud-init:master

2017-09-21 Thread Robert Schweikert
Robert Schweikert has proposed merging ~rjschwei/cloud-init:addZyppRepos into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1718675 in cloud-init: "It should be possible to add repos in SUSE distros" https://bugs.launchpad.net/cloud-init/+bu

Re: [Cloud-init-dev] [Merge] ~arnd-arndnet/cloud-init:document_gce_datasource into cloud-init:master

2017-09-21 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c21ff9a0a032ce31db7bf5a1c69946b295eb02ee No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):

[Cloud-init-dev] [Merge] ~arnd-arndnet/cloud-init:document_gce_datasource into cloud-init:master

2017-09-21 Thread Arnd
Arnd has proposed merging ~arnd-arndnet/cloud-init:document_gce_datasource into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~arnd-arndnet/cloud-init/+git/cloud-init/+merge/331148 -- Your team cloud-init commiter

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:fix-schema-shpinx-docs into cloud-init:master

2017-09-21 Thread noreply
The proposal to merge ~chad.smith/cloud-init:fix-schema-shpinx-docs into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/331118 -- Your team cloud-init commiters is requested to re

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:tmplExpand into cloud-init:master

2017-09-21 Thread Scott Moser
over all, changes look fine. two questions inline. Diff comments: > diff --git a/systemd/cloud-init-local.service.tmpl > b/systemd/cloud-init-local.service.tmpl > index ff9c644..870ccf1 100644 > --- a/systemd/cloud-init-local.service.tmpl > +++ b/systemd/cloud-init-local.service.tmpl > @@ -13,

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:fix-schema-shpinx-docs into cloud-init:master

2017-09-21 Thread Scott Moser
The proposal to merge ~chad.smith/cloud-init:fix-schema-shpinx-docs into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/331118 -- Your team cloud-init commiters is requested

[Cloud-init-dev] [Merge] ~rjschwei/cloud-init:sysvinitSUSE into cloud-init:master

2017-09-21 Thread Robert Schweikert
Robert Schweikert has proposed merging ~rjschwei/cloud-init:sysvinitSUSE into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1718649 in cloud-init: "sysV-init SUSE integration is broken" https://bugs.launchpad.net/cloud-init/+bug/1718649 For

[Cloud-init-dev] [Merge] ~rjschwei/cloud-init:tmplExpand into cloud-init:master

2017-09-21 Thread Robert Schweikert
Robert Schweikert has proposed merging ~rjschwei/cloud-init:tmplExpand into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/331140 Integrate SUSE distros for template expa