Review: Approve continuous-integration
PASSED: Continuous integration, rev:6763d7eb536b9f07e29e4e032589cee693be9d0d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/552/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Robert Schweikert has proposed merging ~rjschwei/cloud-init:btrfsResize into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/334338
Resize of btrfs fails if "/" is mounted
Review: Approve continuous-integration
PASSED: Continuous integration, rev:3292754b6aa52b43150edf3dbe28a470da44d7f1
https://jenkins.ubuntu.com/server/job/cloud-init-ci/551/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Robert Schweikert has proposed merging ~rjschwei/cloud-init:reproducibleBuild
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/334337
Make the package build for distri
On Mon, Nov 27, 2017 at 4:31 PM, Scott Moser
wrote:
>
> It looks like as it is right now we do not call destroy on an image before
> using a snapshot.
> But having NoCloud work like other clouds makes sense.
>
I don't disagree with the goal; however; just as I don't want to upload a
new snapshot
Diff comments:
> diff --git a/cloudinit/sources/__init__.py b/cloudinit/sources/__init__.py
> index 9a43fbe..ec0fe2a 100644
> --- a/cloudinit/sources/__init__.py
> +++ b/cloudinit/sources/__init__.py
> @@ -78,6 +103,52 @@ class DataSource(object):
> def __str__(self):
> return type
It looks like as it is right now we do not call destroy on an image before
using a snapshot.
But having NoCloud work like other clouds makes sense.
As it is right now we only ever call snapshot wrapped in a context handler of
an image.
--
https://code.launchpad.net/~smoser/cloud-init/+git/clo
Review: Approve continuous-integration
PASSED: Continuous integration, rev:ec1229688e6fa7abef2b306d4e2ffd8f8f83cf3d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/550/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
@raharper and @chad.smith
Thanks for review and comments.
Fixed: Test location and IPv4 regular expression.
Comments and questions on the other info you provided.
As far as the test data is concerned, I kind of did a cut and paste from
existing tests based on network configuration for the dist
Review: Approve continuous-integration
PASSED: Continuous integration, rev:462d4c1710f08212d2b84f359e54242b2507f0b0
https://jenkins.ubuntu.com/server/job/cloud-init-ci/548/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
you have some merge conflicts in the diff.
i'll review more later.
this does look good though.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330115
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:unify-datasource-ge
> the Image object has a destroy() method which is valid to call, and should be
> called whne you're "done" with the object.
> i = Image(foo)
> i.execute(['apt-get', 'dist-upgrade'])
> s = i.snapshot()
> i.destroy()
> s.launch()
> ...
>
> the result of snapshot needs to be stand-alone,
Review: Approve continuous-integration
PASSED: Continuous integration, rev:27ff24127c0bd5074817a199eb373cae5ab83d29
https://jenkins.ubuntu.com/server/job/cloud-init-ci/547/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Diff comments:
> diff --git a/cloudinit/distros/net_util.py b/cloudinit/distros/net_util.py
> index 1ce1aa7..fad062d 100644
> --- a/cloudinit/distros/net_util.py
> +++ b/cloudinit/distros/net_util.py
> @@ -148,6 +160,16 @@ def translate_network(settings):
> hw_addr = hw_spli
the Image object has a destroy() method which is valid to call, and should be
called whne you're "done" with the object.
i = Image(foo)
i.execute(['apt-get', 'dist-upgrade'])
s = i.snapshot()
i.destroy()
s.launch()
...
the result of snapshot needs to be stand-alone, and before this ch
Diff comments:
> diff --git a/cloudinit/distros/net_util.py b/cloudinit/distros/net_util.py
> index 1ce1aa7..fad062d 100644
> --- a/cloudinit/distros/net_util.py
> +++ b/cloudinit/distros/net_util.py
> @@ -67,6 +67,11 @@
> # }
> # }
>
> +import re
> +
> +ipv4 = re.compile("\d{1,3}.\d{1,3
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:cc9905002cd5956d01c5aa31676be719b0170f5d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/546/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
Looking over the failure, that MAAS compatibility testing hit an issue with an
include url test unrelated to your branch. Can you git fetch on master and git
rebase your branch against master and re-push that branch up. It will contain
the fix 6ad23fe9b11f07e4404c8a1f2f1e9cba2640dceb which shoul
Review: Approve continuous-integration
PASSED: Continuous integration, rev:d4a0ba4b179f534e86ca5fdf1d691bf762b2ea8d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/545/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Diff comments:
> diff --git a/tests/cloud_tests/images/nocloudkvm.py
> b/tests/cloud_tests/images/nocloudkvm.py
> index 1e7962c..8678b07 100644
> --- a/tests/cloud_tests/images/nocloudkvm.py
> +++ b/tests/cloud_tests/images/nocloudkvm.py
> @@ -21,7 +25,13 @@ class NoCloudKVMImage(base.Image):
>
> An image is a mutable thing.
> General flow of tests is:
> - get an image
> - update the image (install a new deb)
> - create a snapshot
> - launch a snapshot multiple times
>
> After creating a snapshot of the image the image can reasonably be destroyed.
> Just like in a "real cloud".
> -
Ryan McCabe has proposed merging ~rmccabe/cloud-init:bug1734739 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1734739 in cloud-init: "cloud-init mishandles dhcp6 subnets in
network_data.json"
https://bugs.launchpad.net/cloud-init/+bug/1
Diff comments:
> diff --git a/tests/cloud_tests/images/nocloudkvm.py
> b/tests/cloud_tests/images/nocloudkvm.py
> index 1e7962c..8678b07 100644
> --- a/tests/cloud_tests/images/nocloudkvm.py
> +++ b/tests/cloud_tests/images/nocloudkvm.py
> @@ -21,7 +25,13 @@ class NoCloudKVMImage(base.Image):
>
An image is a mutable thing.
General flow of tests is:
- get an image
- update the image (install a new deb)
- create a snapshot
- launch a snapshot multiple times
After creating a snapshot of the image the image can reasonably be destroyed.
Just like in a "real cloud".
- get an image (downlo
The proposal to merge ~smoser/cloud-init:fix/cii-kvmimage-preserve-original
into cloud-init:master has been updated.
Commit Message changed to:
tests: NoCloudKVMImage do not modify the original local cache image.
The NoCloudKVMImage.execute() would modify the image in /srv/citest
that meant tha
Diff comments:
> diff --git a/cloudinit/distros/net_util.py b/cloudinit/distros/net_util.py
> index 1ce1aa7..fad062d 100644
> --- a/cloudinit/distros/net_util.py
> +++ b/cloudinit/distros/net_util.py
> @@ -148,6 +160,16 @@ def translate_network(settings):
> hw_addr = hw_spli
What's the use case for the "destroy an image without breaking a snapshot" that
introduces the copy of the image.
Some more comments inline as well.
Diff comments:
> diff --git a/tests/cloud_tests/images/nocloudkvm.py
> b/tests/cloud_tests/images/nocloudkvm.py
> index 1e7962c..8678b07 100644
>
27 matches
Mail list logo
