Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:parameterize-cloud-config into cloud-init:master

2017-11-28 Thread Scott Moser
I like this. I had a few comments inline. One thing i worry about is bytes versus string. It seems like our binary-safe json handler has the effect that sometimes a value is a string and sometimes it is bytes depending on the content that was in it. >From a consumer perspective, that is annoyin

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:parameterize-cloud-config into cloud-init:master

2017-11-28 Thread Scott Moser
>From your well written description, Where did '%f' come from ? in puppet: conf: agent: server: "puppetmaster.local" certname: "{{ v1.instance_id }}.%f" -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334030 Your team cloud-init commiters is requeste

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master

2017-11-28 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/sources/__init__.py b/cloudinit/sources/__init__.py > index 9a43fbe..ec0fe2a 100644 > --- a/cloudinit/sources/__init__.py > +++ b/cloudinit/sources/__init__.py > @@ -78,6 +103,52 @@ class DataSource(object): > def __str__(self): > return type