[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify into cloud-init:master

2017-12-12 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify into cloud-init:master. Commit message: ds-identify: failure in NoCloud due to unset variable usage. The previous OVF datasource change added a debug message that referenced an un-used variable. The fai

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify into cloud-init:master

2017-12-12 Thread Scott Moser
Diff comments: > diff --git a/tools/ds-identify b/tools/ds-identify > index 4c59d7b..5893a76 100755 > --- a/tools/ds-identify > +++ b/tools/ds-identify > @@ -657,7 +657,7 @@ is_cdrom_ovf() { > # skip devices that don't look like cdrom paths. > case "$dev" in > /dev/sr[0-9]|/de

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify into cloud-init:master

2017-12-12 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:75eaa4d20584eb52969acc1b011816d7d7d099c4 https://jenkins.ubuntu.com/server/job/cloud-init-ci/619/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ub

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify into cloud-init:master

2017-12-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:23b34b55cd4107f8cc2a7228eec648811813793e https://jenkins.ubuntu.com/server/job/cloud-init-ci/620/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:fix-modules-cmdline-help into cloud-init:master

2017-12-12 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:fix-modules-cmdline-help into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1736600 in cloud-init: "cloud-init modules -h documents unsupported --mode init" https://bugs.launchpad.net/cl

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:fix-modules-cmdline-help into cloud-init:master

2017-12-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:171e54e007a6a5357b194fb5805451a7bc670682 https://jenkins.ubuntu.com/server/job/cloud-init-ci/621/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel

2017-12-12 Thread Joshua Powers
Review: Approve -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335099 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel. ___ Maili

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel

2017-12-12 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1737704 in cloud-init: "Cloud-init fails if iso9660 filesystem on non-cdrom path in 20171211 image." https://bugs.la

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel

2017-12-12 Thread noreply
The proposal to merge ~chad.smith/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335099 -- Your team cloud-init commiters is requested to re

[Cloud-init-dev] [recipe build #1499760] of ~cloud-init-dev cloud-init-daily-xenial in xenial: Failed to build

2017-12-12 Thread noreply
* State: Failed to build * Recipe: cloud-init-dev/cloud-init-daily-xenial * Archive: ~cloud-init-dev/ubuntu/daily * Distroseries: xenial * Duration: 2 minutes * Build Log: https://launchpad.net/~cloud-init-dev/+archive/ubuntu/daily/+recipebuild/1499760/+files/buildlog.txt.gz * Upload Log:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial

2017-12-12 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/335100 -- Your team

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial

2017-12-12 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial has been updated. Commit Message changed to: debian/patches/ds-identify-behavior-xenial.patch: refresh patch upstream changes to ds-identify made this not apply cleanly. Simply refres

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel

2017-12-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:be7a4c209d227385a1fc89214c5a216c857ee9d7 https://jenkins.ubuntu.com/server/job/cloud-init-ci/622/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial

2017-12-12 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial has been updated. Description changed to: ds-identify changed, so the xenial patch that is applied no longer cleanly applies. This fixes daily build recipe failures like: https://lis

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

2017-12-12 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master has been updated. Commit Message changed to: MAAS: add check_instance_id based off oauth tokens. This stores a hash of the OAuth tokens as an 'id' for the maas datasource. Since ne

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

2017-12-12 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master. Commit message: MAAS: add check_instance_id based off oauth tokens. This stores a hash of the OAuth tokens as an 'id' for the maas datasource. Since new instances get ne

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

2017-12-12 Thread Scott Moser
no tests, but I'm interested in thoughts. We could make 'id_hash' a property since ds_cfg gets stored. Chad I'm interested in your thoughts on this and the unification of storage, how did I affect that? -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/335108 Your team clo

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

2017-12-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:cefcd130bfb452453fbfd56c83dd175de258c620 https://jenkins.ubuntu.com/server/job/cloud-init-ci/624/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

2017-12-12 Thread Chad Smith
I know this is a completely separate direction than you are taking. It feels a bit like we are gating all cloud-init updates/runs based on whether the instance-id changes. In a world where cloud-init becomes re-entrany (or hotplug handling) should cloud-init grow the ability for people to supple

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

2017-12-12 Thread Chad Smith
Another question I have is across reboots (same instance) do we worry about MAAS changing network topology between boots? If so, locking network setup permanently until re-deploy would cause breakage -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/335108 Your team cloud-i

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

2017-12-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:2543c765cba201570f697ccf5d5efc5a75b65322 https://jenkins.ubuntu.com/server/job/cloud-init-ci/625/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~illfelder/cloud-init:master into cloud-init:master

2017-12-12 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:ae79eaa0e295a8cfc8f50a48d42fb6d50f3c1087 https://jenkins.ubuntu.com/server/job/cloud-init-ci/626/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu