Akihiko Ota has proposed merging ~sw37th/cloud-init:fix_for_opennebula into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1716397 in cloud-init: "OpenNebula network configuration is ignored for
distros with predictable interface names."
http
The proposal to merge ~sw37th/cloud-init:fix_for_opennebula into
cloud-init:master has been updated.
Commit Message changed to:
OpenNebula: add network_config property
DataSourceOpenNebula has no network_config property, so it cannot
return network configurations.
This patch adds network_config
Scott Moser has proposed merging ~smoser/cloud-init:release/17.2 into
cloud-init:master.
Commit message:
release 17.2
Bump the version in cloudinit/version.py to be 17.2 and update ChangeLog.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launch
I'd like to record tests of this here, and then we'll call this good.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/335233
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:release/17.2 into cloud-init:master.
___
I've tested under uvt-kvm with:
$ uvt-kvm create sm-b1 release=bionic
$ uvt-kvm wait sm-b1
$ uvt-kvm ssh sm-b1 -- dpkg-query --show cloud-init
cloud-init 17.1-60-ga30a3bb5-0ubuntu1
$ uvt-kvm ssh sm-b1 -- cat /etc/cloud/build.info
$ uvt-kvm ssh sm-b1 -- cat /etc/cloud/build.info
build_na
Jenkins ran c-i for the previous tip
a30a3bb5 cloud-init_17.1-60-ga30a3bb5-1~bddeb_all.deb
at
cloud-init-ci-nightly
https://jenkins.ubuntu.com/server/view/cloud-init/job/cloud-init-ci-nightly/188/
cloud-init-integration-lxd-x
https://jenkins.ubuntu.com/server/view/cloud-init/job/cloud-init-i
Review: Approve continuous-integration
PASSED: Continuous integration, rev:c87588bf1e118095445ed0713f60866592b36ca1
https://jenkins.ubuntu.com/server/job/cloud-init-ci/631/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Tested the version we will update to 17.2 on GCE and Amazon:
EC2 BEGIN ---
csmith@downtown:~$ ssh ubu...@ec2-18-217-153-55.us-east-2.compute.amazonaws.com
Welcome to Ubuntu Bionic Beaver (development branch) (GNU/Linux
4.13.0-17-generic x86_64)
* Docu
"AWS at the start of tests and deleted on exit."
I think the keys will need to always be deleted no matter whether we finish;
unless we specifically have some flag the user set to keep keys.
I don't think we want automatic runs of this to fail at any stage after
injecting keys and not have it e
givin config 'cfg' and distro 'distro'
(users, _groups) = ug_util.normalize_users_groups(cfg, distro)
(default_user, _user_config) = ug_util.extract_default(users)
default_user is then the use name.
I think there may be an issue though in that the cfg that the datasource gets
is only config
Some in-line comments and questions.
Diff comments:
> diff --git a/tests/cloud_tests/platforms.yaml
> b/tests/cloud_tests/platforms.yaml
> index fa4f845..458ab81 100644
> --- a/tests/cloud_tests/platforms.yaml
> +++ b/tests/cloud_tests/platforms.yaml
> @@ -6,8 +6,13 @@ default_platform_config:
>
Replaced my pop() with next() in the in-line comments.
Diff comments:
> diff --git a/tests/cloud_tests/platforms/ec2/platform.py
> b/tests/cloud_tests/platforms/ec2/platform.py
> new file mode 100644
> index 000..8ff2716
> --- /dev/null
> +++ b/tests/cloud_tests/platforms/ec2/platform.py
> @
Review: Approve continuous-integration
PASSED: Continuous integration, rev:3f76bbf7b5873a9150acc83357787f86e3a14e50
https://jenkins.ubuntu.com/server/job/cloud-init-ci/632/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Added commit for using stream image data and comments with more questions from
intial reviews of Scott and Ryan. Thank you both!
Diff comments:
> diff --git a/tests/cloud_tests/platforms.yaml
> b/tests/cloud_tests/platforms.yaml
> index fa4f845..458ab81 100644
> --- a/tests/cloud_tests/platform
Chad Smith has proposed merging ~chad.smith/cloud-init:devtool-check-mps into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335244
tools: Add check-mps tool for review
Food for thought. I just used this script to review, vote and land
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+ref/fix-modules-cmdline-help.
On landing it marks the MP as merged at the propoer revid and marks the
appropriate bug task as 'Fix committed'.
--
https://code
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:699fd6d287a9133540101c68870a4bc6a97a1678
https://jenkins.ubuntu.com/server/job/cloud-init-ci/634/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenki
17 matches
Mail list logo
