[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master. Commit message: tests: Fix EC2 Platform to return console output as bytes. The EC2 test platform uses boto, and boto decodes console output with decode('utf-8', 'replace). It is known that U

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:fe062d4c1fddcf1c8eb3be64491cba22a1a23113 https://jenkins.ubuntu.com/server/job/cloud-init-ci/703/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenki

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Ryan Harper
Diff comments: > diff --git a/tests/cloud_tests/platforms/ec2/platform.py > b/tests/cloud_tests/platforms/ec2/platform.py > index fdb17ba..ba246fe 100644 > --- a/tests/cloud_tests/platforms/ec2/platform.py > +++ b/tests/cloud_tests/platforms/ec2/platform.py > @@ -228,4 +230,28 @@ class EC2Platf

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Scott Moser
Diff comments: > diff --git a/tests/cloud_tests/platforms/ec2/platform.py > b/tests/cloud_tests/platforms/ec2/platform.py > index fdb17ba..ba246fe 100644 > --- a/tests/cloud_tests/platforms/ec2/platform.py > +++ b/tests/cloud_tests/platforms/ec2/platform.py > @@ -228,4 +230,28 @@ class EC2Platf

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Joshua Powers
Diff comments: > diff --git a/tests/cloud_tests/platforms/ec2/instance.py > b/tests/cloud_tests/platforms/ec2/instance.py > index 4ba737a..9a7d303 100644 > --- a/tests/cloud_tests/platforms/ec2/instance.py > +++ b/tests/cloud_tests/platforms/ec2/instance.py > @@ -46,9 +46,16 @@ class EC2Instanc

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:d99de644facb7d2424bbd00cbc817075e8726729 https://jenkins.ubuntu.com/server/job/cloud-init-ci/706/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:ac4b5f7b0dd7c4d2c095357cc20f822f976c8fb4 https://jenkins.ubuntu.com/server/job/cloud-init-ci/707/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:815c3699f9afad9853aeaa096ef18f055a22dc9c https://jenkins.ubuntu.com/server/job/cloud-init-ci/710/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

2018-01-19 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:8aa01bc5b0759d22927c5a1dd030a1d66d1dcfaf https://jenkins.ubuntu.com/server/job/cloud-init-ci/711/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu