Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:docs-cli-subcommands into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:0518f587e5e499b8f5eb6886943d73cdbb4d0320 https://jenkins.ubuntu.com/server/job/cloud-init-ci/742/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:docs-cli-subcommands into cloud-init:master

think I addressed all comments. Much thanks for the thorough review here. Diff comments: > diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst > index 859409a..47a5998 100644 > --- a/doc/rtd/topics/boot.rst > +++ b/doc/rtd/topics/boot.rst > @@ -125,4 +125,6 @@ Things that run here incl

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1745663-use-lxd-console into cloud-init:master

Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:d941491687592392bdfc71d9f2c28d6222732f47 https://jenkins.ubuntu.com/server/job/cloud-init-ci/740/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenki

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1745663-use-lxd-console into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1745663-use-lxd-console into cloud-init:master. Commit message: tests: lxd platform replace console log implementation. This disables the '_setup_console_log' path we had for getting a log in lxd. It implements a path that requires liblxc3

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:uninitialized-variables into cloud-init:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:efab669ff3d9c0089b0686c03234093b629bb1c8 https://jenkins.ubuntu.com/server/job/cloud-init-ci/739/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:uninitialized-variables into cloud-init:master

Diff comments: > diff --git a/cloudinit/cmd/status.py b/cloudinit/cmd/status.py > index 3e5d0d0..d7aaee9 100644 > --- a/cloudinit/cmd/status.py > +++ b/cloudinit/cmd/status.py > @@ -93,6 +93,8 @@ def _is_cloudinit_disabled(disable_file, paths): > elif not os.path.exists(os.path.join(paths.r