Romanos,
Sorry to keep bothering you :)
Thanks again for your help.
I looked to pull this in, and found that it has merge conflicts
with master.
I've rebased onto master and would just like you to review my
changes.
See https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/339373
Nifty test, and good change. The comment doesn't quite match the code;
'cloud-init will decode'
should be 'cloud-init will encode'
Right?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/338586
Your team cloud-init commiters is requested to review the proposed merge of
yeah, good catch. updated commit message and the comment also.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/338586
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/1751051-subp-encode-with-utf8 into cloud-init:master.
The proposal to merge ~smoser/cloud-init:bug/1751051-subp-encode-with-utf8 into
cloud-init:master has been updated.
Commit Message changed to:
subp: Fix subp usage with non-ascii characters when no system locale.
If python starts up without a locale set, then its default encoding
ends up se
Ryan Harper has proposed merging ~raharper/cloud-init:fix/netplan-accept-ra-off
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339437
netplan: disable IPV6 RA mode u
The proposal to merge ~raharper/cloud-init:feature/update-ntp-spec into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339438
--
Your team cloud-init commiters is requ
Ryan Harper has proposed merging ~raharper/cloud-init:feature/update-ntp-spec
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339438
Implement ntp client spec with au
Review: Approve continuous-integration
PASSED: Continuous integration, rev:f59bca50f8c24f18a892f937ec18c3bb640baf01
https://jenkins.ubuntu.com/server/job/cloud-init-ci/788/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
8 matches
Mail list logo