The proposal to merge
~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into
cloud-init:master has been updated.
Commit message changed to:
pylint: pay attention to unused variable warnings.
This enables warnings produced by pylint for unused variables (W0612),
and fixes the exis
Review: Approve continuous-integration
PASSED: Continuous integration, rev:3ddd3a322945a9bff8d1906fe2a268c70f851b92
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1021/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:41e3e47422f4c4bbb4fcbbd93ebf5b03b56f979d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1020/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenk
The proposal to merge
~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into
cloud-init:master has been updated.
Commit message changed to:
pylint: pay attention to unused variable warnings.
This just enables warnings produced by pylint for unused warnings (W0612),
and fixes the
tox -e pylint finds a few more for me.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343469
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into
cloud-init:master.
___
The proposal to merge
~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into
cloud-init:master has been updated.
Commit message changed to:
pylint: enable W0612 (unused-variable)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343469
--
Fix your commit message, you're paying attention to:
# W0612(unused-variable)
Not
# W0621(redefined-outer-name)
Diff comments:
> diff --git a/cloudinit/analyze/dump.py b/cloudinit/analyze/dump.py
> index b071aa1..1bb16da 100644
> --- a/cloudinit/analyze/dump.py
> +++ b/cloudinit/analyze/dump.
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:2a46897cce9284be00a722d7b2b30a8a8f28a6e9
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1019/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
https://jenk
Scott Moser has proposed merging
~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into
cloud-init:master.
Commit message:
pay attention to W0621
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/c
one useful thougt.
Diff comments:
> diff --git a/cloudinit/netinfo.py b/cloudinit/netinfo.py
> index 993b26c..a8c7f7a 100644
> --- a/cloudinit/netinfo.py
> +++ b/cloudinit/netinfo.py
> @@ -18,18 +20,89 @@ from cloudinit.simpletable import SimpleTable
> LOG = logging.getLogger()
>
>
> -def n
Diff comments:
> diff --git a/cloudinit/netinfo.py b/cloudinit/netinfo.py
> index 993b26c..a8c7f7a 100644
> --- a/cloudinit/netinfo.py
> +++ b/cloudinit/netinfo.py
> @@ -18,18 +20,89 @@ from cloudinit.simpletable import SimpleTable
> LOG = logging.getLogger()
>
>
> -def netdev_info(empty=""
Review: Approve continuous-integration
PASSED: Continuous integration, rev:ce6206876661f3921a709c294296309051987de2
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1018/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~mgerdts/cloud-init:lp1763511 into cloud-init:master has
been updated.
Commit message changed to:
DataSourceSmartOS: ephemeral drive should default to ext4
ext3 is not able to support file system sizes that are needed in Joyent's
cloud. For the default block size of 4k, t
The proposal to merge ~mgerdts/cloud-init:lp1763511 into cloud-init:master has
been updated.
Commit message changed to:
DataSourceSmartOS: ephemeral drive should default to ext4
ext3 is not able to support file system sizes that are needed in Joyent's
cloud. This changes the default file syste
The device_aliases change in the documentation makes it so that documentation
matches reality. Pre-existing code made the default ephemeral disk /dev/vdb.
--
https://code.launchpad.net/~mgerdts/cloud-init/+git/cloud-init/+merge/343435
Your team cloud-init commiters is requested to review the pro
Mike Gerdts has proposed merging ~mgerdts/cloud-init:lp1763511 into
cloud-init:master.
Commit message:
DataSourceSmartOS: ephemeral drive should default to ext4
ext3 is not able to support file system sizes that are needed in Joyent's
cloud. This changes the default file system type fro
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:b3b37145cdd44d11e03be6b6bff724f09034e9a8
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1014/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
FAILED: Ub
17 matches
Mail list logo
