Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/bionic into cloud-init:ubuntu/bionic

2018-10-16 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:7bce4f1523d7737c159e7c185c0e9e20ea8bdbf6 https://jenkins.ubuntu.com/server/job/cloud-init-ci/399/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/bionic into cloud-init:ubuntu/bionic

2018-10-16 Thread Chad Smith
The proposal to merge ~chad.smith/cloud-init:ubuntu/bionic into cloud-init:ubuntu/bionic has been updated. Commit message changed to: Patch ubuntu debian/cloud-init.postinst to rewrite /run/cloud-init/instance-data*.json on upgrade LP: #1798189 For more details, see: https://code.launchpad.ne

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/bionic into cloud-init:ubuntu/bionic

2018-10-16 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:ubuntu/bionic into cloud-init:ubuntu/bionic. Commit message: Patch ubuntu debian/cloud-init.postinst to rewrite /run/cloud-init/instance-data*.json on upgrade LP: #1798189 Requested reviews: cloud-init commiters (cloud-init-dev) Related

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:xenial/dont-render-network-from-imds into cloud-init:ubuntu/xenial

2018-10-16 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:4f6bb1c1d62b23e29c62bf399a6a5554eca72542 https://jenkins.ubuntu.com/server/job/cloud-init-ci/398/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:xenial/dont-render-network-from-imds into cloud-init:ubuntu/xenial

2018-10-16 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c416f35766358a432b4c2f4d09ac1ae742d49fe8 https://jenkins.ubuntu.com/server/job/cloud-init-ci/397/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests FAILED: Ubuntu LTS: Build Click here to t

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:xenial/dont-render-network-from-imds into cloud-init:ubuntu/xenial

2018-10-16 Thread Chad Smith
Just built the deb and validated behavior on Xenial. IMDS is still queried and exists in instance-data.json, but that configuration is not used to return network_config note the v1 in DatasourceAzure.network_config sudo python3 -c "from cloudinit.stages import _pkl_load; print(_pkl_load('/var/l

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:xenial/dont-render-network-from-imds into cloud-init:ubuntu/xenial

2018-10-16 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:7d41f5a2c28441d7832a5629a15381986c08c6c7 https://jenkins.ubuntu.com/server/job/cloud-init-ci/396/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:xenial/dont-render-network-from-imds into cloud-init:ubuntu/xenial

2018-10-16 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:8d6b1280ee7987ebf06eb719e3b94fa4c2559f63 https://jenkins.ubuntu.com/server/job/cloud-init-ci/395/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:xenial/dont-render-network-from-imds into cloud-init:ubuntu/xenial

2018-10-16 Thread Ryan Harper
Are any of the cloud-init cli commands affected if we don't have IMDS data? I was thinking in metadata field outputs? -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/356888 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-i

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:xenial/dont-render-network-from-imds into cloud-init:ubuntu/xenial

2018-10-16 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:xenial/dont-render-network-from-imds into cloud-init:ubuntu/xenial. Commit message: xenial-azure: Disable rendering network from IMDS In Xenial we already have hotplug scripts delivered in stock cloud-images. Disable rendering network infor

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1798117-allow-toplevel-network-in-network-config into cloud-init:master

2018-10-16 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:02d7c7bfdefceb71db86cec0ca09dea49576fc34 https://jenkins.ubuntu.com/server/job/cloud-init-ci/394/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1798117-allow-toplevel-network-in-network-config into cloud-init:master

2018-10-16 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1798117-allow-toplevel-network-in-network-config into cloud-init:master. Commit message: NoCloud: Allow top level 'network' key in network-config. NoCloud's 'network-config' file was originally expected to contain network configuration wit