[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master

2018-11-26 Thread Server Team CI bot
The proposal to merge ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/359557 -- Your team cloud-init commiters is requ

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master

2018-11-26 Thread Scott Moser
The proposal to merge ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master has been updated. Commit message changed to: logs: collect-logs ignore instance-data-sensitive.json on non-root user Since /run/cloud-init/instance-data-sensitive.json is root read-only, ignore

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master

2018-11-26 Thread Scott Moser
The proposal to merge ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/359557 -- Your team cloud-init commiters i

Re: [Cloud-init-dev] [Merge] ~i.galic/cloud-init:refactor/net-fbsd into cloud-init:master

2018-11-26 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:ad0bf7a82b8a6faddb62e2d8278fcafac5159b1d https://jenkins.ubuntu.com/server/job/cloud-init-ci/459/ Executed test runs: SUCCESS: Checkout FAILED: Unit & Style Tests Click here to trigger a rebuild: https://jenki

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master

2018-11-26 Thread Scott Moser
one commit message fix. other than that, i approve. Diff comments: > diff --git a/cloudinit/cmd/devel/logs.py b/cloudinit/cmd/devel/logs.py > index df72520..4c086b5 100644 > --- a/cloudinit/cmd/devel/logs.py > +++ b/cloudinit/cmd/devel/logs.py > @@ -118,21 +133,21 @@ def collect_logs(tarfile, i

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master

2018-11-26 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:861b8882d801f5953e746770f47d4aedfe573d84 https://jenkins.ubuntu.com/server/job/cloud-init-ci/458/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master

2018-11-26 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs into cloud-init:master. Commit message: logs: collect-logs ignore instance-data-sensitive.json on non-root user Since /run/cloud-init/instance-data-sensitive.json is root read-only, ignore this file if non-r