Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/debian-config-yaml-spaces into cloud-init:ubuntu/devel

2019-08-30 Thread Ryan Harper
Thanks for the updated sed script Chad, going with that. -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/371919 Your team cloud-init commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/debian-config-yaml-spaces into cloud-init:ubuntu/devel. _

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/debian-config-yaml-spaces into cloud-init:ubuntu/devel

2019-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:ec8979444b661e337c84f91e415544599ea1ef81 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1096/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/debian-config-yaml-spaces into cloud-init:ubuntu/devel

2019-08-30 Thread Scott Moser
Diff comments: > diff --git a/debian/cloud-init.config b/debian/cloud-init.config > index 6e9c6f7..adaabb8 100644 > --- a/debian/cloud-init.config > +++ b/debian/cloud-init.config > @@ -32,13 +32,13 @@ hasEc2Md() { > get_yaml_list() { > # get_yaml_list(file, key, def): return a comma del

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/debian-config-yaml-spaces into cloud-init:ubuntu/devel

2019-08-30 Thread Ryan Harper
OK, I've combined Chad's clean-up and then emitted that as the value, like this: LISTVAL="$(sed -e "s/\s//g" -e "/^$key:/"'!'d \ -e "s/$key:\[//;s/]//;s/,/, /g" "$file")" RET="$key: [ ${LISTVAL} ]" In action looks like this: # Edge-case, single entry root@x1:~# cat /etc/cloud/clo

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/debian-config-yaml-spaces into cloud-init:ubuntu/devel

2019-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:6e6be6a5dee8b24b61f18e6d6c208255d681e87e https://jenkins.ubuntu.com/server/job/cloud-init-ci/1097/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

[Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-08-30 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:docs/config-tox into cloud-init:master. Commit message: doc: document doc, create markefile and tox target * Create makefile and tox targets for documentation building and testing to better replicate the live web docs using the same theme. *

[Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/remove-readme into cloud-init:master

2019-08-30 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:docs/remove-readme into cloud-init:master. Commit message: docs: remove unnecessary file in doc directory Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git

[Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/whitespace_spelling into cloud-init:master

2019-08-30 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:docs/whitespace_spelling into cloud-init:master. Commit message: docs: fix whitespace, spelling, and line length Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~powersj/cloud-in

Re: [Cloud-init-dev] [Merge] ~t0rrant/cloud-init:1819966-sysconfig-options into cloud-init:master

2019-08-30 Thread Ryan Harper
There is no direct integration in the module for dhcp provided ntp servers at this time. It's possible but there isn't a great interface (AFAIK) to query your OS for the dhcp response for a given interface. -- https://code.launchpad.net/~t0rrant/cloud-init/+git/cloud-init/+merge/371948 Your tea

[Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/reorganize into cloud-init:master

2019-08-30 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:docs/reorganize into cloud-init:master. Commit message: docs: reorganize TOC and clean up topics After seeing others come ask for help in IRC I decided to start reorganizing the project documentations. It has grown into useful docs for devel

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/reorganize into cloud-init:master

2019-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:d433d0af097cd76238b559cdda1d265986392e58 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1099/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/whitespace_spelling into cloud-init:master

2019-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:b16a3abc6524904dd74613180b6d5e88e2332e68 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1100/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/remove-readme into cloud-init:master

2019-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:51925e3654c18a5f078705b55023622db4068636 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1101/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:docs/config-tox into cloud-init:master

2019-08-30 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:3366a331a27d601159604fa1a4531167a45da623 https://jenkins.ubuntu.com/server/job/cloud-init-ci/1102/ Executed test runs: SUCCESS: Checkout SUCCESS: Unit & Style Tests SUCCESS: Ubuntu LTS: Build SUCCESS: Ubuntu