Joshua Powers has proposed merging ~powersj/cloud-init:migrate-lp-to-github
into cloud-init:master.
Commit message:
lp-to-git-users: adding powersj
Mapped from powersj
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud
Joshua Powers has proposed merging ~powersj/cloud-init:migrate-lp-to-github
into cloud-init:master.
Commit message:
lp-to-git-users: adding powersj
Mapped from powersj
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud
Joshua Powers has proposed merging ~powersj/cloud-init:docs/zstack_fix into
cloud-init:master.
Commit message:
docs: Fixes zstack line lengths
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge
Joshua Powers has proposed merging ~powersj/cloud-init:fix/azure_ip_doc into
cloud-init:master.
Commit message:
docs: Fix incorrect Azure IMDS IP address
The Azure datasource was incorrectly listing the IP address. This
updates the address to match what is in the Azure provided IMDS
Joshua Powers has proposed merging ~powersj/cloud-init:docs/boot into
cloud-init:master.
Commit message:
docs: clean up formatting, organize boot page
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud
Joshua Powers has proposed merging ~powersj/cloud-init:docs/availability into
cloud-init:master.
Commit message:
docs: more complete list of availability
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud
Joshua Powers has proposed merging ~powersj/cloud-init:docs/datasource into
cloud-init:master.
Commit message:
docs: cleanup output & order of datasource page
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/
Joshua Powers has proposed merging ~powersj/cloud-init:docs/cli into
cloud-init:master.
Commit message:
docs: create cli specific page
This is formerly the capabilities page.
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj
Joshua Powers has proposed merging ~powersj/cloud-init:docs/instancedata into
cloud-init:master.
Commit message:
docs: doc8 fixes for instancedata page
The huge table was scrolling off the page for me and it made more sense
to break this up and have sections for each item anyway.
Requested
The proposal to merge ~chad.smith/cloud-init:stable-18.4 into
cloud-init:stable-18.4 has been updated.
Commit message changed to:
README.md: describe the branch intent
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/372432
--
Your team
Thanks for the reviews.
Fixed the commit message and responded to comments below.
Diff comments:
> diff --git a/doc/rtd/conf.py b/doc/rtd/conf.py
> index 4174477..9b27484 100644
> --- a/doc/rtd/conf.py
> +++ b/doc/rtd/conf.py
> @@ -17,7 +17,8 @@ from cloudinit.config.schema import
The proposal to merge ~powersj/cloud-init:docs/config-tox into
cloud-init:master has been updated.
Commit message changed to:
doc: document doc, create makefile and tox target
* Create makefile and tox targets for documentation building and testing
to better replicate the live web docs using
Joshua Powers has proposed merging ~powersj/cloud-init:docs/reorganize into
cloud-init:master.
Commit message:
docs: reorganize TOC and clean up topics
After seeing others come ask for help in IRC I decided to start
reorganizing the project documentations. It has grown into useful docs
Joshua Powers has proposed merging ~powersj/cloud-init:docs/whitespace_spelling
into cloud-init:master.
Commit message:
docs: fix whitespace, spelling, and line length
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud
Joshua Powers has proposed merging ~powersj/cloud-init:docs/remove-readme into
cloud-init:master.
Commit message:
docs: remove unnecessary file in doc directory
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init
Joshua Powers has proposed merging ~powersj/cloud-init:docs/config-tox into
cloud-init:master.
Commit message:
doc: document doc, create markefile and tox target
* Create makefile and tox targets for documentation building and testing
to better replicate the live web docs using the same theme
Joshua Powers has proposed merging ~powersj/cloud-init:fix/pyflakes-local-var
into cloud-init:master.
Commit message:
pyflakes: remove unused variable
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud
The proposal to merge ~powersj/cloud-init:fix/pyflakes-local-var into
cloud-init:master has been updated.
Description changed to:
tip-pyflakes is currently failing: https://paste.ubuntu.com/p/WYRRmFzmPF/
For more details, see:
Diff between Dan's branch and mine https://paste.ubuntu.com/p/v3gwtq7SQ9/
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/365549
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:feature/cc-uaclient into cloud-init:master.
Joshua Powers has proposed merging ~powersj/cloud-init:feature/cc-uaclient into
cloud-init:master.
Commit message:
ubuntu_advantage: rewrite cloud-config module
ubuntu-advantage-tools version 19 has a different command line
interface. Update cloud-init's config module to accept new
Inline comment around sso auth
Diff comments:
> diff --git a/cloudinit/config/cc_ubuntu_advantage.py
> b/cloudinit/config/cc_ubuntu_advantage.py
> index 5e082bd..1a95766 100644
> --- a/cloudinit/config/cc_ubuntu_advantage.py
> +++ b/cloudinit/config/cc_ubuntu_advantage.py
> @@ -1,145 +1,170 @@
Joshua Powers has proposed merging ~powersj/cloud-init:test-add-disco into
cloud-init:master.
Commit message:
tests: add Disco release
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/358881
Example output:
https://paste.ubuntu.com/p/phx5f8v8bj/
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/353685
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:read-version-error-msg into cloud-init:master.
Joshua Powers has proposed merging ~powersj/cloud-init:read-version-error-msg
into cloud-init:master.
Commit message:
read-version: enhance error message
The error message when read-vesion is not very useful and does not help
the end-user know how to overcome the issue. This adds a short
Joshua Powers has proposed merging ~powersj/cloud-init:disable-snap-test into
cloud-init:master.
Commit message:
tests: disable other snap test as well
The snap test requires access to a proxy and currently the integration
tests do not handle this scenario. I am disabling the test until I can
Used fixes from smoser and re-ran tests for write_files on Xenial and Bionic:
all good.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/353355
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:fix-cii into
Joshua Powers has proposed merging ~powersj/cloud-init:fix-cii into
cloud-init:master.
Commit message:
tests: disable snap, fix write_files binary
The snap test requires access to a proxy and currently the integration
tests do not handle this scenario. I am disabling the test untill I can
loop
Diff comments:
> diff --git a/tests/cloud_tests/testcases/modules/ntp_chrony.py
> b/tests/cloud_tests/testcases/modules/ntp_chrony.py
> index 461630a..7a115c9 100644
> --- a/tests/cloud_tests/testcases/modules/ntp_chrony.py
> +++ b/tests/cloud_tests/testcases/modules/ntp_chrony.py
> @@ -1,13
I ran through a few runs with Debian and Fedora, looked good comments below.
Thanks for making the deprecation message and existing script. Not sure why CI
failed, but I'll look once it is up and running again.
Diff comments:
> diff --git a/tools/run-container b/tools/run-container
> new file
Before looking at this, one thing to note is that CI will obviously need to be
updated before this is landed and unless someone rebases re-runs will fail
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/345627
Your team cloud-init commiters is requested to review the
Diff comments:
> diff --git a/tox.ini b/tox.ini
> index 818ade3..268d230 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -10,9 +10,9 @@ setenv =
> [testenv:flake8]
> basepython = python3
> deps =
> -pycodestyle==2.3.1
> -pyflakes==1.5.0
> -flake8==3.3.0
> +pycodestyle==2.4.0
> +
Diff comments:
> diff --git a/tests/cloud_tests/platforms/instances.py
> b/tests/cloud_tests/platforms/instances.py
> index 3bad021..fa392b7 100644
> --- a/tests/cloud_tests/platforms/instances.py
> +++ b/tests/cloud_tests/platforms/instances.py
> @@ -98,21 +103,21 @@ class
Joshua Powers has proposed merging ~powersj/cloud-init:cii-restructure-ssh into
cloud-init:master.
Commit message:
tests: restructure SSH and initial connections
The SSH function was retrying and waiting for SSH for over an
hour when an SSH connection was failing to be established. This
reduces
I like the comparisons on versions, that helps a lot on future tests.
In addition to the unit and style tests, the integration tests need fixing:
https://paste.ubuntu.com/p/MWzFZjZYwS/
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366
Your team cloud-init
See inline
Diff comments:
> diff --git a/tests/cloud_tests/testcases/modules/snap.py
> b/tests/cloud_tests/testcases/modules/snap.py
> new file mode 100644
> index 000..7120e3f
> --- /dev/null
> +++ b/tests/cloud_tests/testcases/modules/snap.py
> @@ -0,0 +1,132 @@
> +# This file is part of
Review: Approve
LGTM thanks for this!
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/337499
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/tools-run-centos-use-git-clone into
cloud-init:master.
thinking about this some more, this will not pull in uncommitted code. Do we
want to have a message print a warning to the user that they have uncommitted
code and it won't be pulled in?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/337499
Your team cloud-init
Did you push for the right branch? This looks like packaging of a new release.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/337499
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/tools-run-centos-use-git-clone into
Review: Approve
+1 - I'm good with this as well. It does seem a little hacky, but to get us to
3.0 that is fine and we still get console logs :)
First run (abbreviated output):
https://paste.ubuntu.com/26490439/
Second run:
https://paste.ubuntu.com/26490453/
Console on 2nd run:
Review: Approve
LGTM
Tried this out locally and works much better :) thanks!
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336722
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/1745663-use-lxd-console into
Review: Approve
LGTM simply removes the dns lookup as:
ubuntu@wind:~$ ntpq -p -w
remote refid st t when poll reach delay offset jitter
==
maas.maas 91.189.91.1573 u2 641
Diff comments:
> diff --git a/tests/cloud_tests/platforms/ec2/instance.py
> b/tests/cloud_tests/platforms/ec2/instance.py
> index 4ba737a..9a7d303 100644
> --- a/tests/cloud_tests/platforms/ec2/instance.py
> +++ b/tests/cloud_tests/platforms/ec2/instance.py
> @@ -46,9 +46,16 @@ class
Joshua Powers has proposed merging ~powersj/cloud-init:cii-zesty into
cloud-init:master.
Commit message:
tests: remove zesty as supported OS to test
Zesty goes EOL as of January 13, 2017. This removes it as a valid
OS for testing.
Requested reviews:
cloud-init commiters (cloud-init-dev
Updated commit message
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/335855
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:cii-ssh-keyname into cloud-init:master.
___
Mailing
The proposal to merge ~powersj/cloud-init:cii-ssh-keyname into
cloud-init:master has been updated.
Commit Message changed to:
tests: rename generated ssh keys
While the generated ssh keys are throw away keys, generating SSH keys
with the default name (e.g. id_rsa) can trigger security scanners
The proposal to merge ~powersj/cloud-init:cii-requirements into
cloud-init:master has been updated.
Commit Message changed to:
tests: add integration requirements text file
This adds the specific requirements for integration testing to
a single file that can be referenced in other areas. It
I have removed the work done to read-dependencies and updated the commit
message: First, all non-ubuntu OSes do not have access to simplestreams as it
is not available via system packages or via PyPI. This already limits the
usefulness of this to Ubuntu. Second, the version of pylxd, must be
Joshua Powers has proposed merging ~powersj/cloud-init:cii-ssh-keyname into
cloud-init:master.
Commit message:
tests: rename generated ssh keys
This renames the generated ssh keys for integration testing in order to
comply with a request that the default private ssh key name of id_rsa
I believe I have made the changes we talked about on Friday and this is ready
for another review.
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/335774
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:cii-requirements into
Joshua Powers has proposed merging ~powersj/cloud-init:cii-image-properties
into cloud-init:master.
Commit message:
tests: clean up image properties
This fixes the incorrectly named 'family' value for images as 'os'.
Families are already defined in util.py:OS_FAMILY_MAPPING and a family
Diff comments:
> diff --git a/integration-requirements.txt b/integration-requirements.txt
> new file mode 100644
> index 000..0509d5f
> --- /dev/null
> +++ b/integration-requirements.txt
> @@ -0,0 +1,15 @@
> +# PyPI requirements for cloud-init integration testing
> +#
Joshua Powers has proposed merging ~powersj/cloud-init:cii-requirements into
cloud-init:master.
Commit message:
tests: add integration requirements text file
This adds the specific requirements for integration testing to
a single file that can be referenced in other areas. It also enables
I think I've addressed all the required fixes and review comments at this time.
The commit message was updated to note why t2.micro was chosen (small + free
tier).
Thanks!
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/335186
Your team cloud-init commiters is
The proposal to merge ~powersj/cloud-init:cii-enable-ec2 into cloud-init:master
has been updated.
Commit Message changed to:
tests: Enable AWS EC2 Integration Testing
This enables integration tests to utilize AWS EC2 as a testing platform by
utilizing the boto3 Python library.
Usage will
Joshua Powers has proposed merging ~powersj/cloud-init:cii-enable-ec2 into
cloud-init:master.
Commit message:
tests: Enable AWS EC2 Integration Testing
This enables integration tests to utilize AWS EC2 as a testing platform by
utilizing the boto3 Python library.
Usage will create and delete
The proposal to merge ~powersj/cloud-init:cii-enable-ec2 into cloud-init:master
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/335186
--
Your team cloud-init commiters is requested to
Added commit for using stream image data and comments with more questions from
intial reviews of Scott and Ryan. Thank you both!
Diff comments:
> diff --git a/tests/cloud_tests/platforms.yaml
> b/tests/cloud_tests/platforms.yaml
> index fa4f845..458ab81 100644
> ---
Joshua Powers has proposed merging ~powersj/cloud-init:cii-enable-ec2 into
cloud-init:master.
Commit message:
tests: Enable AWS EC2 Integration Testing
This enables integration tests to utilize AWS EC2 as a testing platform.
This is done through the usage of the boto3 library.
Usage
Review: Approve
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/335099
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:ubuntu/devel into cloud-init:ubuntu/devel.
___
Joshua Powers has proposed merging ~powersj/cloud-init:cii-move-ssh into
cloud-init:master.
Commit message:
tests: Move SSH execution to instance super class
The nocloud-kvm instance is not the only instance that will eventually
make use of the SSH operations. Therefore, this moves those
Joshua Powers has proposed merging ~powersj/cloud-init:cii-fix-console-log into
cloud-init:master.
Commit message:
tests: fix collect_console when not implemented
The exception was incorrectly creating a string and not a bytes object.
Requested reviews:
cloud-init commiters (cloud-init
Joshua Powers has proposed merging ~powersj/cloud-init:cii-move-genkeys into
cloud-init:master.
Commit message:
tests: move SSH key gen to platform superclass
Allow each platform to determine if and when they need to generate SSH
keys. For example, this prevents LXD from unnecessarily creating
Review: Needs Fixing
Thanks for doing this! Can you add comment to description/commit message about
meta-data getting added to the integration tests?
Looks like a few tip-pylint errors, one of which is why I asked about getting
rid of tools/hacking.py.
Otherwise I ran a full lxd and
Review: Approve
LGTM thanks for adding meta data
Note: there will be a new line at the end of the public key like:
= ubuntu@cloud_test\n"
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334780
Your team cloud-init commiters is requested to review the proposed merge
Joshua Powers has proposed merging ~powersj/cloud-init:cii-revamp-dir-structure
into cloud-init:master.
Commit message:
tests: consolidate platforms into specific dirs
This groups up each test platform into its own directory rather
than having files spread between four different directories
Review: Approve
+1 This also makes sure we are able to properly use --preserve-data now with
qcow2 files that are ready to boot in the event triage is needed, even if the
original file is deleted.
Test with:
python3 -m tests.cloud_tests run --platform nocloud-kvm \
--verbose
The proposal to merge ~powersj/cloud-init:enable-bionic into cloud-init:master
has been updated.
Description changed to:
Initial test successful:
https://paste.ubuntu.com/26022031/
Full test successful:
https://paste.ubuntu.com/26022129/
For more details, see:
The proposal to merge ~powersj/cloud-init:enable-bionic into cloud-init:master
has been updated.
Description changed to:
Initial test works:
https://paste.ubuntu.com/26022031/
Full test in progress
For more details, see:
Review: Approve
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334074
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master.
Review: Approve
+1 This looked very familiar, as in we already changed this [1], but it appears
we didn't change all the places. This removes the final references to curtin.
[1]
https://github.com/cloud-init/cloud-init/commit/067721672570cc83d54d2c2d5677eeb79bef85e2
--
Review: Needs Fixing
I cannot get the nocloud-kvm datasource to even run with the following commit:
$ git rev-parse HEAD
5d38855c6254d82df54ce31eea8863798b892c6c
One comment below about a debug message and should the commit message more
verbosely call out the new TargetBased class?
* PASS -
Review: Approve
+1 Thanks for the cleanup
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/332587
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/tests-command-output-simple-warn into cloud-init:master.
Review: Approve
LGTM - Thanks for fixing the integration test!
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/332540
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:ntp-schema into cloud-init:master.
Joshua Powers has proposed merging ~powersj/cloud-init:disable-fastestmirror
into cloud-init:master.
Commit message:
tools: disable fastestmirror if using proxy
Per centos documentation using the fastestmirror plugin is
effective at finding the fastest mirror, unless you are behind a
proxy
Joshua Powers has proposed merging ~powersj/cloud-init:cii-fix-kvm-tests into
cloud-init:master.
Commit message:
tests: Enable all tests for nocloud-kvm backend
The original testcases were written using the lxd backend only. This
commit enables the use of the nocloud-kvm backend for all
Joshua Powers has proposed merging ~powersj/cloud-init:cii-combine-test-cases
into cloud-init:master.
Commit message:
tests: Combine integration configs and testcases
Combine the configs and testcases directories, so all files are
together in one place. Update the test config location
Review: Approve
LGTM
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/331670
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/remove-license-for-non-present-boto.py into
cloud-init:master.
Review: Approve
LGTM
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/331284
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/debian-852564-no-hardcoded-udevadm into
cloud-init:master.
Joshua Powers has proposed merging
~powersj/cloud-init:zesty/fix-debian-copyright into cloud-init:ubuntu/zesty.
Commit message:
d/copyright: Add text of Apache 2.0
The license was updated to be dual-licensed under Apache 2.0 and
GPL 3.0, however the text of the Apache 2.0 licence was not added
Joshua Powers has proposed merging
~powersj/cloud-init:xenial/fix-debian-copyright into cloud-init:ubuntu/xenial.
Commit message:
d/copyright: Add text of Apache 2.0
The license was updated to be dual-licensed under Apache 2.0 and
GPL 3.0, however the text of the Apache 2.0 licence
Joshua Powers has proposed merging
~powersj/cloud-init:devel/fix-debian-copyright into cloud-init:ubuntu/devel.
Commit message:
d/copyright: Add text of Apache 2.0
The license was updated to be dual-licensed under Apache 2.0 and
GPL 3.0, however the text of the Apache 2.0 licence
The proposal to merge ~powersj/cloud-init:cii-strings into cloud-init:master
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/330535
--
Your team cloud-init commiters is requested to
Diff comments:
> diff --git a/tests/cloud_tests/instances/base.py
> b/tests/cloud_tests/instances/base.py
> index 959e9cc..af0d235 100644
> --- a/tests/cloud_tests/instances/base.py
> +++ b/tests/cloud_tests/instances/base.py
> @@ -31,6 +31,8 @@ class Instance(object):
> target
Joshua Powers has proposed merging ~powersj/cloud-init:add-xkvm into
cloud-init:master.
Commit message:
tools: Add xkvm script, wrapper around qemu-system
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud
Joshua Powers has proposed merging ~powersj/cloud-init:cii-strings into
cloud-init:master.
Commit message:
tests: execute: support command as string
If a string is passed to execute, then invoke 'bash', '-c',
'string'. That allows the less verbose execution of simple
commands:
image.execute
Review: Approve
+1 thanks for this it makes it a lot easier on simple commands.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330459
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/integration-execute-with-string
The proposal to merge ~powersj/cloud-init:cii-kvm into cloud-init:master has
been updated.
Commit Message changed to:
test: Enable the KVM platform on integration tests
The KVM platform includes:
* Base Ubuntu images from daily stream
* Image setup via mount-image-callback
* Generation
Thanks for the reviews!
@chad.smith - It would be helpful to get your command line that you used where
things failed or crashed.
For the record there are two design decisions that I want to clarify:
1) LXD still uses pylxd. I would like to change this over to
mount-image-callback at some
Example output:
https://paste.ubuntu.com/25447308/
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/330111
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:unittest-add-timing into cloud-init:master.
Joshua Powers has proposed merging ~powersj/cloud-init:unittest-add-timing into
cloud-init:master.
Commit message:
tox: add nose timer output
This adds the output of the nose timer plugin to the py27
enviornment to tox. This will print out the 10 longest running
tests and automatically turn
Review: Approve
Ran on the test system and was back to under 20 seconds for each environment.
Add link to bug (LP: 1714117), fix style tests, and this is good to go!
tests/unittests/test_datasource/test_ec2.py:6:1: F401 're' imported but unused
Review: Approve
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master.
___
Mailing
I think we should accept the comment diff change (i.e. python version change +
jsonpatch version change). This way we can keep it in the default environments
to continue to get coverage of those modules versions.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926
2 comments inline
Diff comments:
> diff --git a/tools/run-opensuse b/tools/run-opensuse
> new file mode 100755
> index 000..e974f8c
> --- /dev/null
> +++ b/tools/run-opensuse
> @@ -0,0 +1,273 @@
> +#!/bin/bash
> +# This file is part of cloud-init. See LICENSE file for license information.
>
I have been leaving integration test requirements out of requirements-test.txt.
For example, pylxd is not in there either. I consider that file what is
required for unit tests only. Thoughts?
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327646
Your team cloud-init
Joshua Powers has proposed merging ~powersj/cloud-init:cii-kvm into
cloud-init:master.
Commit message:
test: Enable the KVM platform on integration tests
The KVM platform includes:
* Ubuntu images from daily stream
* Image setup via mount-image-callback
* Generation and injection
Joshua Powers has proposed merging ~powersj/cloud-init:fix-cii-tree into
cloud-init:master.
Commit message:
tests: Fix build tree integration tests
The build deb command was no longer working because it had
assumed that you were in the root of the cloud-init directory.
This changes where
Review: Approve
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328095
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:fix/locale-test-update into cloud-init:master.
___
Mailing
Review: Approve
LGTM one comment below.
Diff comments:
> diff --git a/tests/cloud_tests/releases.yaml b/tests/cloud_tests/releases.yaml
> index 45deb58..c8dd142 100644
> --- a/tests/cloud_tests/releases.yaml
> +++ b/tests/cloud_tests/releases.yaml
> @@ -143,19 +143,6 @@ releases:
>
Joshua Powers has proposed merging ~powersj/cloud-init:fix-arch-hostname into
cloud-init:master.
Commit message:
archlinux: fix set hostname
cloud-init fails to set the hostname on Arch Linux becuase that
_write_hostname passes conf instead of str(conf) to util.write_file.
LP: #1705306
1 - 100 of 161 matches
Mail list logo
