Lars Kellogg-Stedman has proposed merging
~larsks/cloud-init:migrate-lp-to-github into cloud-init:master.
Commit message:
lp-to-git-users: adding larsks
Mapped from larsks
Requested reviews:
cloud-init Commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~larsks
Ping @smoser; let me know if this looks okay. Thanks!
--
https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/345113
Your team cloud-init commiters is requested to review the proposed merge of
~larsks/cloud-init:bz/1542578 into cloud-init:master.
Lars Kellogg-Stedman has proposed merging ~larsks/cloud-init:bug/1769952 into
cloud-init:master.
Commit message:
do not rely on host /proc/cmdline in test_net.py
this makes test_net.TestGenerateFallbackConfig.test_unstable_names mock the
value of /proc/cmdline in the same way
I've added a few unit tests for the fstab handling code.
--
https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/345113
Your team cloud-init commiters is requested to review the proposed merge of
~larsks/cloud-init:bz/1542578 into cloud-init:master.
I agree re: refactoring, but I'm not sure I'm up to that right now. I'll make
the changes you suggested and I'll add a test or two.
Diff comments:
> diff --git a/cloudinit/config/cc_mounts.py b/cloudinit/config/cc_mounts.py
> index f14a4fc..c0d5029 100644
> --- a/cloudinit/config/cc_mounts.py
Lars Kellogg-Stedman has proposed merging ~larsks/cloud-init:bz/1542578 into
cloud-init:master.
Commit message:
cc_mounts: do not add devices to fstab that are already configured
do not add new entries to /etc/fstab for devices that already have an
existing fstab entry.
Resolves: rhbz
Review: Disapprove
I've updated the original merge proposal so that applies cleanly and passes
with current master. Please use that one, and let me fix it if it needs
additional changes. Thanks!
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330090
Your team
Lars Kellogg-Stedman has proposed merging
~larsks/cloud-init:feature/move-base-testcase into cloud-init:master with
~larsks/cloud-init:bug/ec2-tests as a prerequisite.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Server Team CI bot (server-team-bot): continuous-integration
The proposal to merge ~larsks/cloud-init:feature/move-base-testcase into
cloud-init:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/329655
--
Your team cloud-init commiters is requested
Lars Kellogg-Stedman has proposed merging ~larsks/cloud-init:bug/ec2-tests into
cloud-init:master with ~larsks/cloud-init:feature/hide-oauthlib-import-failure
as a prerequisite.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init
Lars Kellogg-Stedman has proposed merging
~larsks/cloud-init:feature/move-base-testcase into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/329655
relocate tests/unittests
Lars Kellogg-Stedman has proposed merging ~larsks/cloud-init:bug/ec2-tests into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/329654
test_ec2: metadata tests were mocking
Review: Approve
Other than a minor quibble about where we are rendering the header for the NM
configuration file, I think this looks fine.
--
https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/325325
Your team cloud-init commiters is requested to review the proposed merge of
Diff comments:
> diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
> index f7d4548..b5c90a6 100644
> --- a/cloudinit/net/sysconfig.py
> +++ b/cloudinit/net/sysconfig.py
> @@ -447,6 +451,21 @@ class Renderer(renderer.Renderer):
>
I've added a couple of inline comments.
Diff comments:
> diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
> index f7d4548..b5c90a6 100644
> --- a/cloudinit/net/sysconfig.py
> +++ b/cloudinit/net/sysconfig.py
> @@ -447,6 +451,21 @@ class Renderer(renderer.Renderer):
>
Andreas: I was starting to review this code, but because of commit
dd03bb411c9a6f10854a3bbc3223b204c3d4d174 this no longer applies cleanly against
cloud-init master. Will you have the chance to rebase?
--
https://code.launchpad.net/~akaris/cloud-init/+git/cloud-init/+merge/323340
Your team
If code is actually calling this with an integer argument, this looks like a
fine temporary fix.
I say "temporary" because I'm a little confused by the return value of this
function, too, which looks like it may be an int (when it calls ipv4mask2cidr)
or a string (when it calls ipv6mask2cidr)
Review: Approve
Seems fine to me, although I'm still in favor of just defaulting to something
sane instead of throwing a ValueError for unknown link types.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/321709
Your team cloud init development team is requested to review
I've added a unit test.
--
https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/317553
Your team cloud init development team is requested to review the proposed merge
of ~larsks/cloud-init:lp/1665441 into cloud-init:master.
___
Mailing
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index c657fd0..cbcb61c 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -22,6 +22,69 @@ LOG = logging.getLogger(__name__)
> # Which
I've provided an updated test. It fails under master, but succeeds with this
patch applied.
--
https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/315263
Your team cloud init development team is requested to review the proposed merge
of ~larsks/cloud-init:fedora/1151824 into
Lars Kellogg-Stedman has proposed merging ~larsks/cloud-init:lp/1658200 into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1658200 in cloud-init: "Running tests via nosestests fails due to
insufficient test isolation&quo
Lars Kellogg-Stedman has proposed merging ~larsks/cloud-init:fedora/1151824
into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1658174 in cloud-init: "cloud-init fails to disable ecdsa-sha2-nitp521
keys"
https://bugs.lau
This all looks fine as far as fixing the immediate problem.
I can't help but feel that there must be a better way to cooperate with
networkmanager, because there are some situations in which it's really useful
to have nm managing dns (vpn environments in which you want certain domains to
Diff comments:
> diff --git a/tools/hook-dhclient b/tools/hook-dhclient
> index d099979..6a4626c 100755
> --- a/tools/hook-dhclient
> +++ b/tools/hook-dhclient
> @@ -1,9 +1,24 @@
> #!/bin/sh
> # This script writes DHCP lease information into the cloud-init run directory
> # It is sourced,
Diff comments:
> diff --git a/tools/hook-dhclient b/tools/hook-dhclient
> index d099979..6a4626c 100755
> --- a/tools/hook-dhclient
> +++ b/tools/hook-dhclient
> @@ -1,9 +1,24 @@
> #!/bin/sh
> # This script writes DHCP lease information into the cloud-init run directory
> # It is sourced,
Lars Kellogg-Stedman has proposed merging
~larsks/cloud-init:feature/move-to-git into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/300953
This is set of changes
Diff comments:
> === modified file 'cloudinit/stages.py'
> --- cloudinit/stages.py 2016-06-10 21:22:17 +
> +++ cloudinit/stages.py 2016-07-21 18:53:48 +
> @@ -808,31 +808,43 @@
> def run_section(self, section_name):
> raw_mods = self._read_modules(section_name)
Diff comments:
> === added file 'cloudinit/cmd/dhclient_hook.py'
> --- cloudinit/cmd/dhclient_hook.py1970-01-01 00:00:00 +
> +++ cloudinit/cmd/dhclient_hook.py2016-07-08 14:29:22 +
> @@ -0,0 +1,56 @@
> +import os
> +from cloudinit import stages
> +import json
> +from cloudinit
I added a bunch of minor comments. I'm going to try to find some time to
actually test things out some time this week.
Diff comments:
> === added file 'cloudinit/cmd/dhclient_hook.py'
> --- cloudinit/cmd/dhclient_hook.py1970-01-01 00:00:00 +
> +++ cloudinit/cmd/dhclient_hook.py
Lars Kellogg-Stedman has proposed merging
lp:~larsks/cloud-init/fix-systemd-detection into lp:cloud-init.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1461201 in cloud-init: Check for systemd (in distros/rhel.py) is
fragile
https://bugs.launchpad.net
31 matches
Mail list logo
