[Cloud-init-dev] [Merge] ~smoser/cloud-init:tools/bddeb-reuse-tarball into cloud-init:master

2018-04-26 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:tools/bddeb-reuse-tarball into cloud-init:master. Commit message: tools: Re-use the orig tarball in packages/bddeb if it is around. If you built packages with 'bddeb', each time it would create a new tarball with make-tarball. I

[Cloud-init-dev] [Merge] ~smoser/cloud-init:tools/bddeb-per-release-suffix-in-version into cloud-init:master

2018-04-26 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:tools/bddeb-per-release-suffix-in-version into cloud-init:master. Commit message: tools: Support adding a release suffix through packages/bddeb. bddeb already supported passing in a '--release' and that would get into the changelog

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/lp-1766287-detect-unstable-names into cloud-init:master

2018-04-25 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index 8005454..d8f7dfa 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -107,6 +107,13 @@ def is_bond(devname): > return os.path.exists(sys_dev_path(devname, "bonding")) >

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/lp-1766287-run-after-udev-settle-service into cloud-init:master

2018-04-25 Thread Scott Moser
network config by ifindex would be insane. it potentially changes every boot. -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/344198 Your team cloud-init commiters is requested to review the proposed merge of ~raharper/cloud-init:fix/lp-1766287-run-after-udev-settle-se

[Cloud-init-dev] [Merge] ~smoser/cloud-init:doc/softlayer-improve-doc-in-datasource into cloud-init:master

2018-04-25 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:doc/softlayer-improve-doc-in-datasource into cloud-init:master. Commit message: IBMCloud: improve documentation in datasource. This adds information to the IBMCloud datasource describing the 6 different scenarios that it is expected to handle

[Cloud-init-dev] [Merge] ~smoser/cloud-init:doc/softlayer-improve-doc-in-datasource into cloud-init:master

2018-04-25 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:doc/softlayer-improve-doc-in-datasource into cloud-init:master has been updated. Commit message changed to: IBMCloud: improve documentation in datasource. This adds information to the IBMCloud datasource describing the 6 different scenarios that it is e

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1766711-add-iproute2-depends into cloud-init:master

2018-04-24 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1766711-add-iproute2-depends into cloud-init:master. Commit message: packages/debian/control.in: add missing dependency on iproute2. Ubuntu minimal images do not have iproute2, so correctly identify our dependency on it. LP: #1766711

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-17661711-add-iproute2-depends into cloud-init:ubuntu/devel

2018-04-24 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/devel-17661711-add-iproute2-depends into cloud-init:ubuntu/devel. Commit message: debian/control: add missing dependency on iproute2. Ubuntu minimal images do not have iproute2, so correctly identify our dependency on it. LP: #1766711

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-isc-dhcp-client-fix into cloud-init:ubuntu/devel

2018-04-24 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/devel-isc-dhcp-client-fix into cloud-init:ubuntu/devel. Commit message: debian/control: add missing dependency on isc-dhcp-client. Replace Build-Depends with Depends. The Build-Depends was incorrectly added under bug 1759307. LP

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1766287-gce-nic-rename into cloud-init:master

2018-04-24 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1766287-gce-nic-rename into cloud-init:master. Commit message: net: apply any needed renames after writing network config. There is a race condition that can be reached if we do: a.) select network device as fallback b.) rename network

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1404745-growfs-freebsd-y into cloud-init:master

2018-04-24 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1404745-growfs-freebsd-y into cloud-init:master. Commit message: FreeBSD: Invoke growfs on ufs filesystems such that it does not prompt. By default, FreeBSD's growfs runs interactively asking a question which can be mitigated using th

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1404745-growfs-freebsd-y into cloud-init:master

2018-04-24 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/1404745-growfs-freebsd-y into cloud-init:master has been updated. Commit message changed to: FreeBSD: Invoke growfs on ufs filesystems such that it does not prompt. By default, FreeBSD's growfs runs interactively asking a question which can be mitiga

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1404745-growfs-freebsd-y into cloud-init:master

2018-04-24 Thread Scott Moser
Harm, I've marked you as the author of this commit. Its really just a copy of what you did at: https://code.launchpad.net/~harmw/cloud-init/growfs-gpart-fixes_for_fbsd/+merge/246075 If for some reason you object, please say so. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+m

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1766302-show-nics-not-up into cloud-init:master

2018-04-23 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1766302-show-nics-not-up into cloud-init:master. Commit message: netinfo: fix netdev_pformat when a nic does not have an address assigned. The last set of changes to netdev_pformat ended up dropping the output of devices that were not up

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ds-identify-smartos-is-container into cloud-init:master

2018-04-20 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/ds-identify-smartos-is-container into cloud-init:master has been updated. Commit message changed to: ds-identify: recognize container-other as a container, test SmartOS. In playing with a SmartOS container I found that ds-identify did not identify th

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ds-identify-smartos-is-container into cloud-init:master

2018-04-20 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/ds-identify-smartos-is-container into cloud-init:master. Commit message: ds-identify: recognize container-other as a container, test SmartOS. In playing with a SmartOS container I found that ds-identify did not identify the container there

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/smartos-container-nics-have-own-mac into cloud-init:master

2018-04-20 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/smartos-container-nics-have-own-mac into cloud-init:master. Commit message: SmartOS: fix get_interfaces for nics that do not have addr_assign_type. When attempting to apply network configuration for SmartOS's container platform,

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ds-identify-smartos-is-container into cloud-init:master

2018-04-20 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/ds-identify-smartos-is-container into cloud-init:master has been updated. Commit message changed to: ds-identify: recognize container-other as a container, test SmartOS. In playing with a SmartOS container I found that ds-identify did not identify th

Re: [Cloud-init-dev] [Merge] ~mgerdts/cloud-init:lp1765801 into cloud-init:master

2018-04-20 Thread Scott Moser
I'm not sure how I feel about this. Updating networking per the metadata service on reboot is *better* in this case than only doing it once. But then we potentially step on user changes. We do plan to have "hotplug" (or *some-event* based) updating of networking information. The ultimate goal b

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/jsonschema-follow-on into cloud-init:master

2018-04-20 Thread Scott Moser
I agree... I was tempted to do that. I'll go ahead and use the mixin you suggesetd. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343609 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:cleanup/jsonschema-follow-on into cl

Re: [Cloud-init-dev] [Merge] ~vkuznets/cloud-init:dhcp6_only into cloud-init:master

2018-04-19 Thread Scott Moser
Hi, Thank you for contributing to cloud-init. To contribute, you must sign the Canonical Contributor License Agreement (CLA) [1]. If you have already signed it as an individual, your Launchpad user will be listed in the contributor-agreement-canonical launchpad group [2]. Unfortunately there i

[Cloud-init-dev] [Merge] ~vkuznets/cloud-init:dhcp6_only into cloud-init:master

2018-04-19 Thread Scott Moser
The proposal to merge ~vkuznets/cloud-init:dhcp6_only into cloud-init:master has been updated. Commit message changed to: sysconfig: dhcp6 subnet type should not imply dhcpv4 BOOTPROTO=dhcp in sysconfig enables DHCPv4 and we should not do this implicitly when 'dhcp6' subnet is specified. In cas

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/schema-raise-import-error-if-validate-strict into cloud-init:master

2018-04-19 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:cleanup/schema-raise-import-error-if-validate-strict into cloud-init:master has been updated. Description changed to: This needs https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343609 For more details, see: https://code.launchpad.

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/schema-raise-import-error-if-validate-strict into cloud-init:master

2018-04-19 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/schema-raise-import-error-if-validate-strict into cloud-init:master. Commit message: schema: in validation, raise ImportError if strict but no jsonschema. validate_cloudconfig_schema with strict=True would not actually validate if

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/jsonschema-follow-on into cloud-init:master

2018-04-19 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/jsonschema-follow-on into cloud-init:master. Commit message: schema: in validation, raise ImportError if strict but no jsonschema. validate_cloudconfig_schema with strict=True would not actually validate if there was no jsonschema

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1764264-schema-runcmd-is-not-unique into cloud-init:master

2018-04-18 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:bug/1764264-schema-runcmd-is-not-unique into cloud-init:master. Commit message: Schema: do not warn on duplicate items in commands. runcmd, bootcmd, snap/commands, ubuntu-advantage/commands would log warning (and fail if strict) on duplicate

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into cloud-init:master

2018-04-17 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into cloud-init:master has been updated. Commit message changed to: pylint: pay attention to unused variable warnings. This just enables warnings produced by pylint for unused warnings (W0612), and fixes the

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into cloud-init:master

2018-04-17 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/pylint-respect-W0612-unused-variable into cloud-init:master. Commit message: pay attention to W0621 Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into cloud-init:master

2018-04-17 Thread Scott Moser
one useful thougt. Diff comments: > diff --git a/cloudinit/netinfo.py b/cloudinit/netinfo.py > index 993b26c..a8c7f7a 100644 > --- a/cloudinit/netinfo.py > +++ b/cloudinit/netinfo.py > @@ -18,18 +20,89 @@ from cloudinit.simpletable import SimpleTable > LOG = logging.getLogger() > > > -def n

[Cloud-init-dev] [Merge] ~mgerdts/cloud-init:lp1763511 into cloud-init:master

2018-04-17 Thread Scott Moser
The proposal to merge ~mgerdts/cloud-init:lp1763511 into cloud-init:master has been updated. Commit message changed to: DataSourceSmartOS: ephemeral drive should default to ext4 ext3 is not able to support file system sizes that are needed in Joyent's cloud. For the default block size of 4k, t

[Cloud-init-dev] [Merge] ~mgerdts/cloud-init:lp1763511 into cloud-init:master

2018-04-17 Thread Scott Moser
The proposal to merge ~mgerdts/cloud-init:lp1763511 into cloud-init:master has been updated. Commit message changed to: DataSourceSmartOS: ephemeral drive should default to ext4 ext3 is not able to support file system sizes that are needed in Joyent's cloud. This changes the default file syste

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1677205-eol-on-sshd_config into cloud-init:master

2018-04-16 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/config/cc_set_passwords.py > b/cloudinit/config/cc_set_passwords.py > index bb24d57..3e5ba4c 100755 > --- a/cloudinit/config/cc_set_passwords.py > +++ b/cloudinit/config/cc_set_passwords.py > @@ -68,16 +68,49 @@ import re > import sys > > from cloudin

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1677205-eol-on-sshd_config into cloud-init:master

2018-04-13 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/1677205-eol-on-sshd_config into cloud-init:master has been updated. Commit message changed to: set_passwords: Add newline to end of sshd config, only restart if updated. This admittedly does a fairly extensive re-factor to simply add a newline to the

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1677205-eol-on-sshd_config into cloud-init:master

2018-04-13 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1677205-eol-on-sshd_config into cloud-init:master. Commit message: set_passwords: Add newline to end of sshd config, only restart if updated. This admittedly does a fairly extensive re-factor to simply add a newline to the end of

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1677205-eol-on-sshd_config into cloud-init:master

2018-04-13 Thread Scott Moser
Increases test coverage: * ssh_util from 60 -> 70% * cc_set_passwords: 6% -> 27% -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/343246 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/1677205-eol-on-sshd_config into clo

Re: [Cloud-init-dev] [Merge] ~mgerdts/cloud-init:lp1667735 into cloud-init:master

2018-04-12 Thread Scott Moser
I like it. Good work. I've pointed the c-i bot at it, so it will comment soon. https://jenkins.ubuntu.com/server/job/cloud-init-ci/1005/ there are 2 tiny things inline. Diff comments: > diff --git a/cloudinit/sources/DataSourceSmartOS.py > b/cloudinit/sources/DataSourceSmartOS.py > index 86bf

[Cloud-init-dev] [Merge] ~mgerdts/cloud-init:lp1667735 into cloud-init:master

2018-04-12 Thread Scott Moser
The proposal to merge ~mgerdts/cloud-init:lp1667735 into cloud-init:master has been updated. Commit message changed to: DataSourceSmartOS: fix hang when metadata service is down If the metadata service in the host is down while a guest that uses DataSourceSmartOS is booting, the request from th

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/read_file_or_url-contents-should-be-text into cloud-init:master

2018-04-12 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/read_file_or_url-contents-should-be-text into cloud-init:master. Commit message: read_file_or_url: move to url_helper, fix bug in its FileResponse. The result of a read_file_or_url on a file and on a url would differ in behavior. str

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/templater-with-non-ascii into cloud-init:master

2018-04-12 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/templater-with-non-ascii into cloud-init:master. Commit message: renderer: support unicode in render_from_file. If a file passed to render_from_file had non-ascii text then jinja in python2 would decode as ascii, which would cause

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:feature/update-ntp-spec into cloud-init:master

2018-04-11 Thread Scott Moser
Update the commit message on the merge proposal tomake sure it is in sync with the current code. - I think the '_set_preferred_ntp_client' client is kind of wierd. could we get the same function with an attribute ? Then it would only be called if used. Rather than being called on init. - 'ha

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into cloud-init:master

2018-04-11 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/netinfo.py b/cloudinit/netinfo.py > index 993b26c..081f7b4 100644 > --- a/cloudinit/netinfo.py > +++ b/cloudinit/netinfo.py > @@ -18,18 +21,81 @@ from cloudinit.simpletable import SimpleTable > LOG = logging.getLogger() > > > -def netdev_info(empty=""

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/fix-tip-pycodestyle-invalid-escape-sequences into cloud-init:master

2018-04-11 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/fix-tip-pycodestyle-invalid-escape-sequences into cloud-init:master. Commit message: pycodestyle: Fix invalid escape sequences in string literals. Python has deprecated these invalid string literals now https://bugs.python.org

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into cloud-init:master

2018-04-10 Thread Scott Moser
some other patches that i think make this a bit nicer. http://paste.ubuntu.com/p/4Px2hrqtG6/ http://paste.ubuntu.com/p/GtrvNcYhzc/ -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342428 Your team cloud-init commiters is requested to review the proposed merge of ~chad

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into cloud-init:master

2018-04-10 Thread Scott Moser
netdev_cidr_to_mask is like net_prefix_to_ipv4_mask, right? and then.. the use of 'cidr' there is at least inconsistent with other places in cloud-init. generally I think 'cidr' is / where this fucntion just takes the 'prefix' part. -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cl

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into cloud-init:master

2018-04-10 Thread Scott Moser
"where possible" What does that mean? -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342428 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:net-tools-deprecation-plus-review-comments into cloud-init:master. ___

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/apport-add-ibmcloud-lxd into cloud-init:master

2018-04-10 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/apport-add-ibmcloud-lxd into cloud-init:master. Commit message: Apport: add IBM Cloud and LXD to list of clouds. When filing a bug with apport, this allows the user to choose LXD or IBM Cloud. Requested reviews: cloud-init commiters

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-fix-enable-ibmcloud into cloud-init:ubuntu/devel

2018-04-10 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/devel-fix-enable-ibmcloud into cloud-init:ubuntu/devel. Commit message: update changelog Requested reviews: Server Team CI bot (server-team-bot): continuous-integration roche philippe (roche-phil) cloud-init commiters (cloud-init

Re: [Cloud-init-dev] [Merge] ~d-info-e/cloud-init:fix-user-group-doc into cloud-init:master

2018-03-29 Thread Scott Moser
I'm pretty sure it does work both ways. so yeah, i suggest we change everything there to have _. -- https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/342251 Your team cloud-init commiters is requested to review the proposed merge of ~d-info-e/cloud-init:fix-user-group-doc

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/artful-drop-new-upstream-snapshot into cloud-init:ubuntu/artful

2018-03-28 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/artful-drop-new-upstream-snapshot into cloud-init:ubuntu/artful. Commit message: debian/new-upstream-snapshot: remove from package. This is no longer managed in the packaging branches. Requested reviews: cloud-init commiters (cloud

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/xenial-drop-new-upstream-snapshot into cloud-init:ubuntu/xenial

2018-03-28 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/xenial-drop-new-upstream-snapshot into cloud-init:ubuntu/xenial. Commit message: update changelog Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-drop-new-upstream-snapshot into cloud-init:ubuntu/devel

2018-03-28 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/devel-drop-new-upstream-snapshot into cloud-init:ubuntu/devel. Commit message: update changelog Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud

[Cloud-init-dev] [Merge] ~d-info-e/cloud-init:fix-openstack-doc into cloud-init:master

2018-03-28 Thread Scott Moser
The proposal to merge ~d-info-e/cloud-init:fix-openstack-doc into cloud-init:master has been updated. Commit message changed to: doc: Fix links in OpenStack datasource documentation. Fix link to external openstack resource and to internal vendor data. LP: #1721660 For more details, see: https

Re: [Cloud-init-dev] [Merge] ~d-info-e/cloud-init:fix-user-group-doc into cloud-init:master

2018-03-28 Thread Scott Moser
this one is harder than it should be. _normalize_users ends up fixing the '-' to '_' in all those before 'distro.create_user' gets called. So either actually works. Documentation and implementation in cloud-init have unfortunately been inconsistent with '-' versus '_'. We should absolutely striv

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/hetzner-ds-check-vendor into cloud-init:master

2018-03-27 Thread Scott Moser
just a quick test on a stock image that the read_dmi-data was right: p[ytroot@smtest1 ~ # python3 Python 3.5.2 (default, Nov 23 2017, 16:37:01) [GCC 5.4.0 20160609] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from cloudinit import util >>> util.read_dmi_dat

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/hetzner-ds-check-vendor into cloud-init:master

2018-03-27 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/hetzner-ds-check-vendor into cloud-init:master. Commit message: Hetzner: Exit early if dmi system-manufacturer is not Hetzner. This takes the same basic check that is in ds-identify. If the DMI system manufacturer (aka sys_vendor) is not

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-27 Thread Scott Moser
I filed a bug https://bugs.launchpad.net/cloud-init/+bug/1759324 to handle "make network rendering cleanup after itself." -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/342102 Your team cloud-init commiters is requested to review the proposed merge of ~raharper/cloud

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-1759307-add-depends-isc-dhcp-client into cloud-init:ubuntu/devel

2018-03-27 Thread Scott Moser
upstrem packaging merge proposal at https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342215 -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/342214 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:ubuntu/dev

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/1759307-add-depends-isc-dhcp-client into cloud-init:master

2018-03-27 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/1759307-add-depends-isc-dhcp-client into cloud-init:master. Commit message: Add missing dependency on isc-dhcp-client to trunk ubuntu packaging. This just correctly adds the missing dependency on isc-dhcp-client. That package is used via

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-1759307-add-depends-isc-dhcp-client into cloud-init:ubuntu/devel

2018-03-27 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/devel-1759307-add-depends-isc-dhcp-client into cloud-init:ubuntu/devel. Commit message: Add missing dependency on isc-dhcp-client. This just correctly adds the missing dependency on isc-dhcp-client. That package is used via 'dhc

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-handle-global-static-routes into cloud-init:master

2018-03-27 Thread Scott Moser
one useful comment/question and some nits. Diff comments: > diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py > index 39d89c4..87fb96e 100644 > --- a/cloudinit/net/sysconfig.py > +++ b/cloudinit/net/sysconfig.py > @@ -550,6 +550,26 @@ class Renderer(renderer.Renderer): >

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:puppet-flakes into cloud-init:master

2018-03-26 Thread Scott Moser
The proposal to merge ~chad.smith/cloud-init:puppet-flakes into cloud-init:master has been updated. Commit Message changed to: add comment about moving to RawConfigParser.read_file when we drop py 2.7 support For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-i

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:puppet-flakes into cloud-init:master

2018-03-26 Thread Scott Moser
The proposal to merge ~chad.smith/cloud-init:puppet-flakes into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/342154 -- Your team cloud-init commiters is requested to revie

Re: [Cloud-init-dev] [Merge] ~kgarloff/cloud-init:detect_otc_as_openstack_ds into cloud-init:master

2018-03-25 Thread Scott Moser
Kurt. Looks good. thanks. I still have to think about this more. But you've done the right bits in the MP. Thanks. -- https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341845 Your team cloud-init commiters is requested to review the proposed merge of ~kgarloff/cloud-init

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-restructure-ssh into cloud-init:master

2018-03-23 Thread Scott Moser
Diff comments: > diff --git a/tests/cloud_tests/platforms/instances.py > b/tests/cloud_tests/platforms/instances.py > index 3bad021..fa392b7 100644 > --- a/tests/cloud_tests/platforms/instances.py > +++ b/tests/cloud_tests/platforms/instances.py > @@ -87,7 +87,12 @@ class Instance(TargetBase):

[Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-restructure-ssh into cloud-init:master

2018-03-23 Thread Scott Moser
The proposal to merge ~powersj/cloud-init:cii-restructure-ssh into cloud-init:master has been updated. Commit Message changed to: tests: restructure SSH and initial connections The SSH function was retrying and waiting for SSH for over an hour when an SSH connection was failing to be establishe

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/add-ibmcloud-to-settings into cloud-init:master

2018-03-23 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/add-ibmcloud-to-settings into cloud-init:master. Commit message: Enable IBMCloud datasource in settings.py. This just got missed in the IBMCloud datasource addition. Add it to the builtin list of datasources. Requested reviews: cloud

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/consistent-exception_cb into cloud-init:master

2018-03-23 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/consistent-exception_cb into cloud-init:master. Commit message: Make exception_cb consistent in readurl and wait_for_url. This message needs improving. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-drop-grub-legacy-ec2 into cloud-init:ubuntu/devel

2018-03-23 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/devel-drop-grub-legacy-ec2 into cloud-init:ubuntu/devel. Commit message: Separate the grub-legacy-ec2 package. This drops the grub-legacy-ec2 package from cloud-init. LP: #1758420 Requested reviews: cloud-init commiters (cloud-init

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master

2018-03-23 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master has been updated. Commit Message changed to: tests: remove jsonschema from xenial tox environment. Ubuntu 16.04 (xenial) does not have jsonschema installed by default. As it is listed in

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master

2018-03-23 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master has been updated. Description changed to: related https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341997 to test that this works: tox-venv xenial pip install jsonsc

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master

2018-03-23 Thread Scott Moser
Note that the failure jenkins saw is by design. Trunk is busted and this exposes that fact. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341995 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:cleanup/remove-json-schema-fro

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ec2-invert-exception_cb-logic into cloud-init:master

2018-03-23 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/ec2-invert-exception_cb-logic into cloud-init:master. Commit message: ec2: Adjust ec2 datasource after exception_cb change. The recent change to exception_cb missed this caller. The result was a slow test. Requested reviews: cloud-init

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/fix-schematests-without-json-schema into cloud-init:master

2018-03-23 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/fix-schematests-without-json-schema into cloud-init:master. Commit message: tests: Fix newly added schema unit tests to skip if no jsonschema. The recently added snap and ubuntu_advantage modules had unit tests that exercised jsonschema

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master

2018-03-23 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master has been updated. Description changed to: related https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341997 For more details, see: https://code.launchpad.net/~smoser/cl

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/fix-schematests-without-json-schema into cloud-init:master

2018-03-23 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:fix/fix-schematests-without-json-schema into cloud-init:master has been updated. Description changed to: related related https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341995 For more details, see: https://code.launchpad.net/~smos

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master

2018-03-23 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:cleanup/remove-json-schema-from-tox-xenial into cloud-init:master. Commit message: tests: remove jsonschema from tox environment. Add the helper tools/pipremove that removes pip packages. Then use that to remove jsonschema without noise of

Re: [Cloud-init-dev] [Merge] ~kgarloff/cloud-init:detect_otc_as_openstack_ds into cloud-init:master

2018-03-23 Thread Scott Moser
Kurt I suspect you didn't push without --force. you have to push --force because you have a non-fastforward locally after the rebase. -- https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341845 Your team cloud-init commiters is requested to review the proposed merge of ~kg

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-opensuse into cloud-init:master

2018-03-22 Thread Scott Moser
marked this as work in progress. i'd like to have a generic tool that spit did what run-centos did but for opensuse, centos, anything else. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329650 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-opensuse into cloud-init:master

2018-03-22 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:feature/run-opensuse into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329650 -- Your team cloud-init commiters is requested t

Re: [Cloud-init-dev] [Merge] ~kgarloff/cloud-init:detect_otc_as_openstack_ds into cloud-init:master

2018-03-22 Thread Scott Moser
the other is merged now, so you can rebase and push then the diff will get updated. Diff comments: > diff --git a/tools/ds-identify b/tools/ds-identify > index e3f93c9..9c69786 100755 > --- a/tools/ds-identify > +++ b/tools/ds-identify > @@ -875,23 +875,29 @@ dscheck_GCE() { > dscheck_OpenStac

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master

2018-03-22 Thread Scott Moser
addressed feedbacks. Diff comments: > diff --git a/cloudinit/sources/DataSourceIBMCloud.py > b/cloudinit/sources/DataSourceIBMCloud.py > new file mode 100644 > index 000..fa6cef0 > --- /dev/null > +++ b/cloudinit/sources/DataSourceIBMCloud.py > @@ -0,0 +1,311 @@ > +# This file is part of cl

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master

2018-03-22 Thread Scott Moser
addressed feedbacks Diff comments: > diff --git a/cloudinit/sources/DataSourceIBMCloud.py > b/cloudinit/sources/DataSourceIBMCloud.py > new file mode 100644 > index 000..99ec4c2 > --- /dev/null > +++ b/cloudinit/sources/DataSourceIBMCloud.py > @@ -0,0 +1,275 @@ > +# This file is part of clo

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master

2018-03-22 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master has been updated. Description changed to: TODO: * we could further limit the search for ibmcloud datasource to devices   that have a LABEL=SWAP-xvdb1.   /dev/xvdb1: LABEL="SWAP-xvdb1" UUID="d51fcca0-6b10-

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master

2018-03-22 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master has been updated. Commit Message changed to: IBMCloud: Initial IBM Cloud datasource. This adds a specific IBM Cloud datasource. IBM Cloud is identified by: a.) running on xen b.) one of a LABEL=METADAT

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master

2018-03-22 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master has been updated. Description changed to: TODO: * we could further limit the search for ibmcloud datasource to devices that have a LABEL=SWAP-xvdb1. /dev/xvdb1: LABEL="SWAP-xvdb1" UUID="d51fcca0-6b10

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master

2018-03-22 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master has been updated. Description changed to: TODO: * we could further limit the search for ibmcloud datasource to devices   that have a LABEL=SWAP-xvdb1.   /dev/xvdb1: LABEL="SWAP-xvdb1" UUID="d51fcca0-6b10-

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/lp-1756471-open-telekom into cloud-init:master

2018-03-21 Thread Scott Moser
Diff comments: > diff --git a/tests/unittests/test_ds_identify.py > b/tests/unittests/test_ds_identify.py > index 9c5628e..ed654c4 100644 > --- a/tests/unittests/test_ds_identify.py > +++ b/tests/unittests/test_ds_identify.py > @@ -502,6 +507,12 @@ VALID_CFG = { > 'policy_dmi': POLICY_

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/lp-1756471-open-telekom into cloud-init:master

2018-03-21 Thread Scott Moser
taken from https://code.launchpad.net/~kgarloff/cloud-init/+git/cloud-init/+merge/341845 with a unit test added for ds-identify. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341851 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cl

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/lp-1756471-open-telekom into cloud-init:master

2018-03-21 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/lp-1756471-open-telekom into cloud-init:master. Commit message: Identify OpenTelekomCloud Xen as OpenStack DS. Open Telekom Cloud gen1 (Xen) hosts do not provide nova product names in DMI but Xen HVM domU. They can however be safely

Re: [Cloud-init-dev] [Merge] ~kgarloff/cloud-init:detect_otc_as_openstack_ds into cloud-init:master

2018-03-21 Thread Scott Moser
Kurt, I put up just the 'Identify OpenTelecomcloud' commit as https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341851 and added a ds-identify unit test for it. After that lands (I hope shortly) we can look at the second one here. -- https://code.launchpad.net/~kgarloff/clou

Re: [Cloud-init-dev] [Merge] ~kgarloff/cloud-init:detect_otc_as_openstack_ds into cloud-init:master

2018-03-21 Thread Scott Moser
Hi Kurt, Thanksk for the merge proposal. I'd like to make a suggestion a.) split the 'a' and 'b' to different merge requests. 'a' is straight forward win b.) could have side effects. we can discuss that more on its own MP, but I think that as it is right now config-drive would always end up t

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master

2018-03-20 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:feature/datasource-ibmcloud into cloud-init:master. Commit message: IBMCloud: Initial IBM Cloud datasource. This adds a specific IBM Cloud datasource. It utilizes the openstack config drive reader to read files off of the attached disks

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-enable-hetzner into cloud-init:ubuntu/devel

2018-03-19 Thread Scott Moser
Related hetzner datasource branch: https://code.launchpad.net/~lp-markusschade/cloud-init/+git/cloud-init/+merge/338439 -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/341679 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:u

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-enable-hetzner into cloud-init:ubuntu/devel

2018-03-19 Thread Scott Moser
The proposal to merge ~smoser/cloud-init:ubuntu/devel-enable-hetzner into cloud-init:ubuntu/devel has been updated. Commit Message changed to: debian/cloud-init.templates: Enable Hetzner Cloud datasource. For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merg

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/devel-enable-hetzner into cloud-init:ubuntu/devel

2018-03-19 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/devel-enable-hetzner into cloud-init:ubuntu/devel. Commit message: debian/cloud-init.templates: Enable Hetzner Cloud datasource. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https

[Cloud-init-dev] [Merge] ~sw37th/cloud-init:opennebula_netconf_v2 into cloud-init:master

2018-03-19 Thread Scott Moser
The proposal to merge ~sw37th/cloud-init:opennebula_netconf_v2 into cloud-init:master has been updated. Commit Message changed to: OpenNebula: Update network to return v2 config rather than ENI. OpenNebulaNetwork.gen_conf() was previously returning ENI format. This is updated to return netplan/

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/ubuntu-advantage-module into cloud-init:master

2018-03-16 Thread Scott Moser
some quick review questions. Diff comments: > diff --git a/cloudinit/config/cc_ubuntu_advantage.py > b/cloudinit/config/cc_ubuntu_advantage.py > new file mode 100644 > index 000..e941cc0 > --- /dev/null > +++ b/cloudinit/config/cc_ubuntu_advantage.py > @@ -0,0 +1,217 @@ > +# Copyright (C) 2

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:feature/update-ntp-spec into cloud-init:master

2018-03-16 Thread Scott Moser
Diff comments: > diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py > index cbd0237..099b8d8 100644 > --- a/cloudinit/config/cc_ntp.py > +++ b/cloudinit/config/cc_ntp.py > @@ -103,6 +171,9 @@ def handle(name, cfg, cloud, log, _args): > ntp_cfg = cfg['ntp'] > if ntp_cf

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/snap-module into cloud-init:master

2018-03-16 Thread Scott Moser
We can probably just ditch the squashfuse stuff now. that is slated to be fixed "real soon now" under bug 1756173. Its not our problem, and this all works as long as snapd works. -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/338366 Your team cloud-init commiters is r

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/2.6-pylint-happy-with-assert-raises-regex into cloud-init:master

2018-03-16 Thread Scott Moser
Scott Moser has proposed merging ~smoser/cloud-init:fix/2.6-pylint-happy-with-assert-raises-regex into cloud-init:master. Commit message: tests: Make pylint happy and fix python2.6 uses of assertRaisesRegex. Older unittest2.TestCase (as seen in CentOS 6) do not have an assertRaisesRegex method

<    1   2   3   4   5   6   7   8   9   10   >