Re: [Cloud-init-dev] [Merge] ~lp-markusschade/cloud-init:hetznercloud_ds into cloud-init:master

This looks pretty good, but we need some unit test on it. some comments inline. I know it can be annoying when someone says "you should refactor this". We can help you, but we just added the EphemeralIPv4Network with this use case in mind, so it'd be good to use it. Diff comments: > diff --git

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/ds-identify-fix-parse-blkid-export into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/ds-identify-fix-parse-blkid-export into cloud-init:master. Commit message: ds-identify: Fix searching for iso9660 OVF cdroms. This fixes a bug in parsing of 'blkid -o export' output. The result of the bug meant that DI_ISO9660_DEVS did

Re: [Cloud-init-dev] [Merge] ~rski/cloud-init:puppet_4 into cloud-init:master

Verified that intracom telecom signed the cla. Thank you. -- https://code.launchpad.net/~rski/cloud-init/+git/cloud-init/+merge/312284 Your team cloud-init commiters is requested to review the proposed merge of ~rski/cloud-init:puppet_4 into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:setPerm into cloud-init:master

Can we change the bug reference in commit message: - https://bugzilla.suse.com/show_bug.cgi?id=1080595 + boo: 1080595 And then also please update description to SUSE: Description here -- https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/337666 Your team cloud-init

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/tools-run-centos-use-git-clone into cloud-init:master

Josh, please see new commit. I think this is sane. On Mon, Feb 12, 2018 at 12:03 PM, Scott Moser <ssmoser2+ubu...@gmail.com> wrote: > You're correct that it will not bring in un-committed code. I can address > that. I dont think its all that big of a deal really, the g

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/tools-run-centos-use-git-clone into cloud-init:master

You're correct that it will not bring in un-committed code. I can address that. I dont think its all that big of a deal really, the git work flow is generally "git commit"... git ammend. other parts of cloud-init also do not pick up uncommitted changes. On Mon, Feb 12, 2018 at 11:51 AM,

Re: [Cloud-init-dev] [recipe build #1529991] of ~cloud-init-dev cloud-init-daily-xenial in xenial: Failed to upload

I dont understand this failure log. My best guess is the fact that I pushed '--force' to add a bug number to the commit message after merging (and pushing) chad's fix for 1748354. On Sat, Feb 10, 2018 at 5:03 PM, wrote: > * State: Failed to upload > * Recipe:

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:fix-instance-identity-upgrade-path into cloud-init:master

The proposal to merge ~chad.smith/cloud-init:fix-instance-identity-upgrade-path into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/337475 -- Your team cloud-init commiters

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:fix-instance-identity-upgrade-path into cloud-init:master

The proposal to merge ~chad.smith/cloud-init:fix-instance-identity-upgrade-path into cloud-init:master has been updated. Status: Merged => Approved For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/337475 -- Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~mgerdts/cloud-init:bug-1746605 into cloud-init:master

I have some questions inline. over all this is really good. Thank you, Mike. The test is neat, and I'm sure it was useful for you in fixing this and recreating. I'm a bit worried about it though because a.) its not going to run for most people or in c-i, making it prone to bit-rot. b.) I think

[Cloud-init-dev] [Merge] ~mgerdts/cloud-init:bug-1746605 into cloud-init:master

The proposal to merge ~mgerdts/cloud-init:bug-1746605 into cloud-init:master has been updated. Commit Message changed to: DataSourceSmartOS: add locking and retries cloud-init and mdata-get each have their own implementation of the SmartOS metadata protocol. If cloud-init and other services

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1747070-snapubuntu-core-seed into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1747070-snapubuntu-core-seed into cloud-init:master. Commit message: ds-identify: check /writable/system-data/ for nocloud seed. Ubuntu core seeds information to nocloud via a bind-mount of /writable/system-data/var/lib/cloud over /var/lib

[Cloud-init-dev] [Merge] ~tlashchova/cloud-init:fix-bug-add-unittest into cloud-init:master

You have been requested to review the proposed merge of ~tlashchova/cloud-init:fix-bug-add-unittest into cloud-init:master. For more details, see: https://code.launchpad.net/~tlashchova/cloud-init/+git/cloud-init/+merge/337003 -- Your team cloud-init commiters is requested to review the

Re: [Cloud-init-dev] [Merge] ~tlashchova/cloud-init:fix-bug-add-unittest into cloud-init:master

Tatiana, I'll get our c-i bot to test your branch, and pending success there, looks good! -- https://code.launchpad.net/~tlashchova/cloud-init/+git/cloud-init/+merge/337003 Your team cloud-init commiters is requested to review the proposed merge of ~tlashchova/cloud-init:fix-bug-add-unittest

Re: [Cloud-init-dev] [Merge] ~tlashchova/cloud-init:fix-bug-add-unittest into cloud-init:master

improve your commit message, just have a 'messag'e part as well as subject. Ie: Do not write invalid keys to authorized_keys This fixes a bug where invalid keys would sneak into authorized_keys. Diff comments: > diff --git a/cloudinit/ssh_util.py b/cloudinit/ssh_util.py > index

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1745663-use-lxd-console into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1745663-use-lxd-console into cloud-init:master has been updated. Commit Message changed to: tests: add support for logs in with snap and future lxd 3. This puts in place detection for if 'show-log' will work with lxc client, and uses that if

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1745663-use-lxd-console into cloud-init:master

Josh, I added some hackish support for getting log output today. It should work in both snap lxd (tested) and package lxd (untested) if the lxd is local. Right now this only works on a local lxd. I do hope at some point we could point it at a remote, but that is work to do. The first time you

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1745663-use-lxd-console into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1745663-use-lxd-console into cloud-init:master. Commit message: tests: lxd platform replace console log implementation. This disables the '_setup_console_log' path we had for getting a log in lxd. It implements a path that requires

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/cloud-init-network-rename-with-v2 into cloud-init:master

I have some nits there, but I think this looks good. Thanks. Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index a1b0db1..c3a8add 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -275,20 +275,45 @@ def

[Cloud-init-dev] [Merge] ~raharper/cloud-init:fix/cloud-init-network-rename-with-v2 into cloud-init:master

The proposal to merge ~raharper/cloud-init:fix/cloud-init-network-rename-with-v2 into cloud-init:master has been updated. Description changed to: net: accept network-config in netplan format for renaming interfaces net.apply_network_config_names currently only accepts network-config in

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:uninitialized-variables into cloud-init:master

Diff comments: > diff --git a/cloudinit/cmd/status.py b/cloudinit/cmd/status.py > index 3e5d0d0..d7aaee9 100644 > --- a/cloudinit/cmd/status.py > +++ b/cloudinit/cmd/status.py > @@ -93,6 +93,8 @@ def _is_cloudinit_disabled(disable_file, paths): > elif not

Re: [Cloud-init-dev] [Merge] ~rski/cloud-init:puppet_4 into cloud-init:master

Bump? -- https://code.launchpad.net/~rski/cloud-init/+git/cloud-init/+merge/312284 Your team cloud-init commiters is requested to review the proposed merge of ~rski/cloud-init:puppet_4 into cloud-init:master. ___ Mailing list:

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1698669-ds-identify-fujitsu-ovf into cloud-init:master

Diff comments: > diff --git a/tests/unittests/test_ds_identify.py > b/tests/unittests/test_ds_identify.py > index ad6c5cf..31cc622 100644 > --- a/tests/unittests/test_ds_identify.py > +++ b/tests/unittests/test_ds_identify.py > @@ -346,10 +346,12 @@ class TestDsIdentify(CiTestCase): >

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1698669-ds-identify-fujitsu-ovf into cloud-init:master

bah. thoght i had pushed the HACKING change upstream. I have now. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336630 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/1698669-ds-identify-fujitsu-ovf into

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1698669-ds-identify-fujitsu-ovf into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1698669-ds-identify-fujitsu-ovf into cloud-init:master. Commit message: OVF: Extend well-known labels to include OVFENV. Fujitsu Cloud Service attaches a ovf iso transport with a label 'OVFENV'. This seems to be a reasonable value

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/hacking-config-user into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:cleanup/hacking-config-user into cloud-init:master. Commit message: HACKING.rst: mention setting user name and email via git config. Just include mention of setting user name and email when first setting up git. Requested reviews: Server

Re: [Cloud-init-dev] [Merge] ~floriangrignon/cloud-init:log-typo into cloud-init:master

Florian, I merged this in today, but mistakingly let your 'aRkadeFR' name go in (from the git commit message). In the future, please set your real name as the author. (I'm sure this was just oversite). Thanks for your contribution. --

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/read-version-support-worktree into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/read-version-support-worktree into cloud-init:master. Commit message: tools/read-version: Fix read-version when in a git worktree. read-version --json would report bad data when working in a worktree. This is just because in a worktree

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

The proposal to merge ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336366 -- Your team cloud-init commiters is requested

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/test-more-files-collect into cloud-init:master

Diff comments: > diff --git a/tests/cloud_tests/platforms/lxd/instance.py > b/tests/cloud_tests/platforms/lxd/instance.py > index 0d697c0..e9b76a6 100644 > --- a/tests/cloud_tests/platforms/lxd/instance.py > +++ b/tests/cloud_tests/platforms/lxd/instance.py > @@ -29,6 +31,7 @@ class

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/test-more-files-collect into cloud-init:master

The proposal to merge ~smoser/cloud-init:cleanup/test-more-files-collect into cloud-init:master has been updated. Commit Message changed to: tests: Collect script output as binary, collect systemd journal, fix lxd. This adds collection a gzip compressed systemd journal on systemd systems. The

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ntp-test-no-dns into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/ntp-test-no-dns into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336458 -- Your team cloud-init commiters is requested to review

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master

added unit test, updated commit message. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/336497 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master.

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master has been updated. Commit Message changed to: subp: make ProcessExecutionError have expected types in stderr, stdout. When subp raised a ProcessExecutionError, that exception's stderr and stdout might

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/test-more-files-collect into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:cleanup/test-more-files-collect into cloud-init:master. Commit message: tests: Collect script output as binary, collect systemd journal, fix lxd. This adds collection a gzip compressed systemd journal on systemd systems. The file can later

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/subp-exception-with-bytes into cloud-init:master. Commit message: subp: make ProcessExecutionError have expected types in stderr, stdout. When subp raised a ProcessExecutionError, that exception's stderr and stdout might end up being

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ntp-test-no-dns into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/ntp-test-no-dns into cloud-init:master. Commit message: tests: when querying ntp server, do not do dns resolution. Tests run on EC2 would successfully resolve the ipv4 dns address and that caused false positives on failure reports

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ec2-console-as-bytes into cloud-init:master

Diff comments: > diff --git a/tests/cloud_tests/platforms/ec2/platform.py > b/tests/cloud_tests/platforms/ec2/platform.py > index fdb17ba..ba246fe 100644 > --- a/tests/cloud_tests/platforms/ec2/platform.py > +++ b/tests/cloud_tests/platforms/ec2/platform.py > @@ -228,4 +230,28 @@ class

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1742479-no-manual_cache_clean-warning into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1742479-no-manual_cache_clean-warning into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1742479 in cloud-init (Ubuntu): "setting manual_cache_clean causes warning&quo

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-requirements into cloud-init:master

Ultimately I do want some way to "prepare my system to run c-i". As I'm going to deploy a stock instance and then want to do just that. That goal is very similar to what 'read-dependencies --install --test-distro' does, so it seems to make sense to add the functionality there. I'm not bent on

[Cloud-init-dev] [Merge] ~rjschwei/cloud-init:baseNetConfTestSUSE into cloud-init:master

The proposal to merge ~rjschwei/cloud-init:baseNetConfTestSUSE into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333772 -- Your team cloud-init commiters is requested to review

[Cloud-init-dev] [Merge] ~rjschwei/cloud-init:baseNetConfTestSUSE into cloud-init:master

The proposal to merge ~rjschwei/cloud-init:baseNetConfTestSUSE into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/333772 -- Your team cloud-init commiters is requested to

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:azure-no-ifupdown into cloud-init:master

Diff comments: > diff --git a/cloudinit/sources/DataSourceAzure.py > b/cloudinit/sources/DataSourceAzure.py > index e73b57b..a56ced2 100644 > --- a/cloudinit/sources/DataSourceAzure.py > +++ b/cloudinit/sources/DataSourceAzure.py > @@ -591,6 +591,18 @@ def

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-enable-ec2 into cloud-init:master

* (from the commit message). "The default instance type is set to t2.micro. This is the smallest type that will work for both ebs and instance-store." that is not true. per https://aws.amazon.com/ec2/instance-types/ t2.* are 'EBS-only'. * user-data, I think probably you should pass

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-enable-ec2 into cloud-init:master

Diff comments: > diff --git a/.pylintrc b/.pylintrc > index 3ad3692..05a086d 100644 > --- a/.pylintrc > +++ b/.pylintrc > @@ -46,7 +46,7 @@ reports=no > # (useful for modules/projects where namespaces are manipulated during > runtime > # and thus existing member attributes cannot be deduced

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:tip-lint-fixes into cloud-init:master

The proposal to merge ~chad.smith/cloud-init:tip-lint-fixes into cloud-init:master has been updated. Description changed to: lint: Fix lints seen by pylint version 1.8.1. This branch resolves lints seen by pylint revision 1.8.1 and updates our pinned tox pylint dependency used by our tox

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-enable-ec2 into cloud-init:master

Thank you for a good text commit message that makes reading things easier. * t2.micro for default instance type the smallest type that will work for both ebs(ssd) and instance-store from a quick look, m4.large (2 cpu / 8G) at $0.10/hr is the cheapest you can find something that runs on

Re: [Cloud-init-dev] [Merge] ~illfelder/cloud-init:master into cloud-init:master

givin config 'cfg' and distro 'distro' (users, _groups) = ug_util.normalize_users_groups(cfg, distro) (default_user, _user_config) = ug_util.extract_default(users) default_user is then the use name. I think there may be an issue though in that the cfg that the datasource gets is only config

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:release/17.2 into cloud-init:master

Jenkins ran c-i for the previous tip a30a3bb5 cloud-init_17.1-60-ga30a3bb5-1~bddeb_all.deb at cloud-init-ci-nightly https://jenkins.ubuntu.com/server/view/cloud-init/job/cloud-init-ci-nightly/188/ cloud-init-integration-lxd-x

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:release/17.2 into cloud-init:master

I've tested under uvt-kvm with: $ uvt-kvm create sm-b1 release=bionic $ uvt-kvm wait sm-b1 $ uvt-kvm ssh sm-b1 -- dpkg-query --show cloud-init cloud-init 17.1-60-ga30a3bb5-0ubuntu1 $ uvt-kvm ssh sm-b1 -- cat /etc/cloud/build.info $ uvt-kvm ssh sm-b1 -- cat /etc/cloud/build.info

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:release/17.2 into cloud-init:master

I'd like to record tests of this here, and then we'll call this good. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/335233 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:release/17.2 into cloud-init:master.

[Cloud-init-dev] [Merge] ~smoser/cloud-init:release/17.2 into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:release/17.2 into cloud-init:master. Commit message: release 17.2 Bump the version in cloudinit/version.py to be 17.2 and update ChangeLog. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-enable-ec2 into cloud-init:master

i have not gotten all the way thought, but some things in line. thanks Josh! Diff comments: > diff --git a/tests/cloud_tests/platforms/ec2/image.py > b/tests/cloud_tests/platforms/ec2/image.py > new file mode 100644 > index 000..456dda2 > --- /dev/null > +++

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

no tests, but I'm interested in thoughts. We could make 'id_hash' a property since ds_cfg gets stored. Chad I'm interested in your thoughts on this and the unification of storage, how did I affect that? -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/335108 Your team

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master. Commit message: MAAS: add check_instance_id based off oauth tokens. This stores a hash of the OAuth tokens as an 'id' for the maas datasource. Since new instances get

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1712680-maas-use-token-for-check-instance-id into cloud-init:master has been updated. Commit Message changed to: MAAS: add check_instance_id based off oauth tokens. This stores a hash of the OAuth tokens as an 'id' for the maas datasource. Since

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial

The proposal to merge ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial has been updated. Description changed to: ds-identify changed, so the xenial patch that is applied no longer cleanly applies. This fixes daily build recipe failures like:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial

The proposal to merge ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial has been updated. Commit Message changed to: debian/patches/ds-identify-behavior-xenial.patch: refresh patch upstream changes to ds-identify made this not apply cleanly. Simply

[Cloud-init-dev] [Merge] ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial

Scott Moser has proposed merging ~smoser/cloud-init:ubuntu/xenial-refresh-ds-identify-patch into cloud-init:ubuntu/xenial. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/335100 -- Your team

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify into cloud-init:master

Diff comments: > diff --git a/tools/ds-identify b/tools/ds-identify > index 4c59d7b..5893a76 100755 > --- a/tools/ds-identify > +++ b/tools/ds-identify > @@ -657,7 +657,7 @@ is_cdrom_ovf() { > # skip devices that don't look like cdrom paths. > case "$dev" in >

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify into cloud-init:master. Commit message: ds-identify: failure in NoCloud due to unset variable usage. The previous OVF datasource change added a debug message that referenced an un-used variable

[Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-fix-console-log into cloud-init:master

The proposal to merge ~powersj/cloud-init:cii-fix-console-log into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/335052 -- Your team cloud-init commiters is requested to

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:baseNetConfTestSUSE into cloud-init:master

Robert, I'm sorry for the confusion. I was reading this purely "on its own". I think the re-factor makes it considerably easier to test, and thus is useful even if the point is only getting tests for somethign that will be replaced. Chad pointed out to me that using the module level defines as

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/tox-1.7.5 into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:cleanup/tox-1.7.5 into cloud-init:master. Commit message: tests: move to using tox 1.7.5 When we moved to having tox run on tests/ and tools/ we bumped tox to version 1.7.1. That was an error on my part as I just checked the version I had

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:baseNetConfTestSUSE into cloud-init:master

I think if we re-factor the code just a bit we can make this much easier to test. Heres an example: http://paste.ubuntu.com/26164253/ The result then is that we can test 'write_network_from_eni' by simply calling: tmpd = self.temp_dir() devs = write_network_from_eni("your_eni_blob",

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/leaked-tmpfiles-in-configdrive-test into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/leaked-tmpfiles-in-configdrive-test into cloud-init:master. Commit message: tests: remove leaked tmp files in config drive tests. Make sure that some temporary files used by the config drive tests get cleaned up properly. Requested

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:add-netplan-bridge-port-priority into cloud-init:master

We decided to mark this as work in progress until the fixes in netplan arrive. As it is right now, if the user provided data with port-priority values, cloud-init would render netplan config that netplan would fail on. Resurrect this when netplan is fixed. --

[Cloud-init-dev] [Merge] ~raharper/cloud-init:add-netplan-bridge-port-priority into cloud-init:master

The proposal to merge ~raharper/cloud-init:add-netplan-bridge-port-priority into cloud-init:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/334611 -- Your team cloud-init

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/reproducible-builds into cloud-init:master

originally from https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/334337 -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334991 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/reproducible-builds into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/reproducible-builds into cloud-init:master. Commit message: setup.py: Do not include rendered files in SOURCES.txt cloud-init renders template files during its run of setup.py. Those rendered files were in a temp dir and were making

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ci-nocloud-pubkeys-in-metadata into cloud-init:master

The proposal to merge ~smoser/cloud-init:cleanup/ci-nocloud-pubkeys-in-metadata into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334780 -- Your team cloud-init commiters is

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ci-nocloud-pubkeys-in-metadata into cloud-init:master

The proposal to merge ~smoser/cloud-init:cleanup/ci-nocloud-pubkeys-in-metadata into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334780 -- Your team cloud-init commiters is

[Cloud-init-dev] [Merge] ~raharper/cloud-init:add-netplan-bridge-port-priority into cloud-init:master

The proposal to merge ~raharper/cloud-init:add-netplan-bridge-port-priority into cloud-init:master has been updated. Status: Merged => Needs review For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/334611 -- Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~illfelder/cloud-init:master into cloud-init:master

It is not the 'ubuntu' user that gets keys. It is the system configured default user. The proposal here changes behavior for all Ubuntu instances launched on GCE. While some users may expect Ubuntu to act consistently with other platforms when running on GCE other users expect Ubuntu to act

[Cloud-init-dev] [Merge] ~raharper/cloud-init:cloud-test-add-pylint-and-fix into cloud-init:master

The proposal to merge ~raharper/cloud-init:cloud-test-add-pylint-and-fix into cloud-init:master has been updated. Description changed to: pylint: Update pylint to 1.7.1, run on tests/ and fix complaints. - Update tox.ini to invoke pylint v1.7.1. - Modify .pylintrc generated-members ignore

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix-ds-identify-vmware-ovf into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix-ds-identify-vmware-ovf into cloud-init:master. Commit message: OVF: improve ds-identify to support finding OVF iso transport. Previously the OVF transport would not be identified except for when config files set

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/ci-nocloud-pubkeys-in-metadata into cloud-init:master

Thanks. We should strip that off. I'll fix in the morning. On December 5, 2017 6:10:12 PM EST, Joshua Powers wrote: >Review: Approve > >LGTM thanks for adding meta data > >Note: there will be a new line at the end of the public key like: > >= ubuntu@cloud_test\n" > >

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master

The proposal to merge ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master has been updated. Description changed to: Datasources: Formalize DataSource get_data and related properties. Each DataSource subclass must define its own get_data method. This branch formalizes our

Re: [Cloud-init-dev] [Merge] ~danielwallace/cloud-init:salt-grains into cloud-init:master

Hi, A unit test would be good on this. You should be able to extend the integration tests in tests/cloud_tests/testcases/modules/salt_minion.yaml: but some unit tests on this m odule would sure be good too. --

[Cloud-init-dev] [Merge] ~danielwallace/cloud-init:salt-grains into cloud-init:master

The proposal to merge ~danielwallace/cloud-init:salt-grains into cloud-init:master has been updated. Commit Message changed to: salt: configure grains in grains file rather than in minion config. While salt grains can be configured in the minion config file, it is usually better to configure

[Cloud-init-dev] [Merge] ~danielwallace/cloud-init:salt-grains into cloud-init:master

The proposal to merge ~danielwallace/cloud-init:salt-grains into cloud-init:master has been updated. Description changed to: For more details, see: https://code.launchpad.net/~danielwallace/cloud-init/+git/cloud-init/+merge/334718 -- Your team cloud-init commiters is requested to review the

Re: [Cloud-init-dev] [Merge] cloud-init:master into ~illfelder/cloud-init:master

I re-submitted your merge proposal with the source and target swapped. (You had proposed a merge of cloud-init master into your branch). -- https://code.launchpad.net/~cloud-init-dev/cloud-init/+git/cloud-init/+merge/334733 Your team cloud-init commiters is requested to review the proposed merge

[Cloud-init-dev] [Merge] ~illfelder/cloud-init:master into cloud-init:master

Scott Moser has proposed merging ~illfelder/cloud-init:master into cloud-init:master. Commit message: Improve GCE logic setting Ubuntu user SSH keys. The behavior improvements include: - Only set ssh keys for the ubuntu user. - Use instance or project level keys based on GCE convention

[Cloud-init-dev] [Merge] ~illfelder/cloud-init:master into cloud-init:master

The proposal to merge ~illfelder/cloud-init:master into cloud-init:master has been updated. Commit Message changed to: Improve GCE logic setting Ubuntu user SSH keys. The behavior improvements include: - Only set ssh keys for the ubuntu user. - Use instance or project level keys based on GCE

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master

you do still have merge conflicts. -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330115 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:parameterize-cloud-config into cloud-init:master

b/cloudinit/handlers/jinja_template.py > @@ -0,0 +1,86 @@ > +# Copyright (C) 2012 Canonical Ltd. > +# Copyright (C) 2012 Hewlett-Packard Development Company, L.P. > +# Copyright (C) 2012 Yahoo! Inc. new file, drop the copied Copyright and Author, just go with the shortest header possibl

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master

Diff comments: > diff --git a/cloudinit/sources/__init__.py b/cloudinit/sources/__init__.py > index 9a43fbe..ec0fe2a 100644 > --- a/cloudinit/sources/__init__.py > +++ b/cloudinit/sources/__init__.py > @@ -78,6 +103,52 @@ class DataSource(object): > def __str__(self): > return

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:unify-datasource-get-data into cloud-init:master

Diff comments: > diff --git a/cloudinit/sources/__init__.py b/cloudinit/sources/__init__.py > index 9a43fbe..ec0fe2a 100644 > --- a/cloudinit/sources/__init__.py > +++ b/cloudinit/sources/__init__.py > @@ -78,6 +103,52 @@ class DataSource(object): > def __str__(self): > return

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/cii-kvmimage-preserve-original into cloud-init:master

It looks like as it is right now we do not call destroy on an image before using a snapshot. But having NoCloud work like other clouds makes sense. As it is right now we only ever call snapshot wrapped in a context handler of an image. --

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/cii-kvmimage-preserve-original into cloud-init:master

the Image object has a destroy() method which is valid to call, and should be called whne you're "done" with the object. i = Image(foo) i.execute(['apt-get', 'dist-upgrade']) s = i.snapshot() i.destroy() s.launch() ... the result of snapshot needs to be stand-alone, and before this

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/cii-kvmimage-preserve-original into cloud-init:master

Diff comments: > diff --git a/tests/cloud_tests/images/nocloudkvm.py > b/tests/cloud_tests/images/nocloudkvm.py > index 1e7962c..8678b07 100644 > --- a/tests/cloud_tests/images/nocloudkvm.py > +++ b/tests/cloud_tests/images/nocloudkvm.py > @@ -21,7 +25,13 @@ class NoCloudKVMImage(base.Image):

Re: [Cloud-init-dev] [Merge] ~rjschwei/cloud-init:noManualNet into cloud-init:master

Robert, This looks fine to me. We clearly do not have very good unit tests on the suse path. Otherwise you'd have broken a test with your change. I do approve of the change, but can we get a test added? If you want to ping me in cloud-init today i can point you in the right direction. --

[Cloud-init-dev] [Merge] ~powersj/cloud-init:enable-bionic into cloud-init:master

The proposal to merge ~powersj/cloud-init:enable-bionic into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/334141 -- Your team cloud-init commiters is requested to review the

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/cii-kvmimage-preserve-original into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/cii-kvmimage-preserve-original into cloud-init:master. Commit message: tests: NoCloudKVMImage do not modify the original local cache image. The NoCloudKVMImage.execute() would modify the image in /srv/citest that meant that after the first

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master has been updated. Commit Message changed to: tests: Use apt-get to install a deb so that depends get resolved. Instead of using 'dpkg -i' to install a package and then running apt-get -f install,

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334074 -- Your team cloud-init commiters is

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master has been updated. Status: Merged => Needs review For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334074 -- Your team cloud-init commiters is

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/zesty into cloud-init:ubuntu/zesty

The proposal to merge ~chad.smith/cloud-init:ubuntu/zesty into cloud-init:ubuntu/zesty has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334071 -- Your team cloud-init commiters is requested to

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:ubuntu/artful into cloud-init:ubuntu/artful

The proposal to merge ~chad.smith/cloud-init:ubuntu/artful into cloud-init:ubuntu/artful has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334072 -- Your team cloud-init commiters is requested to

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/ci-allow-deb-older-than-distro into cloud-init:master has been updated. Description changed to: https://jenkins.ubuntu.com/server/job/cloud-init-ci/531/console failed because of this (see failure log below). The reason is that the submitter's branch

<    1   2   3   4   5   6   7   8   9   10   >