[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd into cloud-init:master

The proposal to merge ~chad.smith/cloud-init:feature/schema-resizefs-bootcmd into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330243 -- Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/integration-execute-with-string into cloud-init:master

rejected, this was largely pulled into https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/330535 -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330459 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/integration-execute-with-string into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/integration-execute-with-string into cloud-init:master has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330459 -- Your team cloud-init commiters

Re: [Cloud-init-dev] [Merge] ~enolfc/cloud-init:bug-1716397 into cloud-init:master

.eu> wrote: > Hi, > > I'm asking my company to sign the agreement. Once that's done, I should get > back to you to add me to the group? > > Enol > > On 11 September 2017 at 17:11, Scott Moser <smo...@ubuntu.com> wrote: > > > Thank you for your contribution to

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-strings into cloud-init:master

Note above, 'mktemp -d' is probably not going to give you 'foo?'. However, nothing that i'm aware of promises that it's returned filenames will not have any characters that may be "special" to /bin/sh (or /usr/bin/perl or /usr/bin/python or gcc). --

Re: [Cloud-init-dev] [Merge] ~enolfc/cloud-init:bug-1716397 into cloud-init:master

For my own reference, 4.4 was Dec 2013 https://opennebula.org/software/release/ so that is "pretty old". -- https://code.launchpad.net/~enolfc/cloud-init/+git/cloud-init/+merge/330518 Your team cloud-init commiters is requested to review the proposed merge of ~enolfc/cloud-init:bug-1716397

Re: [Cloud-init-dev] [Merge] ~enolfc/cloud-init:bug-1716397 into cloud-init:master

is _MAC expected present in all OpenNebula releases ? or is that something only provided in newer releases ? It'd be good to comment about when it was present. Thanks for raising this and helping out. -- https://code.launchpad.net/~enolfc/cloud-init/+git/cloud-init/+merge/330518 Your team

Re: [Cloud-init-dev] [Merge] ~enolfc/cloud-init:bug-1716397 into cloud-init:master

Thank you for your contribution to cloud-init. Contributions to cloud-init require the developer to have signed the Canonical Contributors Agreement [1]. Your launchpad id is not currently listed as a member of the contributor-agreement-canonical group [2]. Membership in that group is currently

[Cloud-init-dev] [Merge] ~enolfc/cloud-init:bug-1716397 into cloud-init:master

The proposal to merge ~enolfc/cloud-init:bug-1716397 into cloud-init:master has been updated. Commit Message changed to: OpenNebula: support network configuration with persistent named devices. OpenNebula network configuration is provided in context with device identifiers in the form

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/integration-execute-with-string into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/integration-execute-with-string into cloud-init:master. Commit message: tests: execute: support command as a string, change default env parm. If a string is passed to execute, then invoke 'sh', '-c', 'string'. That allows the less

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/integration-execute-with-string into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/integration-execute-with-string into cloud-init:master has been updated. Commit Message changed to: tests: execute: support command as a string, change default env parm. If a string is passed to execute, then invoke 'sh', '-c', 'string'. That

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-kvm into cloud-init:master

fyi, regarding mount-image-callback: https://bugs.launchpad.net/cloud-init/+bug/1715994 :-( -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327646 Your team cloud-init commiters is requested to review the proposed merge of ~powersj/cloud-init:cii-kvm into

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:cii-kvm into cloud-init:master

"It also makes far more sense to have a command as a string, as an array is not a command." That is generally false. A shell tokenizes a string based on some very complicated rules and turns it into an array which it then passes to execve(2). If you ever have to pass a command that has a ", ',

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:config-modules-allow-distros-all into cloud-init:master

I'm generally ok with this. it does sure seem like we can clean up 'run_section'. but this isnt making anything any worse. Diff comments: > diff --git a/tests/unittests/test_runs/test_simple_run.py > b/tests/unittests/test_runs/test_simple_run.py > index 5cf666f..a8a2032 100644 > ---

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1715128-ec2-used-on-openstack into cloud-init:master

This will return ec2 to being searched after openstack. but there are still a couple things i have to think about the stack trace a bit. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330361 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1715128-ec2-used-on-openstack into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1715128-ec2-used-on-openstack into cloud-init:master has been updated. Commit Message changed to: Ec2: only attempt to operate at local mode on known platforms. This change makes the DataSourceEc2Local do nothing unless it is on actual AWS platform.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master

will address chad's comment. Diff comments: > diff --git a/tests/unittests/test_ds_identify.py > b/tests/unittests/test_ds_identify.py > index 1a81a89..c389029 100644 > --- a/tests/unittests/test_ds_identify.py > +++ b/tests/unittests/test_ds_identify.py > @@ -261,6 +268,29 @@ class

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master

It might be more obvious, but its more verbose. Same as calling a function with default arguments. The default values are filled in via 'write_mock' in call. the reason that we have 'detect_virt' as a shell function is that the call binary it is wrapping is 'detect-virt', which is not a valid

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master

On September 5, 2017 5:20:40 PM EDT, Ryan Harper wrote: > > >Diff comments: > >> diff --git a/tests/unittests/test_ds_identify.py >b/tests/unittests/test_ds_identify.py >> index 1a81a89..c389029 100644 >> --- a/tests/unittests/test_ds_identify.py >> +++

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master has been updated. Commit Message changed to: ds-identify: OpenStack on arch other than intel, identify 'maybe' OpenStack Nova identifies itself only to Intel guests. Make ds-identify

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master has been updated. Commit Message changed to: ds-identify: OpenStack on arch other than intel, identify 'maybe' OpenStack Nova identifies itself only to Intel guests. Make ds-identify

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1715241-openstack-maybe-on-non-intel into cloud-init:master. Commit message: ds-identify: OpenStack on arch other than intel, identify 'maybe' OpenStack Nova identifies itself only to Intel guests. Make ds-identify return 'MAYBE

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master has been updated. Commit Message changed to: tox: make xenial environment run with python3.6 The pinned versions of python packages in xenial do not work with python3.6. Currently, the failure can be seen with:

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master has been updated. Commit Message changed to: tox: set xenial environment to use jsonpatch 1.16. The pinned versions of python packages in xenial do not work with python3.6. Currently, the failure can be seen

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

Josh. OK, i'll re-submit. That said, this doesn't work forever (only until 3.6 breaks something else or 3.7 along). -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329926 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

The proposal to merge ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master has been updated. Commit Message changed to: upstart: do not package upstart jobs, drop ubuntu-init-switch module. The ubuntu-init-switch module allowed the use to launch an instance that was booted

[Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

The proposal to merge ~xnox/cloud-init:devel into cloud-init:ubuntu/devel has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491 -- Your team cloud-init commiters is requested to review the proposed

Re: [Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

Spurred on by this suggestion, I wrote an email to mailing list https://lists.launchpad.net/cloud-init/msg00095.html -- https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491 Your team cloud-init commiters is requested to review the proposed merge of ~xnox/cloud-init:devel

[Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

The proposal to merge ~xnox/cloud-init:devel into cloud-init:ubuntu/devel has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491 -- Your team cloud-init commiters is requested to review the

Re: [Cloud-init-dev] [Merge] ~xnox/cloud-init:devel into cloud-init:ubuntu/devel

This is fine with me. I'm not familiar with 'rm_conffile' but i have faith that Dimitri knows how to use it correctly. -- https://code.launchpad.net/~xnox/cloud-init/+git/cloud-init/+merge/329491 Your team cloud-init commiters is requested to review the proposed merge of ~xnox/cloud-init:devel

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:cleanup/drop-ubuntu-init-switch into cloud-init:master. Commit message: ubuntu-init-switch: drop this module. The module allowed the use to launch an instance that was booted with upstart and have it switch its init system to systemd

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

Another tested working option is this: $ git diff diff --git a/tox.ini b/tox.ini index 1e7ca2d3..c95f4443 100644 --- a/tox.ini +++ b/tox.ini @@ -66,8 +66,9 @@ deps = pyserial==3.0.1 configobj==5.0.6 requests==2.9.1 -# jsonpatch ubuntu is 1.10, not 1.19 (#839779) -

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/tox-xenial-3.5 into cloud-init:master has been updated. Commit Message changed to: tox: set xenial environment to be python 3.5. The pinned versions of python packages in xenial do not work with python3.6. Currently, the failure can be seen with:

[Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-ipv6-dhcp-support into cloud-init:master

The proposal to merge ~chad.smith/cloud-init:aws-ipv6-dhcp-support into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/329499 -- Your team cloud-init commiters is requested

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-opensuse into cloud-init:master

Diff comments: > diff --git a/tools/read-dependencies b/tools/read-dependencies > index 2a64868..08ef3bf 100755 > --- a/tools/read-dependencies > +++ b/tools/read-dependencies > @@ -35,7 +35,7 @@ DISTRO_INSTALL_PKG_CMD = { > 'redhat': ['yum', 'install', '--assumeyes'], > 'debian':

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1707222-use-run-for-tmpdir into cloud-init:master

Issues with this currently are a.) no unit tests of the _TEMPDIR path using /run/cloud-init. b.) ExtendedTemporaryFile was using util.del_file, but I did not want a circular import to cloudinit.util c.) could clean up /run/cloud-init via atexit d.) tempdir() was using del_dir, but circular

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1707222-use-run-for-tmpdir into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1707222-use-run-for-tmpdir into cloud-init:master. Commit message: Use /run/cloud-init for tempfile operations. During boot, the usage of /tmp is not safe. In systemd systems, systemd-tmpfiles-clean may run at any point and clear out

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-opensuse into cloud-init:master

I added Robert to review, hopefully he can follow up some. His explaination to me about 42.2 versus 42.3 made me feel that we probably should just do whole numbers there. It felt like basically 42.2 and 42.3 were likely to be identical from a lxc perspective. My recollection is that they'd

Re: [Cloud-init-dev] [Merge] ~ajorgens/cloud-init:py27-analyze into cloud-init:master

looks good. FileNotFoundError and PermissionError are both OSError -- https://code.launchpad.net/~ajorgens/cloud-init/+git/cloud-init/+merge/329653 Your team cloud-init commiters is requested to review the proposed merge of ~ajorgens/cloud-init:py27-analyze into cloud-init:master.

[Cloud-init-dev] [Merge] ~jasonbutz/cloud-init:user-data-include-file-format-documentation into cloud-init:master

The proposal to merge ~jasonbutz/cloud-init:user-data-include-file-format-documentation into cloud-init:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jasonbutz/cloud-init/+git/cloud-init/+merge/329595 -- Your team cloud-init

[Cloud-init-dev] [Merge] ~jasonbutz/cloud-init:user-data-include-file-format-documentation into cloud-init:master

The proposal to merge ~jasonbutz/cloud-init:user-data-include-file-format-documentation into cloud-init:master has been updated. Commit Message changed to: doc: Explain error behavior in user data include file format. Update user data 'include file' format documentation to explain the

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-opensuse into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/run-opensuse into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/329650 -- Your team cloud-init commiters

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/run-opensuse into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/run-opensuse into cloud-init:master has been updated. Commit Message changed to: tools: add run-opensuse this adds tools/run-opensuse that acts like run-centos. basically allowing you to easily create an opensuse container. a change needed to

[Cloud-init-dev] [Merge] ~jasonbutz/cloud-init:user-data-include-file-format-documentation into cloud-init:master

The proposal to merge ~jasonbutz/cloud-init:user-data-include-file-format-documentation into cloud-init:master has been updated. Commit Message changed to: doc: Explain error behavior in user data include file format. While troubleshooting an issue with a deploy I discovered that if an error

[Cloud-init-dev] [Merge] ~jasonbutz/cloud-init:user-data-include-file-format-documentation into cloud-init:master

The proposal to merge ~jasonbutz/cloud-init:user-data-include-file-format-documentation into cloud-init:master has been updated. Commit Message changed to: doc: Explain error behavior in user data include file format While troubleshooting an issue with a deploy I discovered that if an error

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/gce-main into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/gce-main into cloud-init:master. Commit message: GCE: Add a main to the GCE Datasource. This just adds a main to the GCE datasource so that it is easily callable: python3 -m cloudinit.sources.DataSourceGCE Requested reviews: cloud

[Cloud-init-dev] [Merge] ~smoser/cloud-init:master into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:master into cloud-init:master. Commit message: GCE: Add a main to the GCE Datasource. This just adds a main to the GCE datasource so that it is easily callable: python3 -m cloudinit.sources.DataSourceGCE Requested reviews: cloud-init

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:cc-landscape-py3-config-fix into cloud-init:master

s/fix this here/get this in as it is/ -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/329087 Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:cc-landscape-py3-config-fix into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:cc-landscape-py3-config-fix into cloud-init:master

i dont want to hold getting this in for a test re-work.. if you can show an example of wrap_and_call busted, just open a bug with that, and then lets fix this here. Diff comments: > diff --git a/tests/unittests/test_handler/test_handler_landscape.py >

[Cloud-init-dev] [Merge] ~j.kylmala/cloud-init:disable-proprietary-repositories into cloud-init:master

The proposal to merge ~j.kylmala/cloud-init:disable-proprietary-repositories into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~j.kylmala/cloud-init/+git/cloud-init/+merge/329286 -- Your team cloud-init commiters is

[Cloud-init-dev] [Merge] ~j.kylmala/cloud-init:disable-proprietary-repositories into cloud-init:master

The proposal to merge ~j.kylmala/cloud-init:disable-proprietary-repositories into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~j.kylmala/cloud-init/+git/cloud-init/+merge/329286 -- Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:cc-landscape-py3-config-fix into cloud-init:master

Under https://code.launchpad.net/~mb-methot/cloud-init/+git/cloud-init/+merge/326017 I pointed to http://paste.ubuntu.com/25069502/ which showed why the fix there was insufficient. if you've *not* covered what those unit tests cover, please add them. over all, looks good, some comments inline.

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

I added Andrew to this merge specifically for his insight on knowing how to determine if a metadata version is available . -- https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/328241 Your team cloud-init commiters is requested to review the proposed merge of

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

I have one fun comment in line. Diff comments: > diff --git a/cloudinit/sources/DataSourceEc2.py > b/cloudinit/sources/DataSourceEc2.py > index 4ec9592..dd9199e 100644 > --- a/cloudinit/sources/DataSourceEc2.py > +++ b/cloudinit/sources/DataSourceEc2.py > @@ -137,22 +157,27 @@ class

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:aws-local-dhcp into cloud-init:master

theres nothing huge in my comments. thanks. Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index 46cb9c8..d38ea8b 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -175,12 +175,10 @@ def is_disabled_cfg(cfg): > return

[Cloud-init-dev] [Merge] ~smoser/cloud-init:cleanup/get_by_mac_use_get_interfaces into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:cleanup/get_by_mac_use_get_interfaces into cloud-init:master. Commit message: net: Reduce duplicate code. Have get_interfaces_by_mac use get_interfaces. get_interfaces_by_mac and get_interfaces just looked much alike. This makes

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into cloud-init:master

some small things. i assume you were as much trying to avoid test changes as anything else, but the defaults we have there seem simplistic. Diff comments: > diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py > index 31ed64e..0b92a40 100644 > --- a/cloudinit/config/cc_ntp.py >

[Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into cloud-init:master

The proposal to merge ~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into cloud-init:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/328334 -- Your team cloud-init

[Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into cloud-init:master

The proposal to merge ~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/328334 -- Your team cloud-init

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into cloud-init:master

I think this is fine. It makes sense. the other way to fix this is to fix https://bugs.launchpad.net/cloud-init/+bug/1693265 to fix that we will stop writing resolv.conf but rather delegating that to sysconfig. -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/328334

[Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-arch-dns into cloud-init:master

The proposal to merge ~powersj/cloud-init:fix-arch-dns into cloud-init:master has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327914 -- Your team cloud-init commiters is requested to review the

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-arch-dns into cloud-init:master

I'm marking this rejected as I had opened up https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328114 with some related work and unit tests with it. I really hate how harsh 'rejected' sounds. -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327914

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1663045-archlinux-empty-dns into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1663045-archlinux-empty-dns into cloud-init:master has been updated. Commit Message changed to: archlinux: fix some network config bugs. Fix empty dns on writing network config If no dns nameservers were provided a stack trace would occur. The

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1663045-archlinux-empty-dns into cloud-init:master

The proposal to merge ~smoser/cloud-init:bug/1663045-archlinux-empty-dns into cloud-init:master has been updated. Commit Message changed to: archlinux: fix some network config bugs. Fix empty dns on writing network config If no dns nameservers were provided a stack trace would occur. The

[Cloud-init-dev] [Merge] ~smoser/cloud-init:bug/1663045-archlinux-empty-dns into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:bug/1663045-archlinux-empty-dns into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1663045 in cloud-init: "Arch distro fails to write network config with empty dns-nameservers&quo

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/disable-yakkety-tests into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/disable-yakkety-tests into cloud-init:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328098 -- Your team cloud-init commiters is requested to

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/disable-yakkety-tests into cloud-init:master

I'm ignoring the failure above as that is now fixed on trunk. 8a5296c41db45be3a172862f324ad44e732a2250 https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328101 so, pulling this. thanks for review. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328098

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/rpm-build-systemd-fsck-dropin into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/rpm-build-systemd-fsck-dropin into cloud-init:master has been updated. Commit Message changed to: centos: do not package systemd-fsck drop-in. The change here fixes the build of CentOS 7 rpm. The systemd 'drop-in' file

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/rpm-build-systemd-fsck-dropin into cloud-init:master

spelling error in subject. ... to fix on pull systemd -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328101 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:fix/rpm-build-systemd-fsck-dropin into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/disable-yakkety-tests into cloud-init:master

i think best to pull the 'release' out so we dont' have inadvertant bit-rot on a hunk of text that we're not ever going to support again. Ie, if its 'feature groups' needed change it would increase future burden to keep it here. Diff comments: > diff --git a/tests/cloud_tests/releases.yaml

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/rpm-build-systemd-fsck-dropin into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/rpm-build-systemd-fsck-dropin into cloud-init:master. Commit message: centos: do not package systed-fsck drop-in. The change here fixes the build of CentOS 7 rpm. The systemd 'drop-in' file systemd-fsck@.service.d/cloud-init.conf

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/locale-test-update into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/locale-test-update into cloud-init:master has been updated. Commit Message changed to: tests: adjust locale integration test to parse default locale. The locale integration test started failing with commit 0ef61b28. This was just because the test's

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/locale-test-update into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/locale-test-update into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) For more details, see: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/328095 -- Your team cloud-init commiters

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

please re-review. i think i've addressed all comments. Diff comments: > diff --git a/tests/unittests/test_distros/test_debian.py > b/tests/unittests/test_distros/test_debian.py > new file mode 100644 > index 000..bd7721c > --- /dev/null > +++ b/tests/unittests/test_distros/test_debian.py

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:unittests-in-cloudinit-package into cloud-init:master

small questions in line. Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index d1740e5..8745ee7 100644 > --- a/cloudinit/net/__init__.py > +++ b/cloudinit/net/__init__.py > @@ -557,6 +558,67 @@ def get_interfaces(): > return ret > > > +class

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-arch-dns into cloud-init:master

I'll come back to this, but i put some stuff at https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+ref/bug/1663045-archlinux-empty-dns which has a some unit tests too. -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327914 Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-arch-dns into cloud-init:master

seems better url is https://git.archlinux.org/netctl.git/tree/docs/netctl.profile.5.txt for the docstring -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327914 Your team cloud-init commiters is requested to review the proposed merge of ~powersj/cloud-init:fix-arch-dns

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:fix-arch-dns into cloud-init:master

Heres a bit larger change, but one that seems more generic. I'd also like to add some tests for 'convert_netctl'. http://paste.ubuntu.com/25164556/ -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327914 Your team cloud-init commiters is requested to review the proposed

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/control-type-manual into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:fix/control-type-manual into cloud-init:master. Commit message: sysconfig: support subnet type of 'manual'. The subnet type 'manual' was used as a way to declare a device and set an MTU for it but not assign network addresses. This updates

[Cloud-init-dev] [Merge] ~smoser/cloud-init:fix/control-type-manual into cloud-init:master

The proposal to merge ~smoser/cloud-init:fix/control-type-manual into cloud-init:master has been updated. Commit Message changed to: sysconfig: support subnet type of 'manual'. The subnet type 'manual' was used as a way to declare a device and set an MTU for it but not assign network

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/pregen-locale into cloud-init:master has been updated. Commit Message changed to: locale: Do not re-run locale-gen if provided locale is system default. If the system configure default in /etc/default/locale is set to the same value that is

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:curtin-centos into cloud-init:master

marked as merged as we have these all now in trunk. thanks Ryan -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648 Your team cloud-init commiters is requested to review the proposed merge of ~raharper/cloud-init:curtin-centos into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:net-update into cloud-init:master

We now have better test coverage in cloud-init including the multiple addresses for both ipv4 and ipv6 and ENI rendering. the only thing left is 'hwaddress ether'. And everything I read in interfaces(5) does not idnicate 'ether' is needed. also, we do support *reading* ENI that has 'hwadress

[Cloud-init-dev] [Merge] ~wesley-wiedenmeier/cloud-init:net-update into cloud-init:master

The proposal to merge ~wesley-wiedenmeier/cloud-init:net-update into cloud-init:master has been updated. Status: Work in progress => Rejected For more details, see: https://code.launchpad.net/~wesley-wiedenmeier/cloud-init/+git/cloud-init/+merge/316422 -- Your team cloud-init commiters is

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/pregen-locale into cloud-init:master

chad thanks for review. i'll get these fixes. -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/pregen-locale into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~chad.smith/cloud-init:unittests-in-cloudinit-package into cloud-init:master

why did you have to add mock to tox's pylint entries ? also some inline. this does look really nice though. thank you. Diff comments: > diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py > index d1740e5..5a4a232 100644 > --- a/cloudinit/net/__init__.py > +++

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos8 into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos8 into cloud-init:master. Commit message: sysconfig: use MACADDR on bonds/bridges to configure mac_address Previously, sysconfig rendered HWADDR for all interface types, but that value is only used to identify physical

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:curtin-centos into cloud-init:master

https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327836 has sysconfig: enable mtu set per subnet, including ipv6 mtu and then net: eni route rendering missed ipv6 default route config -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648 Your

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos7 into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/curtin-centos7 into cloud-init:master has been updated. Commit Message changed to: I plan to squash the tests: add tests for mtu for eni, netplan and sysconfig. commit into sysconfig: enable mtu set per subnet, including ipv6 mtu and then just

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos7 into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos7 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1701097 in cloud-init: "eni rendering of ipv6 gateways fails" https://bugs.launchpad.net/cloud-init/+b

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:curtin-centos into cloud-init:master

sysconfig: handle manual type subnets is at https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327828 -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos6 into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/curtin-centos6 into cloud-init:master has been updated. Commit Message changed to: sysconfig: handle manual type subnets Implement manual control for sysconfig by using ONBOOT=N. This allows an interface to be configured but not brought up.

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos6 into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos6 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1687725 in cloud-init: "sysconfig render does not support type manual subnets" https://bugs.launchpad

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos6 into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/curtin-centos6 into cloud-init:master has been updated. Commit Message changed to: sysconfig: handle manual type subnets Implement manual control for sysconfig by using ONBOOT=N. This allows an interface to be configured but not brought up. LP:

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:curtin-centos into cloud-init:master

merge for sysconfig: fix ipv6 gateway routes at https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327828 -- https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648 Your team cloud-init commiters is requested to review the proposed merge of

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos5 into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos5 into cloud-init:master. Commit message: sysconfig: fix ipv6 gateway routes Currently only the subnet is checked for 'ipv6' setting, however, the routes array may include a mix of v4 or v6 configurations, in particular

Re: [Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos4 into cloud-init:master

i plan on adding a vlan and a simple bridge test -- https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327821 Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:feature/curtin-centos4 into cloud-init:master.

Re: [Cloud-init-dev] [Merge] ~raharper/cloud-init:curtin-centos into cloud-init:master

merge for your Fix sysconfig rendering of virtual interfaces with network configurations is up at https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327821 i plan on adding a vlan and a simple bridge test. --

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos4 into cloud-init:master

The proposal to merge ~smoser/cloud-init:feature/curtin-centos4 into cloud-init:master has been updated. Commit Message changed to: sysconfig: fix rendering of bond, bridge and vlan types. Previously, virtual types (bond, bridge, vlan) were almost completely broken. They would not get any

[Cloud-init-dev] [Merge] ~smoser/cloud-init:feature/curtin-centos4 into cloud-init:master

Scott Moser has proposed merging ~smoser/cloud-init:feature/curtin-centos4 into cloud-init:master. Requested reviews: cloud-init commiters (cloud-init-dev) Related bugs: Bug #1695092 in cloud-init: "sysconfig only applies subnet/route config to physical interfaces&quo

<    2   3   4   5   6   7   8   9   10   11   >