Review: Approve continuous-integration
PASSED: Continuous integration, rev:3d851806873f3f050cbe29206ab32c5fe7fa5cc9
https://jenkins.ubuntu.com/server/job/cloud-init-ci/103/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Just validated on cent6 too:
2017-07-27 21:33:19,762 - handlers.py[DEBUG]: finish:
init-local/search-Ec2Local: SUCCESS: found local data from DataSourceEc2Local
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
Your team cloud-init commiters is requested to
Just tested on ubuntu AWS. minor fix needed to remove the route before removing
the address, because the side-effect of removing the addr is the route is
auto-deleted.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
Your team cloud-init commiters is requested
Review: Approve continuous-integration
PASSED: Continuous integration, rev:8ef6575c63eb4aaf08f1b0091d96cf1b8c9819e6
https://jenkins.ubuntu.com/server/job/cloud-init-ci/102/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Commit Message changed to:
cloudinit.net: add initialize_network_device function and tests
This is not yet called, but will be called in a subsequent Ec2-related branch
to
Per our discussion today, I simplified logic in EphemeralIPv4Network context
manager to first attempt to add a network address and handle a non-zero exit
code if the address already exits.
All changes have been made per review comments, I separated out get_ip_info
utility function so we can
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..8745ee7 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -557,6 +558,67 @@ def get_interfaces():
> return ret
>
>
> +class EphemeralIPv4Network(object):
>
Review: Approve continuous-integration
PASSED: Continuous integration, rev:cdba67c453c1da7b80d8d07274bc2d1c4995cb43
https://jenkins.ubuntu.com/server/job/cloud-init-ci/101/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:787586e45a5860c9be2ac13847b61855e29f7623
https://jenkins.ubuntu.com/server/job/cloud-init-ci/100/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
FAILED: Ubuntu LTS: Build
Click here to
Review: Approve continuous-integration
PASSED: Continuous integration, rev:93ace2828ef808bf32208e325de125ab40e4cefd
https://jenkins.ubuntu.com/server/job/cloud-init-ci/92/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
small questions in line.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..8745ee7 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -557,6 +558,67 @@ def get_interfaces():
> return ret
>
>
> +class
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:93ace2828ef808bf32208e325de125ab40e4cefd
https://jenkins.ubuntu.com/server/job/cloud-init-ci/91/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:e37c259841bc6d902e9fec9c4a5dc1db3ebac70f
https://jenkins.ubuntu.com/server/job/cloud-init-ci/89/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:a0bd7a79f0869fc3bb09272cb030f84f1bb335f1
https://jenkins.ubuntu.com/server/job/cloud-init-ci/87/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:0f476ef54a97487dc913027f6be3a071aaeb9575
https://jenkins.ubuntu.com/server/job/cloud-init-ci/86/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:a3692fcda19267d6d63b0317cdfb40d6df8b08ed
https://jenkins.ubuntu.com/server/job/cloud-init-ci/85/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:4b4989d894331e07041c2656ec7f02e6ed68b140
https://jenkins.ubuntu.com/server/job/cloud-init-ci/84/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:ed950d276972c869bbeb87dead0cc4ba55e2fc88
https://jenkins.ubuntu.com/server/job/cloud-init-ci/83/
Executed test runs:
SUCCESS: Checkout
FAILED: Unit & Style Tests
Click here to trigger a rebuild:
why did you have to add mock to tox's pylint entries ?
also some inline.
this does look really nice though.
thank you.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..5a4a232 100644
> --- a/cloudinit/net/__init__.py
> +++
Review: Approve continuous-integration
PASSED: Continuous integration, rev:a3692fcda19267d6d63b0317cdfb40d6df8b08ed
https://jenkins.ubuntu.com/server/job/cloud-init-ci/64/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..5a4a232 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -77,7 +78,7 @@ def read_sys_net_int(iface, field):
> return None
> try:
> return
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Description changed to:
cloudinit.net: add initialize_network_device function and unittest.
This is not yet called, but will be called in a subsequent Ec2-related branch
to
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Commit Message changed to:
cloudinit.net: add initialize_network_device function and unittests
This is not yet called, but will be called in a subsequent Ec2-related branch
to
Chad Smith has proposed merging
~chad.smith/cloud-init:unittests-in-cloudinit-package into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
cloudinit.net: add
24 matches
Mail list logo
