Re: Duplicate BareMetalTemplateAdapter classes

2013-02-14 Thread Min Chen
>>Thanks for filing this bug. >> >>I am working on it recently, because new baremetal which is as a >>single >> >>plugin haven't been checked in when javelin refactoring. So there are >> >>some old code which is not working still stay in

RE: Duplicate BareMetalTemplateAdapter classes

2013-02-14 Thread Alex Huang
lol > -Original Message- > From: rohityada...@gmail.com [mailto:rohityada...@gmail.com] On Behalf > Of Rohit Yadav > Sent: Thursday, February 14, 2013 9:16 AM > To: cloudstack-dev@incubator.apache.org > Cc: Min Chen; Kelven Yang > Subject: Re: Duplicate BareMetalTe

Re: Duplicate BareMetalTemplateAdapter classes

2013-02-14 Thread Rohit Yadav
tor.apache.org >> Cc: Min Chen >> Subject: Re: Duplicate BareMetalTemplateAdapter classes >> >> On Thu, Feb 14, 2013 at 11:24:26AM +0530, Rohit Yadav wrote: >> > Okay, but the fix is in vim51_win8, do you want to cherry pick on >> > master/4.1 now or will it com

RE: Duplicate BareMetalTemplateAdapter classes

2013-02-14 Thread Alex Huang
> -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Thursday, February 14, 2013 6:57 AM > To: cloudstack-dev@incubator.apache.org > Cc: Min Chen > Subject: Re: Duplicate BareMetalTemplateAdapter classes > > On Thu, Feb 14,

Re: Duplicate BareMetalTemplateAdapter classes

2013-02-14 Thread Chip Childers
en checked in when javelin refactoring. So there are > >>some old code which is not working still stay in source, I am cleaning > >>up/testing in my local source, > >>will close these bug when fixes are checked in > >> > >>From: rohityada...@gmail.com [mailt

Re: Duplicate BareMetalTemplateAdapter classes

2013-02-13 Thread Rohit Yadav
ich is not working still stay in source, I am cleaning >>up/testing in my local source, >>will close these bug when fixes are checked in >> >>From: rohityada...@gmail.com [mailto:rohityada...@gmail.com] On Behalf Of >>Rohit Yadav >>Sent: Wednesday, February 13,

RE: Duplicate BareMetalTemplateAdapter classes

2013-02-13 Thread Alex Huang
Another reason why we should never use autoscanning. --Alex > -Original Message- > From: Frank Zhang [mailto:frank.zh...@citrix.com] > Sent: Wednesday, February 13, 2013 10:35 AM > To: 'Rohit Yadav' > Cc: cloudstack > Subject: RE: Duplicate BareMetalTemplat

RE: Duplicate BareMetalTemplateAdapter classes

2013-02-13 Thread Frank Zhang
r.apache.org; 'Rohit Yadav' > Subject: Re: Duplicate BareMetalTemplateAdapter classes > > Rohit, it turned out that we were fixing the same bug yesterday:) I also ran > into template registration issue in vmware testing. I saw that you fixed that > issue through modifying ja

Re: Duplicate BareMetalTemplateAdapter classes

2013-02-13 Thread Min Chen
ting in my local source, >will close these bug when fixes are checked in > >From: rohityada...@gmail.com [mailto:rohityada...@gmail.com] On Behalf Of >Rohit Yadav >Sent: Wednesday, February 13, 2013 2:01 AM >To: Frank Zhang >Cc: cloudstack >Subject: Duplicate BareMetalTempla

RE: Duplicate BareMetalTemplateAdapter classes

2013-02-13 Thread Frank Zhang
e bug when fixes are checked in From: rohityada...@gmail.com [mailto:rohityada...@gmail.com] On Behalf Of Rohit Yadav Sent: Wednesday, February 13, 2013 2:01 AM To: Frank Zhang Cc: cloudstack Subject: Duplicate BareMetalTemplateAdapter classes Hi Frank, Can you check why we hav

Duplicate BareMetalTemplateAdapter classes

2013-02-13 Thread Rohit Yadav
Hi Frank, Can you check why we have two BareMetalTemplateAdapter; ./plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalTemplateAdapter.java (Found no usage across codebase, removable?) ./server/src/com/cloud/baremetal/BareMetalTemplateAdapter.java (only this one is used, as spr