RE: [MERGE] Support VM Snapshot

2013-03-20 Thread Animesh Chaturvedi
gt; Cc: Chandan Purushothama; Anthony Xu > Subject: RE: [MERGE] Support VM Snapshot > > It would be best to enable/disable this feature on a per hypervisor basis but > if that's complicated adding a top level flag to enable/disable the > functionality > is reasonable. > > >

RE: [MERGE] Support VM Snapshot

2013-03-18 Thread Animesh Chaturvedi
18, 2013 9:59 PM > To: cloudstack-dev@incubator.apache.org > Cc: Chandan Purushothama; Anthony Xu; Mice Xia > Subject: RE: [MERGE] Support VM Snapshot > > Animesh, > > Do you mean limit the capability by adding global configurations or adding in > [global-setting-

RE: [MERGE] Support VM Snapshot

2013-03-18 Thread Mice Xia
dev@incubator.apache.org; Mice Xia; Chandan Purushothama; Anthony Xu Subject: RE: [MERGE] Support VM Snapshot Mice any comments to my email below. Animesh > -Original Message- > From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] > Sent: Wednesday, March 13, 2013 6:03 PM &g

RE: [MERGE] Support VM Snapshot

2013-03-18 Thread Animesh Chaturvedi
inal Message- > > From: Mice Xia [mailto:weiran.x...@gmail.com] > > Sent: Monday, March 11, 2013 2:49 AM > > To: cloudstack-dev@incubator.apache.org > > Cc: Animesh Chaturvedi > > Subject: Re: [MERGE] Support VM Snapshot > > > > Animesh, > > > > sor

RE: [MERGE] Support VM Snapshot

2013-03-13 Thread Animesh Chaturvedi
9 AM > To: cloudstack-dev@incubator.apache.org > Cc: Animesh Chaturvedi > Subject: Re: [MERGE] Support VM Snapshot > > Animesh, > > sorry for the late reply. > > 1. currently in master branch it supports both xenserver and vmware, for > KVM it needs a new-versioned libvirt

Re: [MERGE] Support VM Snapshot

2013-03-11 Thread Mice Xia
Snapshot is > affected / degraded > > Thanks > Animesh > > >> -Original Message- >> From: Anthony Xu [mailto:xuefei...@citrix.com] >> Sent: Friday, February 01, 2013 5:44 PM >> To: 'Mice Xia'; cloudstack-dev@incubator.apache.org; Alex Huang;

RE: [MERGE] Support VM Snapshot

2013-03-10 Thread Animesh Chaturvedi
; Cc: Sangeetha Hariharan > Subject: RE: [MERGE] Support VM Snapshot > > Folks following up on this thread looks like support for XenServer is still > not > settled. > > 1. Mice can we make the feature configurable for each hypervisor to > enable/disable the feature 2. Test th

Re: [MERGE] Support VM Snapshot

2013-03-10 Thread Nitin Mehta
ed, not sure if >it's a good idea to handle lock sync in them. > >Regards >Mice > >-Original Message- >From: Nitin Mehta [mailto:nitin.me...@citrix.com] >Sent: Saturday, March 09, 2013 12:59 AM >To: cloudstack-dev@incubator.apache.org; Alex Huang >Cc: An

RE: [MERGE] Support VM Snapshot

2013-03-10 Thread Mice Xia
013 12:59 AM To: cloudstack-dev@incubator.apache.org; Alex Huang Cc: Anthony Xu Subject: Re: [MERGE] Support VM Snapshot Not to nitpick but for better understanding of what Alex's comment on the vm lifecycle. I went through the commit and saw the code change below. This change successfully a

Re: [MERGE] Support VM Snapshot

2013-03-08 Thread Nitin Mehta
;> - Does VM snapshot interfere with volume snapshot? Volume snapshot >>today makes the assumption that it is the only code that's making >>snapshots and can break if there are additional snapshots in between. >>This is bad design in volume snapshot but unfortunately that

RE: [MERGE] Support VM Snapshot

2013-03-07 Thread Alex Huang
teps you provide on xenserver, all the > > files (test1, test2, test3) are present, the function is not affected. > > But as i have replied, volume snapshot (s2) is not a delta snapshot, > > it is a full one. Users need to be aware of this if they want to use > > both snapsh

RE: [MERGE] Support VM Snapshot

2013-03-07 Thread Animesh Chaturvedi
Animesh > -Original Message- > From: Anthony Xu [mailto:xuefei...@citrix.com] > Sent: Friday, February 01, 2013 5:44 PM > To: 'Mice Xia'; cloudstack-dev@incubator.apache.org; Alex Huang; Mice Xia > Subject: RE: [MERGE] Support VM Snapshot > > I see, snapshot

RE: [MERGE] Support VM Snapshot

2013-02-13 Thread Sangeetha Hariharan
: Re: [MERGE] Support VM Snapshot On 02/13/2013 01:44 AM, Sangeetha Hariharan wrote: > I am planning on testing this feature and wanted to know the list of > hypervisors that support this feature. > > When I refer to the design document - > https://cwiki.apache.org/confluence/displa

Re: [MERGE] Support VM Snapshot

2013-02-13 Thread Wido den Hollander
...@tcloudcomputing.com] Sent: Saturday, February 02, 2013 11:26 AM To: Alex Huang; Anthony Xu; cloudstack-dev@incubator.apache.org Subject: RE: [MERGE] Support VM Snapshot For now, Volume snapshot and VM snapshot cannot be taken at the same time, i.e, it will check if there are active volume

RE: [MERGE] Support VM Snapshot

2013-02-12 Thread Sangeetha Hariharan
] Sent: Monday, February 04, 2013 3:39 AM To: cloudstack-dev@incubator.apache.org Subject: Re: [MERGE] Support VM Snapshot On 02/03/2013 03:09 AM, Mice Xia wrote: > So...it seems there are still some consensus to be reached and the codes were > not merged before 4.1 feature freeze. This will

Re: [MERGE] Support VM Snapshot

2013-02-04 Thread Wido den Hollander
...@tcloudcomputing.com] Sent: Saturday, February 02, 2013 11:26 AM To: Alex Huang; Anthony Xu; cloudstack-dev@incubator.apache.org Subject: RE: [MERGE] Support VM Snapshot For now, Volume snapshot and VM snapshot cannot be taken at the same time, i.e, it will check if there are active volume

RE: [MERGE] Support VM Snapshot

2013-02-02 Thread Mice Xia
; Anthony Xu; cloudstack-dev@incubator.apache.org Subject: RE: [MERGE] Support VM Snapshot For now, Volume snapshot and VM snapshot cannot be taken at the same time, i.e, it will check if there are active volume snapshots tasks when taking a VM snapshot, and vice versa. Another way to clear any

RE: [MERGE] Support VM Snapshot

2013-02-01 Thread Mice Xia
you’re pointing out. --Alex From: Anthony Xu Sent: Friday, February 01, 2013 5:44 PM To: 'Mice Xia'; cloudstack-dev@incubator.apache.org; Alex Huang; Mice Xia Subject: RE: [MERGE] Support VM Snapshot I see, snapshot manager detected the change in primary storage, and crea

RE: [MERGE] Support VM Snapshot

2013-02-01 Thread Alex Huang
pointing out. --Alex From: Anthony Xu Sent: Friday, February 01, 2013 5:44 PM To: 'Mice Xia'; cloudstack-dev@incubator.apache.org; Alex Huang; Mice Xia Subject: RE: [MERGE] Support VM Snapshot I see, snapshot manager detected the change in primary storage, and create a full snapshot inst

RE: [MERGE] Support VM Snapshot

2013-02-01 Thread Anthony Xu
snapshots simultaneously. Regards Mice -Original Message- From: Anthony Xu [mailto:xuefei...@citrix.com] Sent: 2013-2-2 (星期六) 4:05 To: Alex Huang; Mice Xia; cloudstack-dev@incubator.apache.org Subject: RE: [MERGE] Support VM Snapshot CS uses XenServer delta snapshot, snapshot manager

RE: [MERGE] Support VM Snapshot

2013-02-01 Thread Anthony Xu
ne is supported in a zone, volume snapshot or vm snapshot. Anthony > -Original Message- > From: Alex Huang > Sent: Friday, February 01, 2013 10:54 AM > To: Mice Xia; cloudstack-dev@incubator.apache.org > Cc: Anthony Xu > Subject: RE: [MERGE] Support VM Snapshot

RE: [MERGE] Support VM Snapshot

2013-02-01 Thread Alex Huang
ave been passed to down to the java interface. > > [ > > mice] I'll change it > > > > A small note: Would it be better to call it VM restore than VM revert? > Revert really should be RevertTo which I think is in the code but is not > consistent. Some

Re: [MERGE] Support VM Snapshot

2013-02-01 Thread Mice Xia
RevertTo which I think is in the code but is not > consistent. Some places it's just REVERT (for example, the event is just > revert). > > [mice] there is already RESTORE, which is restoring a destroyed VM to > stopped. RevertTo is fine with me. > > -Mice > > > --

RE: [MERGE] Support VM Snapshot

2013-01-31 Thread Mice Xia
is just revert). [mice] there is already RESTORE, which is restoring a destroyed VM to stopped. RevertTo is fine with me. -Mice -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Friday, February 01, 2013 9:24 AM To: CloudStack DeveloperList Cc: Mice Xia Subject

Re: [MERGE] Support VM Snapshot

2013-01-31 Thread Ahmad Emneina
ould it be better to call it VM restore than VM revert? > Revert really should be RevertTo which I think is in the code but is not > consistent. Some places it's just REVERT (for example, the event is just > revert). > > --Alex > > > -Original Message- >

RE: [MERGE] Support VM Snapshot

2013-01-31 Thread Alex Huang
> From: Chiradeep Vittal > Sent: Wednesday, January 30, 2013 4:44 PM > To: CloudStack DeveloperList > Cc: Alex Huang > Subject: Re: [MERGE] Support VM Snapshot > > Can we get Alex to review this? He is the designer of the state machine. > > On 1/30/13 5:26 AM, "Mur

Re: [MERGE] Support VM Snapshot

2013-01-30 Thread Chiradeep Vittal
Can we get Alex to review this? He is the designer of the state machine. On 1/30/13 5:26 AM, "Murali Reddy" wrote: >On 30/01/13 2:24 PM, "Mice Xia" wrote: > >>Agreed. >>Adding VM states are likely to have some side-effects, but for >>moveVMToUser case, does it explicitly reject other transient

Re: [MERGE] Support VM Snapshot

2013-01-30 Thread Murali Reddy
On 30/01/13 2:24 PM, "Mice Xia" wrote: >Agreed. >Adding VM states are likely to have some side-effects, but for >moveVMToUser case, does it explicitly reject other transient states such >as stating/stopping/migrating? > >-Mice No, it just accepts any state other than 'Running' (though it should

RE: [MERGE] Support VM Snapshot

2013-01-30 Thread Mice Xia
, 2013 4:10 PM To: cloudstack-dev@incubator.apache.org Subject: Re: [MERGE] Support VM Snapshot On 30/01/13 1:14 PM, "Mice Xia" wrote: >Murali, > >I haven¹t tested all possible cases, but due to the fact possible VM >state transits are defined by state machine, all operation

Re: [MERGE] Support VM Snapshot

2013-01-30 Thread Murali Reddy
cks the operation if VM state is Running, but will succeed if the state is 'RunningSnapshotting' which is un-intended. > >-Mice > >-Original Message- >From: Murali Reddy [mailto:murali.re...@citrix.com] >Sent: Wednesday, January 30, 2013 3:12 PM >

RE: [MERGE] Support VM Snapshot

2013-01-29 Thread Mice Xia
PM To: cloudstack-dev@incubator.apache.org Subject: Re: [MERGE] Support VM Snapshot >>> >>> >>> >>> Potential impact and notes: >>> * 4 new states are added to VM state Machine Mice, When the VM is in transient states (RunningSnapshotting, StoppedSnapsh

Re: [MERGE] Support VM Snapshot

2013-01-29 Thread Murali Reddy
>>> >>> >>> >>> Potential impact and notes: >>> * 4 new states are added to VM state Machine Mice, When the VM is in transient states (RunningSnapshotting, StoppedSnapshotting), I see that you have taken care of vmsync. But have you ensured that all the concurrent operations on the VM are blocked

RE: [MERGE] Support VM Snapshot

2013-01-29 Thread Mice Xia
I'll keep it open for 24 hours, if there is no objection during 24 hours , I will merge it to master -Mice -Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Wednesday, January 30, 2013 11:11 AM To: Subject: Re: [MERGE] Support VM Snapshot On Jan 29,

Re: [MERGE] Support VM Snapshot

2013-01-29 Thread Chip Childers
e bringing in the feature, but it should probably get documented before the release. Sounds like your ready to merge! +1 from me > Regards > -Mice > > -Original Message- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Tuesday, January 29, 2013 10:34 PM &g

RE: [MERGE] Support VM Snapshot

2013-01-29 Thread Mice Xia
--Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Tuesday, January 29, 2013 10:34 PM To: cloudstack-dev@incubator.apache.org Subject: Re: [MERGE] Support VM Snapshot On Mon, Jan 28, 2013 at 9:35 PM, Mice Xia wrote: > I would like to request merge of feature V

Re: [MERGE] Support VM Snapshot

2013-01-29 Thread Wido den Hollander
On 01/29/2013 03:35 AM, Mice Xia wrote: I would like to request merge of feature VM snapshot to master Review board: https://reviews.apache.org/r/9118/ Doc/spec https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots Jira ticket https://issues.apache.org/jira/browse/CLOUDSTACK-68

Re: [MERGE] Support VM Snapshot

2013-01-29 Thread Chip Childers
On Mon, Jan 28, 2013 at 9:35 PM, Mice Xia wrote: > I would like to request merge of feature VM snapshot to master > > Review board: > https://reviews.apache.org/r/9118/ > > Doc/spec > https://cwiki.apache.org/confluence/display/CLOUDSTACK/VM+Snapshots > > Jira ticket > https://issues.apache.org/ji