Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-27 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/#review17146 --- Ship it! Ship It! - Sateesh Chodapuneedi On Feb. 25, 2013, 11:33

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-25 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/ --- (Updated Feb. 25, 2013, 11:33 a.m.) Review request for cloudstack, Murali Reddy

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-21 Thread Kelven Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/#review16923 --- Ship it! Ship It! - Kelven Yang On Feb. 19, 2013, 6:41 a.m., Sate

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-18 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/ --- (Updated Feb. 19, 2013, 6:41 a.m.) Review request for cloudstack, Murali Reddy a

RE: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-18 Thread Koushik Das
Cc: Sateesh Chodapuneedi; cloudstack; Koushik Das Subject: Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/ On February 17th, 2013, 2:01 p.m

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-17 Thread Sateesh Chodapuneedi
> On Feb. 17, 2013, 2:01 p.m., Koushik Das wrote: > > I can only see the test cases. Where is the changes related to > > prepareNetwork as you have mentioned in the description? Revision 1 contains those changes Link - https://reviews.apache.org/r/9201/diff/1/#index_header) Revision 2 contains

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-17 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/#review16695 --- I can only see the test cases. Where is the changes related to prepar

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-12 Thread Sateesh Chodapuneedi
> On Feb. 11, 2013, 9:21 p.m., ilya musayev wrote: > > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 1001 > > > > > > Do we have to be bound to a static dvSwitch0 or can this be retrieved > > dynamically? T

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-12 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/ --- (Updated Feb. 13, 2013, 4:04 a.m.) Review request for cloudstack, Murali Reddy a

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-12 Thread Sateesh Chodapuneedi
> On Feb. 11, 2013, 9:08 p.m., ilya musayev wrote: > > vmware-base/test/com/cloud/vmware/TestVMWare.java, line 936 > > > > > > why hardcoded IP? Reading IP from connection url. > On Feb. 11, 2013, 9:08 p.m., ilya mus

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-11 Thread ilya musayev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/#review16443 --- vmware-base/test/com/cloud/vmware/TestVMWare.java

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-11 Thread ilya musayev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/#review16442 --- vmware-base/test/com/cloud/vmware/TestVMWare.java

Re: Review Request: PATCH-4 for feature VMware vNetwork Distributed Virtual Switch support in CloudStack

2013-02-04 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9201/ --- (Updated Feb. 5, 2013, 5:43 a.m.) Review request for cloudstack, Murali Reddy an