Re: Review Request: Added Unit test cases for com.cloud.api.commands

2013-02-12 Thread Chip Childers
32 AM > > To: David Nalley > > Cc: cloudstack-dev@incubator.apache.org; Chip Childers; Prasanna Santhanam; > > Alex Huang; mice xia; Chiradeep Vittal; Meghna Kale > > Subject: Re: Review Request: Added Unit test cases for > > com.cloud.api.commands > > > > >

RE: Review Request: Added Unit test cases for com.cloud.api.commands

2013-02-11 Thread Animesh Chaturvedi
Cc: cloudstack-dev@incubator.apache.org; Chip Childers; Prasanna Santhanam; > Alex Huang; mice xia; Chiradeep Vittal; Meghna Kale > Subject: Re: Review Request: Added Unit test cases for > com.cloud.api.commands > > > On 19-Dec-2012, at 8:36 AM, David Nalley wrote: > > &g

Re: Review Request: Added Unit test cases for com.cloud.api.commands

2012-12-19 Thread Rohit Yadav
On 19-Dec-2012, at 8:36 AM, David Nalley wrote: > On Tue, Dec 18, 2012 at 10:59 PM, Rohit Yadav wrote: >> >> --- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/8545/#review14711 >> -

Re: Review Request: Added Unit test cases for com.cloud.api.commands

2012-12-19 Thread David Nalley
On Tue, Dec 18, 2012 at 10:59 PM, Rohit Yadav wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8545/#review14711 > --- > > > Th

Re: Review Request: Added Unit test cases for com.cloud.api.commands

2012-12-18 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8545/#review14711 --- Thanks for your patch, but your changes are not applying cleanly and

Re: Review Request: Added Unit test cases for com.cloud.api.commands

2012-12-17 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8545/#review14635 --- I'd like someone more familiar with the command classes being modifie

Re: Review Request: Added Unit test cases for com.cloud.api.commands

2012-12-13 Thread Meghna Kale
> On Dec. 13, 2012, 2:27 p.m., Chip Childers wrote: > > Megnha, > > > > You are making a number of changes to the command classes. Can you please > > provide a description of why each change is needed before we apply this > > patch? Chip, The changes in the command classes are done to handle

Re: Review Request: Added Unit test cases for com.cloud.api.commands

2012-12-13 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8545/#review14428 --- Megnha, You are making a number of changes to the command classes.

Review Request: Added Unit test cases for com.cloud.api.commands

2012-12-12 Thread Meghna Kale
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8545/ --- Review request for cloudstack, Chip Childers, Prasanna Santhanam, mice xia, Chira