Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-07 Thread Chip Childers
On Thu, Mar 07, 2013 at 09:54:12AM +, Harikrishna Patnala wrote: > > > > On March 7, 2013, 9:42 a.m., Prasanna Santhanam wrote: > > > d51e964 on master > > Can you push this on 4.1 also. This could be the problem on both master and > 4.1 Applied to 4.1. > > > - Harikrishna > > > -

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-07 Thread Harikrishna Patnala
> On March 7, 2013, 9:42 a.m., Prasanna Santhanam wrote: > > d51e964 on master Can you push this on 4.1 also. This could be the problem on both master and 4.1 - Harikrishna --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-07 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9727/#review17535 --- Ship it! d51e964 on master - Prasanna Santhanam On March 7, 2013,

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-07 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9727/ --- (Updated March 7, 2013, 9:19 a.m.) Review request for cloudstack and Abhinandan

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-07 Thread Prasanna Santhanam
> On March 4, 2013, 7:38 a.m., Dave Cahill wrote: > > This looks good to me - and great to see someone is fixing it! > > > > One slightly strange edge case springs to mind - I think the behavior in > > this edge case is fine, but wanted to bring it up explicitly just in case: > > > > In KVM,

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-07 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9727/#review17532 --- Hari - the suffix .pub is applied by ssh-keygen. The key will not end

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-07 Thread Prasanna Santhanam
> On March 4, 2013, 7:38 a.m., Dave Cahill wrote: > > This looks good to me - and great to see someone is fixing it! > > > > One slightly strange edge case springs to mind - I think the behavior in > > this edge case is fine, but wanted to bring it up explicitly just in case: > > > > In KVM,

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-06 Thread Harikrishna Patnala
> On March 4, 2013, 7:38 a.m., Dave Cahill wrote: > > This looks good to me - and great to see someone is fixing it! > > > > One slightly strange edge case springs to mind - I think the behavior in > > this edge case is fine, but wanted to bring it up explicitly just in case: > > > > In KVM,

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-06 Thread Prasanna Santhanam
> On March 4, 2013, 7:38 a.m., Dave Cahill wrote: > > This looks good to me - and great to see someone is fixing it! > > > > One slightly strange edge case springs to mind - I think the behavior in > > this edge case is fine, but wanted to bring it up explicitly just in case: > > > > In KVM,

Re: Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-03 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9727/#review17325 --- This looks good to me - and great to see someone is fixing it! One

Review Request: CLOUDSTACK-1013 : running cloudstack overwrites default public/private ssh keys

2013-03-03 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9727/ --- Review request for cloudstack and Abhinandan Prateek. Description --- SSH k