Re: Review Request: Introduce Vif Driver in KVM

2012-08-21 Thread Tomoe Sugihara
> On Aug. 10, 2012, 7:06 p.m., edison su wrote: > > Ship It! Thanks for the review. I'll close this review. - Tomoe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review10141 -

Re: Review Request: Introduce Vif Driver in KVM

2012-08-10 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review10141 --- Ship it! Ship It! - edison su On Aug. 6, 2012, 1:39 a.m., Tomoe S

Re: Review Request: Introduce Vif Driver in KVM

2012-08-07 Thread Tomoe Sugihara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review10008 --- Any other comments or issues that I can address? I'd like get this in

Re: Review Request: Introduce Vif Driver in KVM

2012-08-06 Thread Wido den Hollander
> On Aug. 6, 2012, 9:34 a.m., Wido den Hollander wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, > > line 124 > > > > > > The general rule on Linux is still to limit inter

Re: Review Request: Introduce Vif Driver in KVM

2012-08-06 Thread Tomoe Sugihara
> On Aug. 6, 2012, 9:34 a.m., Wido den Hollander wrote: > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java, > > line 124 > > > > > > The general rule on Linux is still to limit inter

Re: Review Request: Introduce Vif Driver in KVM

2012-08-06 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/#review9882 --- plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeV

Re: Review Request: Introduce Vif Driver in KVM

2012-08-05 Thread Tomoe Sugihara
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6285/ --- (Updated Aug. 6, 2012, 1:39 a.m.) Review request for cloudstack, edison su and C