Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-18 Thread joe mills
> On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote: > > server/src/com/cloud/network/NetworkManagerImpl.java, line 1773 > > > > > > NetworkElement should be always called after NetworkGuru, isn't it? > > Dave Cahill

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-16 Thread Hiroaki Kawai
> On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote: > > server/src/com/cloud/network/NetworkManagerImpl.java, line 1773 > > > > > > NetworkElement should be always called after NetworkGuru, isn't it? > > Dave Cahill

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-14 Thread Dave Cahill
> On March 14, 2013, 8:15 a.m., Hugo Trippaers wrote: > > deps/install-non-oss.sh, line 19 > > > > > > I'm not really thrilled by adding components to the non-oss build. > > > > What are the possibilities of mak

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-14 Thread Dave Cahill
> On March 14, 2013, 8:15 a.m., Hugo Trippaers wrote: > > Hi Hugo, thanks for the quick review reply. > On March 14, 2013, 8:15 a.m., Hugo Trippaers wrote: > > deps/install-non-oss.sh, line 19 > > > > > > I'm not real

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/#review17865 --- deps/install-non-oss.sh

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-13 Thread Dave Cahill
> On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote: > > The patch set is so big that it is hard to review. It would be nice to > > separate it into management-server, plugin, agent plugin and UI. Thanks for the review Kawai-san! With regard to the patch size, we followed the example of the Bi

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-13 Thread Hiroaki Kawai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/#review17849 --- The patch set is so big that it is hard to review. It would be nice t

Review Request: MidoNet Networking Plugin [2/2]

2013-03-13 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/ --- Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal. Description