Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-29 Thread Kostka Bořivoj
gTerm(). Borek > -Original Message- > From: Itamar Syn-Hershko [mailto:[email protected]] > Sent: Tuesday, June 29, 2010 1:57 PM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing > > On 29/6/2010

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-29 Thread Itamar Syn-Hershko
On 29/6/2010 1:41 PM, Kostka Bořivoj wrote: > I agree it works fine (and your way of nulling is definitelly better than > mine). > I already indexed about 1GB of data, but I'm not sure about mem leaks, > as my application memory increases constantly during indexing (and it didn't > with previous

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-29 Thread Kostka Bořivoj
until now I was not able figure out if (1) or (2) is true. Borek > -Original Message- > From: Itamar Syn-Hershko [mailto:[email protected]] > Sent: Tuesday, June 29, 2010 12:32 PM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-29 Thread Itamar Syn-Hershko
I tested it a bit, and overall it seems to work just fine. I checked in my changes into master and I'm signing off this issue. If you could test this further (using your app is just fine, but of course IndexWriter and DocumentsWriter tests are even better), check cl_demo for leaks and try to se

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-29 Thread Itamar Syn-Hershko
On 29/6/2010 12:04 PM, Kostka Bořivoj wrote: > My cycle starts at this->postingsFreeCountDW, not at 0 Sorry, I misread you. I thought you just replaced the line within the loop. So yes, it seems to be the same, except with my solution you don't have to search for more copy/delete occurrences in

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-29 Thread Kostka Bořivoj
nd you told me this will introduce memory leaks. And there are some in > > cl_demo. > > > > So you think this is OK, or some additional exploration should be done? > > > > Borek > > > > > >> -----Original Message- > >> From: Itama

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-29 Thread Itamar Syn-Hershko
xploration should be done? > > Borek > > >> -Original Message- >> From: Itamar Syn-Hershko [mailto:[email protected]] >> Sent: Tuesday, June 29, 2010 12:35 AM >> To: [email protected] >> Subject: Re: [CLucene-dev] vector s

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-29 Thread Kostka Bořivoj
o [mailto:[email protected]] > Sent: Tuesday, June 29, 2010 12:35 AM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing > > Alrighty, seems like I have nailed it. See below + attached patch. > > On 29/

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-28 Thread Itamar Syn-Hershko
Alrighty, seems like I have nailed it. See below + attached patch. On 29/6/2010 12:39 AM, Kostka Bořivoj wrote: I'm quite sure the problem is in postingsFreeListDW management: The postings after postingsFreeCountDW are used somewhere (but are still here in a list). If you remove block of free

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-28 Thread Kostka Bořivoj
ingsFreeCountDW < postingsFreeListDW.length in the destructor. Borek > -Original Message- > From: Itamar Syn-Hershko [mailto:[email protected]] > Sent: Monday, June 28, 2010 10:46 PM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript outofran

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-28 Thread Itamar Syn-Hershko
On 28/6/2010 10:48 PM, Kostka Bořivoj wrote: > I did some tests with cl_demo and found following: > > In DocumentsWriter destructor postingsFreeCountDW is 5888 and the length of > postingsFreeListDW.values > is 7424. Maybe I'm wrong but if I understand the logic implemented in > getPostings and

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-28 Thread Kostka Bořivoj
rshko [mailto:[email protected]] > Sent: Sunday, June 27, 2010 11:50 PM > To: [email protected] > Cc: [email protected]; Kostka Bořivoj; [email protected] > Subject: Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing > > Hi all, >

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-27 Thread Itamar Syn-Hershko
Hi all, Just to let you know Borek was right. The error you all hit was related to a typo (or rather, an incorrect port of code). I committed a fix to master [1]. However, this introduced a new issue with double deletion of the postings array (DocumentsWriter::postingsFreeListDW). Some code tr

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-27 Thread Itamar Syn-Hershko
I know. Without a solid test to reproduce the problem this is quite hard to pinpoint and fix. As you can see from this thread, I'm doing my best to resolve this quickly, but due to time constraints apparently I won't be able to do this all on my own. If you can jump in and help, by providing a

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-27 Thread justroftest
hi, That is the same problem reported here [1] after updating my master branch, cl_demo can index reuters-21578 without any crash cl_test fail on testWickedLongTerm [2] we are working on a project that use CLucene, we need to index about 2GB at least, and this problem is really annoying us. Regard

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-26 Thread Itamar Syn-Hershko
Just one other small thing I noticed: apparently this only occurs when writer->setRAMBufferSizeMB(0.5); is called. This leads me to think something in the process of calculating which postings to flush and delete (based on their block size) is wrong. Uncomment writer->setInfoStream(&std::cout);

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-26 Thread Itamar Syn-Hershko
Borek, a quick update: Apparently I was wrong. The 2 issues mentioned in JIRA 1072 were already fixed in 2.3.2, and the core patches attached to it weren't showing up in the release since other check-ins updated them to work differently. So, what you were experiencing is either a CLucene specif

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-25 Thread Kostka Bořivoj
OK, I'm going to port this. > -Original Message- > From: Itamar Syn-Hershko [mailto:[email protected]] > Sent: Friday, June 25, 2010 3:04 PM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-25 Thread Itamar Syn-Hershko
On 25/6/2010 3:58 PM, Kostka Bořivoj wrote: > I'm sorry, I missed there is different test which provokes this error n the > patch. (I mean different from > that one I ported). This together with fact the ported test will not > reproduce problem > caused my wrong conclusion. You are absolutely rig

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-25 Thread Kostka Bořivoj
guess, correct? Borek > -Original Message- > From: Itamar Syn-Hershko [mailto:[email protected]] > Sent: Friday, June 25, 2010 2:02 PM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing > > I re

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-25 Thread Itamar Syn-Hershko
to:[email protected]] >> Sent: Thursday, June 24, 2010 4:21 PM >> To: [email protected] >> Subject: Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing >> >> Apparently the first patch they have there tests the issue you are facing

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-25 Thread Kostka Bořivoj
gt; From: Itamar Syn-Hershko [mailto:[email protected]] > Sent: Thursday, June 24, 2010 4:21 PM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing > > Apparently the first patch they have there tests the issue

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-24 Thread Itamar Syn-Hershko
Sent: Thursday, June 24, 2010 1:40 PM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript > outofrangeexceptionduringindexing > > I ported test from JIRA issue 1072 and it also somehow > destroys DocumentWriter. > It doesn't produce

Re: [CLucene-dev] vector subscript outofrangeexceptionduringindexing

2010-06-24 Thread Itamar Syn-Hershko
). Itamar. > -Original Message- > From: Kostka Bořivoj [mailto:[email protected]] > Sent: Thursday, June 24, 2010 3:11 PM > To: [email protected] > Subject: Re: [CLucene-dev] vector subscript > outofrangeexceptionduringindexing > > I already