Hi Steven,
the patch fixes the issues we discussed on the mailing list before and IRC.
The issue is indeed UP vs SMP and it is totally random.
spin_is_locked() is a bad assertion because there is no correct answer on UP.
on UP spin_is_locked() has to return either one value or another, always.
Signed-off-by: Fabio M. Di Nitto [EMAIL PROTECTED]
David Teigland wrote:
Print error with log_error() to be consistent with others.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/gfs2/locking/dlm/mount.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
From: Steven Whitehouse [EMAIL PROTECTED]
Date: Fri, 16 Nov 2007 10:37:43 +
Ah, all becomes clear :-) Thanks for chasing down this issue, the patch
is in my git tree now. I guess I must have had some other option turned
on when I did my UP build that caused this not to happen,
Spinlock
Print error with log_error() to be consistent with others.
Signed-off-by: David Teigland [EMAIL PROTECTED]
---
fs/gfs2/locking/dlm/mount.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/locking/dlm/mount.c b/fs/gfs2/locking/dlm/mount.c
index ab30102..f2efff4
Hi guys,
this is purely cosmetic and I didn't prepare a patch but see this:
given a 4GB block device (just as an example):
/dev/nbd2 3,9G 518M 3,4G 14% /mnt/gfs2
/dev/nbd1 3,1G 20K 3,1G 1% /mnt/gfs
you can see that gfs1 masks the device size to hide the
Fabio Massimo Di Nitto wrote:
Hi guys,
this is purely cosmetic and I didn't prepare a patch but see this:
given a 4GB block device (just as an example):
/dev/nbd2 3,9G 518M 3,4G 14% /mnt/gfs2
/dev/nbd1 3,1G 20K 3,1G 1% /mnt/gfs
you can see that gfs1 masks the
CVSROOT:/cvs/cluster
Module name:cluster
Branch: RHEL5
Changes by: [EMAIL PROTECTED] 2007-11-16 23:22:23
Modified files:
gfs2/fsck : metawalk.c pass1.c pass1c.c pass2.c pass5.c
Log message:
Resolves: bz 382581: GFS2: gfs2_fsck: buffer still
